codenarc-developer Mailing List for CodeNarc (Page 2)
Brought to you by:
chrismair
This list is closed, nobody may subscribe to it.
2010 |
Jan
|
Feb
|
Mar
|
Apr
(8) |
May
(17) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(8) |
Nov
(67) |
Dec
(9) |
---|---|---|---|---|---|---|---|---|---|---|---|---|
2011 |
Jan
(23) |
Feb
(19) |
Mar
(15) |
Apr
(7) |
May
(5) |
Jun
(43) |
Jul
(5) |
Aug
(11) |
Sep
(18) |
Oct
(9) |
Nov
(6) |
Dec
|
2012 |
Jan
(7) |
Feb
(2) |
Mar
(7) |
Apr
|
May
|
Jun
|
Jul
(17) |
Aug
(5) |
Sep
|
Oct
(1) |
Nov
|
Dec
(1) |
2013 |
Jan
|
Feb
(1) |
Mar
(7) |
Apr
|
May
(6) |
Jun
|
Jul
(2) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
2014 |
Jan
(6) |
Feb
(3) |
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
2016 |
Jan
(2) |
Feb
|
Mar
|
Apr
(2) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
2017 |
Jan
|
Feb
|
Mar
(4) |
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
From: Garvin L. <gar...@gm...> - 2013-03-29 19:28:46
|
OK, I am using the command line with the Maven plugin to avoid some of the classloader issues so it looks like I will have to get creative. Regards, Garvin LeClaire gar...@gm... On Fri, Mar 29, 2013 at 3:25 PM, Chris Mair <chr...@ea...> wrote: > Garvin, > >>> It looks like the command line version only takes one source directory > through the basedir option while we are >>> able to have multiple source directories with the ANT Task. >>> >>> Is this correct? If so, is there a reason why? > > Yes, that is correct. The intent is to use basedir specify the root dir, and > then use -includes and -excludes to add/filter any and all subdirectories > and file patterns as necessary. The command-line processor is not based on > Ant FileSets, and is thus not as rich/flexible as the Ant Task. > > Chris > |
From: Chris M. <chr...@ea...> - 2013-03-29 19:25:20
|
Garvin, >> It looks like the command line version only takes one source directory through the basedir option while we are >> able to have multiple source directories with the ANT Task. >> >> Is this correct? If so, is there a reason why? Yes, that is correct. The intent is to use basedir specify the root dir, and then use -includes and -excludes to add/filter any and all subdirectories and file patterns as necessary. The command-line processor is not based on Ant FileSets, and is thus not as rich/flexible as the Ant Task. Chris |
From: Garvin L. <gar...@gm...> - 2013-03-29 18:31:06
|
It looks like the command line version only takes one source directory through the basedir option while we are able to have multiple source directories with the ANT Task. Is this correct? If so, is there a reason why? Regards, Garvin LeClaire gar...@gm... |
From: Hamlet D. <ham...@ca...> - 2013-03-19 06:03:37
|
What statistic could we collect that would event ually lead us to make Codenarc a better product? -- Hamlet D'Arcy ham...@ca... ----- Original Message ----- > Hamlet, I believe you wanted this on the mailing list as well :) > On 18 March 2013 09:38, Hamlet D'Arcy < ham...@gm... > wrote: > > One of the features of Groovy 2.0 is the static typing option. > > Supposedly, the static types of variables, parameters, and fields > > are now somewhere in the AST. I don't know for sure how reliable > > the > > data is, but my expectation is that if we find a bug or missing > > type > > information that the Groovy team would consider it a defect and fix > > the issue. So it is sort of a safe feature to use. > > > Someone correct me if I am wrong, but I believe that CodeNarc is > > not > > currently using this data during analysis. I recommend working on > > using this new type information to drive rules. > > Thanks for the idea! I guess, however, that this would demand > migrating CodeNarc to groovy 2.0 or later? Will CodeNarc-dependent > libs be ok with that? > > You will have to look through other products' rulesets and just > > pick > > out some rules that require advanced type information. For example, > > there might be a rule named "don't do X on a File object". In the > > past we never knew if a parameter or variable was really a File so > > we could not write the rule. But with Groovy 2.0 we do know. A real > > example, is don't call File.getText() within a loop because it > > would > > read the entire contents of a file into a String on every > > iteration. > > Here are some rulesets from other products: > > > * http://www.hpenterprisesecurity.com/vulncat/en/vulncat/index.html > > > * > > http://www.klocwork.com/products/documentation/current/Java_checker_reference > > > * > > https://www.securecoding.cert.org/confluence/display/java/The+CERT+Oracle+Secure+Coding+Standard+for+Java > > > * http://pmd.sourceforge.net/pmd-5.0.2/rules/index.html > > > * http://findbugs.sourceforge.net/bugDescriptions.html > > > Good luck! > > Thanks! > What do you think about the stats collection idea? Do you have any > info on adoption of new versions of CodeNarc? > Best regards, > Artur Gajowy > ------------------------------------------------------------------------------ > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_mar > _______________________________________________ > Codenarc-developer mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codenarc-developer |
From: Chris M. <chr...@ea...> - 2013-03-19 01:54:32
|
Artur, Thanks for your contributions and interest and help. As Hamlet indicated, there are a bunch of existing feature requests for rules that are currently impossible or impractical given the limitations of the AST stage and contents, at least with Groovy 1.7. If Groovy 2.x does fill some of those gaps, that would certainly be one worthwhile thing to explore. I think upgrading the minimal requirement for CodeNarc to Groovy 2.x would be possible. I don't take that decision lightly, but CodeNarc is a tool rather than a framework, and there is no requirement that application code run at the same Groovy level that CodeNarc uses. The stats collection angle is intriguing. It would have to be non-intrusive and "opt-in", rather than on by default. It seems very ambitious, but if you have ideas on how to implement that, it does sound cool. I was not planning on putting out another release for at least a couple months, and probably more (busy on other projects), but that could be negotiable. We only moved to the Sonatype Maven repository with the 0.18 release back in November 2012, so we only have download stats since December 2012. And note that 0.18.1 came out in February. December 2012 (version count percentage) 0.16.1 174 0.169591 0.5 2 0.001949 0.6 3 0.002924 0.7 3 0.002924 0.8 2 0.001949 0.9 6 0.005848 0.8.1 2 0.001949 0.1 2 0.001949 0.11 4 0.003899 0.12 2 0.001949 0.13 4 0.003899 0.14 17 0.016569 0.15 156 0.152047 0.16 4 0.003899 0.17 538 0.524366 0.18 105 0.102339 0.13-RC1 2 0.001949 January 2013 (version count percentage) 0.16.1 247 0.125063 0.5 2 0.001013 0.6 2 0.001013 0.7 4 0.002025 0.8 2 0.001013 0.9 10 0.005063 0.8.1 3 0.001519 0.1 2 0.001013 0.11 14 0.007089 0.12 2 0.001013 0.13 6 0.003038 0.14 21 0.010633 0.15 144 0.072911 0.16 2 0.001013 0.17 870 0.440506 0.18 642 0.325063 0.13-RC1 2 0.001013 February 2013 (version count percentage) 0.16.1 218 0.071312 0.9 9 0.002944 0.8.1 3 9.81E-04 0.1 2 6.54E-04 0.11 12 0.003925 0.13 4 0.001308 0.14 17 0.005561 0.15 121 0.039581 0.16 2 6.54E-04 0.17 1788 0.584887 0.18 675 0.220805 0.18.1 206 0.067386 Chris |
From: Artur G. <art...@gm...> - 2013-03-18 20:59:00
|
Hamlet, I believe you wanted this on the mailing list as well :) On 18 March 2013 09:38, Hamlet D'Arcy <ham...@gm...> wrote: > One of the features of Groovy 2.0 is the static typing option. Supposedly, > the static types of variables, parameters, and fields are now somewhere in > the AST. I don't know for sure how reliable the data is, but my expectation > is that if we find a bug or missing type information that the Groovy team > would consider it a defect and fix the issue. So it is sort of a safe > feature to use. > > Someone correct me if I am wrong, but I believe that CodeNarc is not > currently using this data during analysis. I recommend working on using > this new type information to drive rules. Thanks for the idea! I guess, however, that this would demand migrating CodeNarc to groovy 2.0 or later? Will CodeNarc-dependent libs be ok with that? > You will have to look through other products' rulesets and just pick out > some rules that require advanced type information. For example, there might > be a rule named "don't do X on a File object". In the past we never knew if > a parameter or variable was really a File so we could not write the rule. > But with Groovy 2.0 we do know. A real example, is don't call > File.getText() within a loop because it would read the entire contents of a > file into a String on every iteration. Here are some rulesets from other > products: > > * http://www.hpenterprisesecurity.com/vulncat/en/vulncat/index.html > * > http://www.klocwork.com/products/documentation/current/Java_checker_reference > * > https://www.securecoding.cert.org/confluence/display/java/The+CERT+Oracle+Secure+Coding+Standard+for+Java > * http://pmd.sourceforge.net/pmd-5.0.2/rules/index.html > * http://findbugs.sourceforge.net/bugDescriptions.html > > Good luck! > Thanks! What do you think about the stats collection idea? Do you have any info on adoption of new versions of CodeNarc? Best regards, Artur Gajowy |
From: Artur G. <art...@gm...> - 2013-03-17 23:04:35
|
Hi Guys! As you might have seen, I've recently done two<https://github.com/CodeNarc/CodeNarc/pull/12> pull requests <https://github.com/CodeNarc/CodeNarc/pull/13> to CodeNarc, both containing a rule implementation. There are more to come, as I am doing a M.Sc. thesis on CodeNarc. In my thesis I'd like to focus on implementing some feature requests (mainly: new rules). Which feature requests I'll implement is not sealed yet (and probably won't be until I finish my thesis... :)), and I'd like to ask you for direction in this matter. Are there any feature requests that you would especially like implemented in the first place? What would the users benefit from the most? If time allows me (I'd like to defend the thesis in July; September is - I think - the last possible deadline...) I'll be more than happy to follow any of your advice. BTW: I've got some ideas for new features as well. Most of them are new rules and I'll probably add some feature requests for them soon. There is, however, one (bolder) proposal I'd like to discuss with you as soon as possible: gathering statistical information on CodeNarc's usage. I think it would be great to somehow measure how popular rules are, how often they get @SuppressWarnings, how often they are violated and how these numbers change over time. Also, how is CodeNarc run (ant task, Sonar analysis, IDE plugin, command line, etc...). Another idea is to gather some code snippets around violations and suppresions (by default off, if one agrees - by default obfuscated). I feel that all this information can be a great guide for CodeNarc maintainers (and analysing it for rules implemented by me would be a great addition to my thesis :)). I would be very happy to implement such a feature for CodeNarc, but - due to aforementioned time constraints - am hesitant to undertake the effort if I there is not hope that we'll gather some data that I could use in my thesis. Otherwise I'd like to focus on implementing new rules. Could you shed some light on how fast new versions of CodeNarc are adopted (and, therefore, how fast we can get any data at all)? I think, according to this SO thread<http://stackoverflow.com/questions/8874670/maven-detailed-download-statistics-for-artifacts-of-public-repositories-like>you should have such data available. Best regards, Artur Gajowy P.S. The seed of all this was planted by Hamlet D'Arcy during a hackergarten on the first edition of 33rd Degree <http://33degree.org>(Cracow, Poland, two years ago), where we drank beer and made an attempt to implement EqualsOverloadedRule. The commit is here<https://github.com/CodeNarc/CodeNarc/commit/3320a8>. Just thought you'd like to know :) |
From: Chris M. <chr...@ea...> - 2013-02-16 16:31:56
|
Just FYI, as recommended (required?) by SourceForge, I have upgraded the CodeNarc project to use their new Allura platform. This should have minimal or no impact, especially since we now use GitHub instead of the SourceForge SVN repo. Chris |
From: Chris M. <chr...@ea...> - 2012-12-02 14:43:20
|
Hamlet, Given the problems with the CodeNarc UnnecessarySubstring rule: https://sourceforge.net/tracker/?func=detail <https://sourceforge.net/tracker/?func=detail&aid=3424614&group_id=250145&at id=1126573> &aid=3424614&group_id=250145&atid=1126573 should we just deprecate that rule (set enabled=false and document as deprecated)? Or do you think it deserves further investigation - in which case I'm fine with doing nothing for now? Chris |
From: Chris M. <chr...@ea...> - 2012-10-26 00:41:02
|
Feature request #3578909 <https://sourceforge.net/tracker/?func=detail&aid=3578909&group_id=250145&at id=1126575> , which requested that the CodeNarc test framework be moved into the main CodeNarc distribution jar has been completed. That includes: . Move test framework classes into src/main/groovy and include in distribution jar. . Upgrade tests and test framework to JUnit 4 . Move helper methods from AbstractTestCase into new TestUtil class (potentially reusable within other test frameworks, e.g. Spock) Chris |
From: Chris M. <chr...@ea...> - 2012-08-08 22:47:52
|
We have moved the CodeNarc source code over to GitHub <http://github.com/CodeNarc> . Many thanks to Marcin Erdmann for performing the migration. Note that the project web site <http://codenarc.sourceforge.net/index.html> , download files and bug/feature trackers are still hosted on Sourceforge <http://sourceforge.net/projects/codenarc/> , at least for the time being. Chris |
From: <chr...@we...> - 2012-08-01 23:35:13
|
Thanks Hamlet. Yes, that sounds good. I will update and republish the web site when I have a chance. -----Original Message----- From: Hamlet DArcy [mailto:ham...@ca...] Sent: Wednesday, August 01, 2012 9:40 AM To: Marcin Erdmann Cc: cod...@li... Subject: Re: [Codenarc-developer] My views on making it easier for people to contribute Yes, yes. Keep the webpage on sourceforge. As for the issue tracker... I greatly prefer the github issue tracker and the Git/Tracker integration. So it is a PITA but I will convert the issues over myself. It might be a few days though (like not until this weekend). -- Hamlet D'Arcy ham...@ca... ----- Original Message ----- > I recon that for simplicity we should stay with the web page and the > tracker as well in Sourceforge. Migrating those 150 issues that Chris > has mentioned will definitely be a PITA. > > I have a simple version of a gradle build ready which allows me to > build > the project and run the tests. Will have a go at site generation now. > > Marcin > > On 08/01/2012 09:25 AM, Hamlet DArcy wrote: > > Concerning the website... > > > > Currently the website is hosted at http://codenarc.sourceforge.net/ > > It is possible to host pages on GitHub, but for simplicity I > > suggest we leave everything where it is. > > > > However, the web pages we generate with the Maven Site plugin have > > a link to the SourceForge bug tracker. We should change this link > > so it links to the GitHub bug tracker. There is also a link to > > "SourceForge Project". We should change this to be "GitHub > > Project". Also, it would be nice to add the little "Fork me on > > GitHub" ribbon to the site... not sure how hard that is to do. > > > > > > -- > > Hamlet D'Arcy > > ham...@ca... > > > > ----- Original Message ----- > >> > >> > >>>> Also, we will need to change the website links and republish. > >>>> The > >>>> whole site is stored in Github now. > >> > >> > >> I am still a bit confused. Is the website already being "hosted" > >> in > >> GitHub? If so, what is the link? If not, where is the intended > >> home, > >> GitHub or Sourceforge? > >> > >> > >> > >> Chris > >> > >> > >> > >> > >> ------------------------------------------------------------------------------ > >> Live Security Virtual Conference > >> Exclusive live event will cover all the ways today's security and > >> threat landscape has changed and how IT managers can respond. > >> Discussions > >> will include endpoint security, mobile security and the latest in > >> malware > >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > >> _______________________________________________ > >> Codenarc-developer mailing list > >> Cod...@li... > >> https://lists.sourceforge.net/lists/listinfo/codenarc-developer > >> > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. > Discussions > will include endpoint security, mobile security and the latest in > malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Codenarc-developer mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Codenarc-developer mailing list Cod...@li... https://lists.sourceforge.net/lists/listinfo/codenarc-developer |
From: Hamlet D. <ham...@ca...> - 2012-08-01 13:40:21
|
Yes, yes. Keep the webpage on sourceforge. As for the issue tracker... I greatly prefer the github issue tracker and the Git/Tracker integration. So it is a PITA but I will convert the issues over myself. It might be a few days though (like not until this weekend). -- Hamlet D'Arcy ham...@ca... ----- Original Message ----- > I recon that for simplicity we should stay with the web page and the > tracker as well in Sourceforge. Migrating those 150 issues that Chris > has mentioned will definitely be a PITA. > > I have a simple version of a gradle build ready which allows me to > build > the project and run the tests. Will have a go at site generation now. > > Marcin > > On 08/01/2012 09:25 AM, Hamlet DArcy wrote: > > Concerning the website... > > > > Currently the website is hosted at http://codenarc.sourceforge.net/ > > It is possible to host pages on GitHub, but for simplicity I > > suggest we leave everything where it is. > > > > However, the web pages we generate with the Maven Site plugin have > > a link to the SourceForge bug tracker. We should change this link > > so it links to the GitHub bug tracker. There is also a link to > > "SourceForge Project". We should change this to be "GitHub > > Project". Also, it would be nice to add the little "Fork me on > > GitHub" ribbon to the site... not sure how hard that is to do. > > > > > > -- > > Hamlet D'Arcy > > ham...@ca... > > > > ----- Original Message ----- > >> > >> > >>>> Also, we will need to change the website links and republish. > >>>> The > >>>> whole site is stored in Github now. > >> > >> > >> I am still a bit confused. Is the website already being "hosted" > >> in > >> GitHub? If so, what is the link? If not, where is the intended > >> home, > >> GitHub or Sourceforge? > >> > >> > >> > >> Chris > >> > >> > >> > >> > >> ------------------------------------------------------------------------------ > >> Live Security Virtual Conference > >> Exclusive live event will cover all the ways today's security and > >> threat landscape has changed and how IT managers can respond. > >> Discussions > >> will include endpoint security, mobile security and the latest in > >> malware > >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > >> _______________________________________________ > >> Codenarc-developer mailing list > >> Cod...@li... > >> https://lists.sourceforge.net/lists/listinfo/codenarc-developer > >> > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. > Discussions > will include endpoint security, mobile security and the latest in > malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Codenarc-developer mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > |
From: Marcin E. <mar...@pr...> - 2012-08-01 13:21:26
|
I recon that for simplicity we should stay with the web page and the tracker as well in Sourceforge. Migrating those 150 issues that Chris has mentioned will definitely be a PITA. I have a simple version of a gradle build ready which allows me to build the project and run the tests. Will have a go at site generation now. Marcin On 08/01/2012 09:25 AM, Hamlet DArcy wrote: > Concerning the website... > > Currently the website is hosted at http://codenarc.sourceforge.net/ > It is possible to host pages on GitHub, but for simplicity I suggest we leave everything where it is. > > However, the web pages we generate with the Maven Site plugin have a link to the SourceForge bug tracker. We should change this link so it links to the GitHub bug tracker. There is also a link to "SourceForge Project". We should change this to be "GitHub Project". Also, it would be nice to add the little "Fork me on GitHub" ribbon to the site... not sure how hard that is to do. > > > -- > Hamlet D'Arcy > ham...@ca... > > ----- Original Message ----- >> >> >>>> Also, we will need to change the website links and republish. The >>>> whole site is stored in Github now. >> >> >> I am still a bit confused. Is the website already being "hosted" in >> GitHub? If so, what is the link? If not, where is the intended home, >> GitHub or Sourceforge? >> >> >> >> Chris >> >> >> >> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. >> Discussions >> will include endpoint security, mobile security and the latest in >> malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> Codenarc-developer mailing list >> Cod...@li... >> https://lists.sourceforge.net/lists/listinfo/codenarc-developer >> |
From: Hamlet D. <ham...@ca...> - 2012-08-01 08:25:45
|
Concerning the website... Currently the website is hosted at http://codenarc.sourceforge.net/ It is possible to host pages on GitHub, but for simplicity I suggest we leave everything where it is. However, the web pages we generate with the Maven Site plugin have a link to the SourceForge bug tracker. We should change this link so it links to the GitHub bug tracker. There is also a link to "SourceForge Project". We should change this to be "GitHub Project". Also, it would be nice to add the little "Fork me on GitHub" ribbon to the site... not sure how hard that is to do. -- Hamlet D'Arcy ham...@ca... ----- Original Message ----- > > > > >> Also, we will need to change the website links and republish. The > >> whole site is stored in Github now. > > > > I am still a bit confused. Is the website already being "hosted" in > GitHub? If so, what is the link? If not, where is the intended home, > GitHub or Sourceforge? > > > > Chris > > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. > Discussions > will include endpoint security, mobile security and the latest in > malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Codenarc-developer mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > |
From: Christopher M. <chr...@ea...> - 2012-07-31 20:14:41
|
<HEAD> <STYLE>body{font-size:10pt;font-family:arial,sans-serif;background-color:#ffffff;color:black;}p{margin:0px;}</STYLE> <META name=GENERATOR content="MSHTML 9.00.8112.16447"></HEAD> <BODY> <P><FONT color=#000000><FONT size=2><FONT face=arial,sans-serif>>> Also, we will need to change the website links and republish. The whole site is stored in Github now.</P></FONT></FONT></FONT> <P><FONT color=#000000><FONT size=2><FONT face=arial,sans-serif></FONT></FONT></FONT> </P> <P><FONT color=#000000><FONT size=2><FONT face=arial,sans-serif>I am still a bit confused. Is the website already being "hosted" in GitHub? If so, what is the link? If not, where is the intended home, GitHub or Sourceforge?</FONT></FONT></FONT></P> <P> </P> <P>Chris</P> <P><FONT color=#000000><FONT size=2><FONT face=arial,sans-serif> </P> <P></FONT></FONT></FONT> </P></BODY> |
From: Christopher M. <chr...@ea...> - 2012-07-31 13:15:30
|
<HEAD> <STYLE>body{font-size:10pt;font-family:arial,sans-serif;background-color:#ffffff;color:black;}p{margin:0px;}</STYLE> <META name=GENERATOR content="MSHTML 9.00.8112.16447"></HEAD> <BODY><FONT color=#000000><FONT size=2><FONT face=arial,sans-serif> <P style="MARGIN: 0in 0in 0pt" class=MsoNormal><SPAN style="FONT-FAMILY: 'Calibri','sans-serif'; COLOR: #1f497d; FONT-SIZE: 11pt">Thanks very much for the migration work. When I get free time , I am trying to catch up – setting up my SSH keys, getting IDEA setup to use GitHub, etc.<?xml:namespace prefix = o ns = "urn:schemas-microsoft-com:office:office" /><o:p></o:p></SPAN></P> <P style="MARGIN: 0in 0in 0pt" class=MsoNormal><SPAN style="FONT-FAMILY: 'Calibri','sans-serif'; COLOR: #1f497d; FONT-SIZE: 11pt"><o:p> </o:p></SPAN></P> <P style="MARGIN: 0in 0in 0pt" class=MsoNormal><SPAN style="FONT-FAMILY: 'Calibri','sans-serif'; COLOR: #1f497d; FONT-SIZE: 11pt">Chris</SPAN></FONT></FONT></FONT></ZZZHTML></P></BODY> |
From: Marcin E. <mar...@pr...> - 2012-07-31 12:08:08
|
After migrating to gradle we can use gradle-git-plugin(https://github.com/ajoberstar/gradle-git) which apparently has the capabilities to easily upload github pages. I will have a go at the gradle migration now, but don't expect a pull request before the end of August as I'm soon going for holidays. Marcin On 07/31/2012 04:26 AM, Hamlet D'Arcy wrote: > > Also, we will need to change the website links and republish. The > whole site is stored in Github now. > > On Jul 30, 2012 10:31 PM, "Marcin Erdmann" <mar...@pr... > <mailto:mar...@pr...>> wrote: > > Chris, > > Looks to me that all of the code, history, branches and tags are > already on Github. I've also managed to map your svn usernames to > your github ones so commits link to your user profiles. Please let > me know if something is missing or wrong. > > You might want to change the README.txt as it's displayed on the > ropository page and it looks a bit strange with those > placeholders. I also suggest commiting a change to the svn repo > which will leave only a readme file in there saying that the code > has been moved so people who get there by a mistake will know what > is going on. > > Marcin > > On 07/29/2012 07:17 PM, Chris Mair wrote: >> >> Okay, I think that I have created a *CodeNarc* organization >> (https://github.com/CodeNarc) and a *CodeNarc* repository. >> >> I created a “Git Migration” team that has *Push & Pull* access, >> and added Marcin. >> >> Hamlet: I also added HamletDRC as an owner – feel free to make >> admin changes as necessary. >> > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. > Discussions > will include endpoint security, mobile security and the latest in > malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Codenarc-developer mailing list > Cod...@li... > <mailto:Cod...@li...> > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > |
From: Hamlet D'A. <ham...@gm...> - 2012-07-31 03:27:00
|
Also, we will need to change the website links and republish. The whole site is stored in Github now. On Jul 30, 2012 10:31 PM, "Marcin Erdmann" <mar...@pr...> wrote: > Chris, > > Looks to me that all of the code, history, branches and tags are already > on Github. I've also managed to map your svn usernames to your github ones > so commits link to your user profiles. Please let me know if something is > missing or wrong. > > You might want to change the README.txt as it's displayed on the > ropository page and it looks a bit strange with those placeholders. I also > suggest commiting a change to the svn repo which will leave only a readme > file in there saying that the code has been moved so people who get there > by a mistake will know what is going on. > > Marcin > > On 07/29/2012 07:17 PM, Chris Mair wrote: > > Okay, I think that I have created a *CodeNarc* organization ( > https://github.com/CodeNarc) and a *CodeNarc* repository. **** > > ** ** > > I created a “Git Migration” team that has *Push & Pull* access, and added > Marcin.**** > > ** ** > > Hamlet: I also added HamletDRC as an owner – feel free to make admin > changes as necessary. > > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Codenarc-developer mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > > |
From: Marcin E. <mar...@pr...> - 2012-07-30 20:30:57
|
Chris, Looks to me that all of the code, history, branches and tags are already on Github. I've also managed to map your svn usernames to your github ones so commits link to your user profiles. Please let me know if something is missing or wrong. You might want to change the README.txt as it's displayed on the ropository page and it looks a bit strange with those placeholders. I also suggest commiting a change to the svn repo which will leave only a readme file in there saying that the code has been moved so people who get there by a mistake will know what is going on. Marcin On 07/29/2012 07:17 PM, Chris Mair wrote: > > Okay, I think that I have created a *CodeNarc* organization > (https://github.com/CodeNarc) and a *CodeNarc* repository. > > I created a "Git Migration" team that has *Push & Pull* access, and > added Marcin. > > Hamlet: I also added HamletDRC as an owner -- feel free to make admin > changes as necessary. > |
From: Marcin E. <mar...@pr...> - 2012-07-29 19:49:20
|
Cool, I'll try to find some time tomorrow to push the source code over to Github. Marcin On Jul 29, 2012 7:17 PM, "Chris Mair" <chr...@ea...> wrote: > Okay, I think that I have created a *CodeNarc* organization ( > https://github.com/CodeNarc) and a *CodeNarc* repository. **** > > ** ** > > I created a “Git Migration” team that has *Push & Pull* access, and added > Marcin.**** > > ** ** > > Hamlet: I also added HamletDRC as an owner – feel free to make admin > changes as necessary.**** > > ** ** > > *From:* Marcin Erdmann [mailto:mar...@pr...] > *Sent:* Sunday, July 29, 2012 6:36 AM > *To:* cod...@li... > *Subject:* Re: [Codenarc-developer] My views on making it easier for > people to contribute**** > > ** ** > > Chris, > > That's great news! As promised I will perform the migration as soon as I > will receive rights to push to codenarc github repo. My username on github > is erdi. > > 1) Creating an organisation and a repo both called codenarc is the way to > go in my opinion. I was also thinking about the fact that the artifactId > for the project is 'CodeNarc' not 'codenarc' but it's up to you which case > style you'll choose for the organisation and repo, but as I said, same > organisation and repo name is the way to go. > > 2) I don't believe that it's necessary to migrate everything to github. > It's the git repository hosting that we are going there for, so leaving > everything else in Sourceforge as it is ok for me and it's definitely less > work. I would only put links to the repository on github and tracker on > Sourceforge in the 'General' links section on the project website and > that's it. In my opinion anything more than that is simple not worth it. > > Marcin > > On 07/28/2012 03:33 PM, Chris Mair wrote:**** > > Marcin,**** > > **** > > Thank you very much for your offers to help, explanations and patience. > We’d like to take you up on your generous offer to perform the CodeNarc > GitHub migration.**** > > **** > > Much of this is new to me, so I ask your continued patience.**** > > **** > > (1) I plan to create a GitHub organization called “*codenarc*” and then a > repo called “*codenarc*”. Is that appropriate?**** > > **** > > (2) Is the expectation that we will completely abandon the existing > Sourceforge hosting? I assume so. That means we use GitHub for web site > hosting, bug tracking, feature requests, etc.. So, what should happen to > the existing tracker issues (a few hundred, including 125 open feature > requests)?**** > > **** > > Thanks.**** > > Chris**** > > **** > > *From:* Marcin Erdmann [mailto:mar...@pr...<mar...@pr...>] > > *Sent:* Thursday, July 26, 2012 8:14 AM > *To:* cod...@li... > *Subject:* Re: [Codenarc-developer] My views on making it easier for > people to contribute**** > > **** > > Hamlet,**** > > **** > > I believe that there actually is a lot of benefit in migrating to github. > >From a contributor point of view I can tell that the step where you have > to send email with the patch is a PITA. Apart from it being an outdated > technique you also have to know who to send the email to. I knew that I can > send it to you but others might struggle to find appropriate addresses and > I can't easily find any info on where and how to send contributions on the > project site.**** > > **** > > There are several other benefits I can see apart from the social one you > mentioned:**** > > - anyone who has ever contributed to an open source project will probably > have their github stuff set up, because most of the projects are hosted on > github and will know how to create a pull request**** > > - people don't have to wonder how to contribute - they will know that they > should simply fork the repo and submit a pull request**** > > - with git being a distributed vcs you get the possibility to do local > commits and back them up on github in your own fork, which means you can > work on the patch on any machine (this gets even easier if we had a gradle > build with a wrapper because setting up a project is just a matter of > calling 'gradlew idea')**** > > - you have one central place when you can comment on people's > contributions and it's easier for other developers from Codenarc team to > get involved in the discussion **** > > - people can change their pull requests by adding your suggestions to it > by just pushing to the branch pull request is based on in their fork**** > > **** > > As I said, I volunteer to perform the migration - someone has to simply > create an organisation and a repo on github and give my access to it for > the time of the migration. I will use git-svn, so the whole history, > branches and tags will still be there. And I definitely don't believe it's > going to take 4 hours. :)**** > > **** > > I think that we should try to get the site plugin from gradle integrated > into to the build as well. It's there to be used and why should you change > the way you generate your documentation and do it manually if you don't > have to? Let's try to do a full migration and worry later if there actually > are any problems.**** > > **** > > Glad to read that you see my good intentions in my suggestions. And I'm > not here to just whine about stuff - I'm eager to help. It's just you that > have to decide if you want to accept my help.**** > > **** > > Marcin**** > > On Thu, Jul 26, 2012 at 12:13 PM, Hamlet DArcy <ham...@ca...> > wrote:**** > > How does Subversion prevent Netflix employees from contributing rules back? > Have you written custom rules that you haven't submitted back, and just > don't want to see the hassle of messing with Subversion? > > Full disclosure: I'm the guy that doesn't see the benefit of Git for > CodeNarc. I wrote up the process of pull, code, commit, pull request/patch > for both Subversion and GitHub. Both processes had roughly the same number > of bullet points and took roughly the same time. From a contributors > viewpoint, I don't see any improvement. > > GitHub: > * Fork > * Git Pull > * Write Code > * Commit and Push > * Pull request and type up a nice message > > Subversion > * svn co https://sourceforge.subversion.com/codenarc/trunk > * Write Code > * svn diff > my_patch.patch > * Attach patch to ticket or email me the patch > > And that assumes the contributor already has a GitHub account and has > already navigated the steps to create keys and get an account. > > I *do* see a benefit of GitHub. There is a "social coding" aspect to it > where developers can easily get recognition and kudos for the work they do. > Much more so than just getting your name in our release notes :) > > If anyone feels motivated to do the work and make the switch then I guess > we should go for it. It will have some benefit. Based on my analysis, I am > personally not motivated to do this work. I feel like the migration would > take about 4 hours of my time. Writing 2 new analysis rules would also take > about 4 hours. I'm just talking about me personally, but I'm going to spend > time on rules for the time being because it offers a better return on > investment. > > As for Gradle... I see good benefits, like being able to run the tests > against Groovy 1.8 and Groovy 2.0, automating our release more, and rolling > the create-rule script into a Gradle task. Plus, the Gradle Wrapper is > great. What holds us back is the Site stuff. What I would do in a Gradle > conversion is forget about the Site plugin. I'd just take all of our HTML > and check it into VCS. The only part that changes is the rule descriptions > that get updated with every rule. You could just change the create-rule > script to update an HTML page instead of a wiki markup page and be done. > > And finally... thanks for caring about CodeNarc. It's a special project > for me and it means a lot to hear some voices from people who care. > > -- > Hamlet D'Arcy > ham...@ca...**** > > > ----- Original Message ----- > > +1 on prioritizing the Git/Github move. I know that keeps us from > > doing more with CodeNarc at Netflix. Github is probably the single > > best thing you can do with your project to get more developer use and > > contributions. I don't see a move to Gradle buying you as much, seems > > like a lateral change. > > > > On Wed, Jul 25, 2012 at 5:42 AM, Marcin Erdmann > > <mar...@pr...> wrote: > > > Chris, > > > > > > I believe migrating to git is more essential when it comes to > > > getting people > > > to contribute more easily to the project but I also understand your > > > reservations towards it and understand that you see it as a big > > > step > > > especially as the project owner you need to be confident about the > > > vcs > > > you're using. > > > > > > Yes, I'm still up to helping out with the gradle migration of > > > course. I will > > > have a go at it during the weekend. I have some questions though. > > > What do we > > > exactly need to port? It's of course building and running the > > > tests, > > > deploying to Codehaus maven repo (we're doing it in geb, so I will > > > probably > > > have a look at how it's done there) and generating (also > > > uploading?) the > > > site. Is there anything else? I'm not a maven specialist so can you > > > please > > > list all of the commands you're using in your workflow to achieve > > > the > > > aforementioned tasks? What version of maven/other setup I need to > > > run all of > > > the tasks? > > > > > > I still haven't received any response from Rene about the site > > > plugin but I > > > will try to use it anyway and get it to a working state if > > > necessary. > > > > > > Thanks, > > > Marcin > > > > > > > > > On Wed, Jul 25, 2012 at 3:03 AM, Chris Mair > > > <chr...@ea...> wrote: > > >> > > >> Marcin, > > >> > > >> I was expecting/hoping that we could treat these as two separate > > >> issues. > > >> I'm > > >> not sure that I am up for trying to tackle both at the same time. > > >> At some > > >> point, I need to do some analysis to figure out the impacts of a > > >> migration > > >> from Sourceforge+SVN to GitHub+Git. > > >> > > >> I am probably more eager to do the Gradle migration, assuming that > > >> it now > > >> supports the features that we need. I am also interested in > > >> getting more > > >> experience with Git, but I expect that will be more disruptive. > > >> > > >> Is doing one without the other (let's say doing Gradle), still > > >> feasible, > > >> and > > >> still something you'd want to help with? > > >> > > >> Thanks. > > >> Chris > > >> -----Original Message----- > > >> From: Marcin Erdmann [mailto:mar...@pr...] > > >> Sent: Saturday, July 21, 2012 11:30 AM > > >> To: Chris Mair > > >> Cc: cod...@li... > > >> Subject: Re: [Codenarc-developer] My views on making it easier for > > >> people > > >> to > > >> contribute > > >> > > >> Chris, > > >> > > >> I'm glad to hear that you like my ideas. Here are the two feature > > >> requests > > >> on Sourceforge tracker: > > >> > > >> > https://sourceforge.net/tracker/?func=detail&aid=3546737&group_id=250145&ati > > >> d=1126575 > > >> > > >> > https://sourceforge.net/tracker/?func=detail&aid=3546740&group_id=250145&ati > > >> d=1126575 > > >> > > >> When it comes to the site plugin I'm currently waiting for a > > >> response from > > >> Rene Gröschke on the status of the plugin > > >> (https://github.com/breskeby/GradleSite). After having a quick > > >> peek at it > > >> I > > >> believe it is finished. It's not in central but I could put it > > >> there cause > > >> I > > >> have rights to 'org.gradle.api.plugins' group in Sonatype OSS > > >> repo. > > >> > > >> I can start working on the build migration as soon as we'll put > > >> the code > > >> into github - I will create a fork of it and submit a pull request > > >> when > > >> it's > > >> ready. I can also help in migrating the source to github, I've > > >> migrated > > >> some > > >> repos in the past from svn to github using git-svn and could pull > > >> the > > >> source > > >> into the new repo given that I will get commit access to > > >> CodeNarc's github > > >> repository - I won't mind if you revoke it after the migration is > > >> done. > > >> > > >> Cheers, > > >> Marcin > > >> > > >> On 07/21/2012 02:35 PM, Chris Mair wrote: > > >> > Marcin, > > >> > > > >> > Thank you for the feedback (and the CodeNarc contributions). > > >> > > > >> > I am open to both ideas. Can you please open a feature request > > >> > for > > >> > each suggestion (Git/Github and Gradle): > > >> > https://sourceforge.net/tracker/?group_id=250145&atid=1126575. > > >> > > > >> > Both have been informally suggested before, so it's probably > > >> > worth > > >> > getting them to a place where we can consolidate the discussion > > >> > of the > > >> > merits and trade-offs, and bring Hamlet into the discussion as > > >> > well. > > >> > One of the sticking points with Gradle previously was the lack > > >> > of a > > >> > site plugin, since we currently use Maven to generate the > > >> > CodeNarc web > > >> > site from APT files, and also generate the APT for the Rules > > >> > Index > > >> > page. I have not checked on the status of that lately. > > >> > > > >> > Thanks. > > >> > Chris > > >> > > > >> > -----Original Message----- > > >> > From: Marcin Erdmann [mailto:mar...@pr...] > > >> > Sent: Thursday, July 19, 2012 7:34 PM > > >> > To: cod...@li... > > >> > Subject: [Codenarc-developer] My views on making it easier for > > >> > people > > >> > to contribute > > >> > > > >> > Hi all, > > >> > > > >> > In the past I've contributed several rules and fixes to > > >> > Codenarc. > > >> > Recently we've added Codenarc to our project and we found a > > >> > major bug > > >> > in UnnecessarySemicolonRule and wanted to fix it. After checking > > >> > the > > >> > project state I've found out that it's still quite tedious to > > >> > contribute for two reasons - svn and maven. > > >> > > > >> > If you want to contribute to Codenarc you need to send patches > > >> > in > > >> > email, like I did by sending mails to Hamlet in the past. This > > >> > would > > >> > be much easier if the project was on github enabling people to > > >> > submit > > >> > pull request... I don't know if there is a CI build set up for > > >> > the > > >> > project but by putting it on github and hooking it up with > > >> > buildhive > > >> > you get CI builds for free, also for pull requests. Can you > > >> > please > > >> > explain what are the reasons for such a valuable project to be > > >> > still > > >> > using > > >> svn? > > >> > > > >> > The other thing is getting the project into your IDE. It would > > >> > be so > > >> > much easier if there was a gradle build available for the > > >> > project - > > >> > simply typing gradle idea would generate the project for you > > >> > with all > > >> > the dependencies in place and no additional settings/tweaks > > >> > needed. If > > >> > you're interested I could try to contribute by migrating current > > >> > maven > > >> > build to gradle. I'm already in talks with Rene Gröschke about > > >> > his > > >> > efforts > > >> in the past in that area. > > >> > > > >> > Cheers, > > >> > Marcin Erdmann > > >> > > > >> > > ---------------------------------------------------------------------- > > >> > ------ > > >> > -- > > >> > Live Security Virtual Conference > > >> > Exclusive live event will cover all the ways today's security > > >> > and > > >> > threat landscape has changed and how IT managers can respond. > > >> > Discussions will include endpoint security, mobile security and > > >> > the > > >> > latest in malware threats. > > >> > http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > >> > _______________________________________________ > > >> > Codenarc-developer mailing list > > >> > Cod...@li... > > >> > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > > >> > > > >> > > > >> > > > > > > > > > > ------------------------------------------------------------------------------ > > > Live Security Virtual Conference > > > Exclusive live event will cover all the ways today's security and > > > threat landscape has changed and how IT managers can respond. > > > Discussions > > > will include endpoint security, mobile security and the latest in > > > malware > > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > > _______________________________________________ > > > Codenarc-developer mailing list > > > Cod...@li... > > > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > > > > > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. > > Discussions > > will include endpoint security, mobile security and the latest in > > malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > Codenarc-developer mailing list > > Cod...@li... > > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > >**** > > **** > > ** ** > |
From: Chris M. <chr...@ea...> - 2012-07-29 18:17:17
|
Okay, I think that I have created a CodeNarc organization (https://github.com/CodeNarc) and a CodeNarc repository. I created a Git Migration team that has Push & Pull access, and added Marcin. Hamlet: I also added HamletDRC as an owner feel free to make admin changes as necessary. From: Marcin Erdmann [mailto:mar...@pr...] Sent: Sunday, July 29, 2012 6:36 AM To: cod...@li... Subject: Re: [Codenarc-developer] My views on making it easier for people to contribute Chris, That's great news! As promised I will perform the migration as soon as I will receive rights to push to codenarc github repo. My username on github is erdi. 1) Creating an organisation and a repo both called codenarc is the way to go in my opinion. I was also thinking about the fact that the artifactId for the project is 'CodeNarc' not 'codenarc' but it's up to you which case style you'll choose for the organisation and repo, but as I said, same organisation and repo name is the way to go. 2) I don't believe that it's necessary to migrate everything to github. It's the git repository hosting that we are going there for, so leaving everything else in Sourceforge as it is ok for me and it's definitely less work. I would only put links to the repository on github and tracker on Sourceforge in the 'General' links section on the project website and that's it. In my opinion anything more than that is simple not worth it. Marcin On 07/28/2012 03:33 PM, Chris Mair wrote: Marcin, Thank you very much for your offers to help, explanations and patience. Wed like to take you up on your generous offer to perform the CodeNarc GitHub migration. Much of this is new to me, so I ask your continued patience. (1) I plan to create a GitHub organization called codenarc and then a repo called codenarc. Is that appropriate? (2) Is the expectation that we will completely abandon the existing Sourceforge hosting? I assume so. That means we use GitHub for web site hosting, bug tracking, feature requests, etc.. So, what should happen to the existing tracker issues (a few hundred, including 125 open feature requests)? Thanks. Chris From: Marcin Erdmann [mailto:mar...@pr...] Sent: Thursday, July 26, 2012 8:14 AM To: cod...@li... Subject: Re: [Codenarc-developer] My views on making it easier for people to contribute Hamlet, I believe that there actually is a lot of benefit in migrating to github. >From a contributor point of view I can tell that the step where you have to send email with the patch is a PITA. Apart from it being an outdated technique you also have to know who to send the email to. I knew that I can send it to you but others might struggle to find appropriate addresses and I can't easily find any info on where and how to send contributions on the project site. There are several other benefits I can see apart from the social one you mentioned: - anyone who has ever contributed to an open source project will probably have their github stuff set up, because most of the projects are hosted on github and will know how to create a pull request - people don't have to wonder how to contribute - they will know that they should simply fork the repo and submit a pull request - with git being a distributed vcs you get the possibility to do local commits and back them up on github in your own fork, which means you can work on the patch on any machine (this gets even easier if we had a gradle build with a wrapper because setting up a project is just a matter of calling 'gradlew idea') - you have one central place when you can comment on people's contributions and it's easier for other developers from Codenarc team to get involved in the discussion - people can change their pull requests by adding your suggestions to it by just pushing to the branch pull request is based on in their fork As I said, I volunteer to perform the migration - someone has to simply create an organisation and a repo on github and give my access to it for the time of the migration. I will use git-svn, so the whole history, branches and tags will still be there. And I definitely don't believe it's going to take 4 hours. :) I think that we should try to get the site plugin from gradle integrated into to the build as well. It's there to be used and why should you change the way you generate your documentation and do it manually if you don't have to? Let's try to do a full migration and worry later if there actually are any problems. Glad to read that you see my good intentions in my suggestions. And I'm not here to just whine about stuff - I'm eager to help. It's just you that have to decide if you want to accept my help. Marcin On Thu, Jul 26, 2012 at 12:13 PM, Hamlet DArcy <ham...@ca...> wrote: How does Subversion prevent Netflix employees from contributing rules back? Have you written custom rules that you haven't submitted back, and just don't want to see the hassle of messing with Subversion? Full disclosure: I'm the guy that doesn't see the benefit of Git for CodeNarc. I wrote up the process of pull, code, commit, pull request/patch for both Subversion and GitHub. Both processes had roughly the same number of bullet points and took roughly the same time. From a contributors viewpoint, I don't see any improvement. GitHub: * Fork * Git Pull * Write Code * Commit and Push * Pull request and type up a nice message Subversion * svn co https://sourceforge.subversion.com/codenarc/trunk * Write Code * svn diff > my_patch.patch * Attach patch to ticket or email me the patch And that assumes the contributor already has a GitHub account and has already navigated the steps to create keys and get an account. I *do* see a benefit of GitHub. There is a "social coding" aspect to it where developers can easily get recognition and kudos for the work they do. Much more so than just getting your name in our release notes :) If anyone feels motivated to do the work and make the switch then I guess we should go for it. It will have some benefit. Based on my analysis, I am personally not motivated to do this work. I feel like the migration would take about 4 hours of my time. Writing 2 new analysis rules would also take about 4 hours. I'm just talking about me personally, but I'm going to spend time on rules for the time being because it offers a better return on investment. As for Gradle... I see good benefits, like being able to run the tests against Groovy 1.8 and Groovy 2.0, automating our release more, and rolling the create-rule script into a Gradle task. Plus, the Gradle Wrapper is great. What holds us back is the Site stuff. What I would do in a Gradle conversion is forget about the Site plugin. I'd just take all of our HTML and check it into VCS. The only part that changes is the rule descriptions that get updated with every rule. You could just change the create-rule script to update an HTML page instead of a wiki markup page and be done. And finally... thanks for caring about CodeNarc. It's a special project for me and it means a lot to hear some voices from people who care. -- Hamlet D'Arcy ham...@ca... ----- Original Message ----- > +1 on prioritizing the Git/Github move. I know that keeps us from > doing more with CodeNarc at Netflix. Github is probably the single > best thing you can do with your project to get more developer use and > contributions. I don't see a move to Gradle buying you as much, seems > like a lateral change. > > On Wed, Jul 25, 2012 at 5:42 AM, Marcin Erdmann > <mar...@pr...> wrote: > > Chris, > > > > I believe migrating to git is more essential when it comes to > > getting people > > to contribute more easily to the project but I also understand your > > reservations towards it and understand that you see it as a big > > step > > especially as the project owner you need to be confident about the > > vcs > > you're using. > > > > Yes, I'm still up to helping out with the gradle migration of > > course. I will > > have a go at it during the weekend. I have some questions though. > > What do we > > exactly need to port? It's of course building and running the > > tests, > > deploying to Codehaus maven repo (we're doing it in geb, so I will > > probably > > have a look at how it's done there) and generating (also > > uploading?) the > > site. Is there anything else? I'm not a maven specialist so can you > > please > > list all of the commands you're using in your workflow to achieve > > the > > aforementioned tasks? What version of maven/other setup I need to > > run all of > > the tasks? > > > > I still haven't received any response from Rene about the site > > plugin but I > > will try to use it anyway and get it to a working state if > > necessary. > > > > Thanks, > > Marcin > > > > > > On Wed, Jul 25, 2012 at 3:03 AM, Chris Mair > > <chr...@ea...> wrote: > >> > >> Marcin, > >> > >> I was expecting/hoping that we could treat these as two separate > >> issues. > >> I'm > >> not sure that I am up for trying to tackle both at the same time. > >> At some > >> point, I need to do some analysis to figure out the impacts of a > >> migration > >> from Sourceforge+SVN to GitHub+Git. > >> > >> I am probably more eager to do the Gradle migration, assuming that > >> it now > >> supports the features that we need. I am also interested in > >> getting more > >> experience with Git, but I expect that will be more disruptive. > >> > >> Is doing one without the other (let's say doing Gradle), still > >> feasible, > >> and > >> still something you'd want to help with? > >> > >> Thanks. > >> Chris > >> -----Original Message----- > >> From: Marcin Erdmann [mailto:mar...@pr...] > >> Sent: Saturday, July 21, 2012 11:30 AM > >> To: Chris Mair > >> Cc: cod...@li... > >> Subject: Re: [Codenarc-developer] My views on making it easier for > >> people > >> to > >> contribute > >> > >> Chris, > >> > >> I'm glad to hear that you like my ideas. Here are the two feature > >> requests > >> on Sourceforge tracker: > >> > >> https://sourceforge.net/tracker/?func=detail <https://sourceforge.net/tracker/?func=detail&aid=3546737&group_id=250145&at i> &aid=3546737&group_id=250145&ati > >> d=1126575 > >> > >> https://sourceforge.net/tracker/?func=detail <https://sourceforge.net/tracker/?func=detail&aid=3546740&group_id=250145&at i> &aid=3546740&group_id=250145&ati > >> d=1126575 > >> > >> When it comes to the site plugin I'm currently waiting for a > >> response from > >> Rene Gröschke on the status of the plugin > >> (https://github.com/breskeby/GradleSite). After having a quick > >> peek at it > >> I > >> believe it is finished. It's not in central but I could put it > >> there cause > >> I > >> have rights to 'org.gradle.api.plugins' group in Sonatype OSS > >> repo. > >> > >> I can start working on the build migration as soon as we'll put > >> the code > >> into github - I will create a fork of it and submit a pull request > >> when > >> it's > >> ready. I can also help in migrating the source to github, I've > >> migrated > >> some > >> repos in the past from svn to github using git-svn and could pull > >> the > >> source > >> into the new repo given that I will get commit access to > >> CodeNarc's github > >> repository - I won't mind if you revoke it after the migration is > >> done. > >> > >> Cheers, > >> Marcin > >> > >> On 07/21/2012 02:35 PM, Chris Mair wrote: > >> > Marcin, > >> > > >> > Thank you for the feedback (and the CodeNarc contributions). > >> > > >> > I am open to both ideas. Can you please open a feature request > >> > for > >> > each suggestion (Git/Github and Gradle): > >> > https://sourceforge.net/tracker/?group_id=250145 <https://sourceforge.net/tracker/?group_id=250145&atid=1126575> &atid=1126575. > >> > > >> > Both have been informally suggested before, so it's probably > >> > worth > >> > getting them to a place where we can consolidate the discussion > >> > of the > >> > merits and trade-offs, and bring Hamlet into the discussion as > >> > well. > >> > One of the sticking points with Gradle previously was the lack > >> > of a > >> > site plugin, since we currently use Maven to generate the > >> > CodeNarc web > >> > site from APT files, and also generate the APT for the Rules > >> > Index > >> > page. I have not checked on the status of that lately. > >> > > >> > Thanks. > >> > Chris > >> > > >> > -----Original Message----- > >> > From: Marcin Erdmann [mailto:mar...@pr...] > >> > Sent: Thursday, July 19, 2012 7:34 PM > >> > To: cod...@li... > >> > Subject: [Codenarc-developer] My views on making it easier for > >> > people > >> > to contribute > >> > > >> > Hi all, > >> > > >> > In the past I've contributed several rules and fixes to > >> > Codenarc. > >> > Recently we've added Codenarc to our project and we found a > >> > major bug > >> > in UnnecessarySemicolonRule and wanted to fix it. After checking > >> > the > >> > project state I've found out that it's still quite tedious to > >> > contribute for two reasons - svn and maven. > >> > > >> > If you want to contribute to Codenarc you need to send patches > >> > in > >> > email, like I did by sending mails to Hamlet in the past. This > >> > would > >> > be much easier if the project was on github enabling people to > >> > submit > >> > pull request... I don't know if there is a CI build set up for > >> > the > >> > project but by putting it on github and hooking it up with > >> > buildhive > >> > you get CI builds for free, also for pull requests. Can you > >> > please > >> > explain what are the reasons for such a valuable project to be > >> > still > >> > using > >> svn? > >> > > >> > The other thing is getting the project into your IDE. It would > >> > be so > >> > much easier if there was a gradle build available for the > >> > project - > >> > simply typing gradle idea would generate the project for you > >> > with all > >> > the dependencies in place and no additional settings/tweaks > >> > needed. If > >> > you're interested I could try to contribute by migrating current > >> > maven > >> > build to gradle. I'm already in talks with Rene Gröschke about > >> > his > >> > efforts > >> in the past in that area. > >> > > >> > Cheers, > >> > Marcin Erdmann > >> > > >> > ---------------------------------------------------------------------- > >> > ------ > >> > -- > >> > Live Security Virtual Conference > >> > Exclusive live event will cover all the ways today's security > >> > and > >> > threat landscape has changed and how IT managers can respond. > >> > Discussions will include endpoint security, mobile security and > >> > the > >> > latest in malware threats. > >> > http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > >> > _______________________________________________ > >> > Codenarc-developer mailing list > >> > Cod...@li... > >> > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > >> > > >> > > >> > > > > > > ---------------------------------------------------------------------------- -- > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. > > Discussions > > will include endpoint security, mobile security and the latest in > > malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > Codenarc-developer mailing list > > Cod...@li... > > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > > > > ---------------------------------------------------------------------------- -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. > Discussions > will include endpoint security, mobile security and the latest in > malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Codenarc-developer mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > |
From: Marcin E. <mar...@pr...> - 2012-07-29 10:41:47
|
Chris, That's great news! As promised I will perform the migration as soon as I will receive rights to push to codenarc github repo. My username on github is erdi. 1) Creating an organisation and a repo both called codenarc is the way to go in my opinion. I was also thinking about the fact that the artifactId for the project is 'CodeNarc' not 'codenarc' but it's up to you which case style you'll choose for the organisation and repo, but as I said, same organisation and repo name is the way to go. 2) I don't believe that it's necessary to migrate everything to github. It's the git repository hosting that we are going there for, so leaving everything else in Sourceforge as it is ok for me and it's definitely less work. I would only put links to the repository on github and tracker on Sourceforge in the 'General' links section on the project website and that's it. In my opinion anything more than that is simple not worth it. Marcin On 07/28/2012 03:33 PM, Chris Mair wrote: > > Marcin, > > Thank you very much for your offers to help, explanations and > patience. We'd like to take you up on your generous offer to perform > the CodeNarc GitHub migration. > > Much of this is new to me, so I ask your continued patience. > > (1) I plan to create a GitHub organization called "*codenarc*" and > then a repo called "*codenarc*". Is that appropriate? > > (2) Is the expectation that we will completely abandon the existing > Sourceforge hosting? I assume so. That means we use GitHub for web > site hosting, bug tracking, feature requests, etc.. So, what should > happen to the existing tracker issues (a few hundred, including 125 > open feature requests)? > > Thanks. > > Chris > > *From:*Marcin Erdmann [mailto:mar...@pr...] > *Sent:* Thursday, July 26, 2012 8:14 AM > *To:* cod...@li... > *Subject:* Re: [Codenarc-developer] My views on making it easier for > people to contribute > > Hamlet, > > I believe that there actually is a lot of benefit in migrating to > github. >From a contributor point of view I can tell that the step > where you have to send email with the patch is a PITA. Apart from it > being an outdated technique you also have to know who to send the > email to. I knew that I can send it to you but others might struggle > to find appropriate addresses and I can't easily find any info on > where and how to send contributions on the project site. > > There are several other benefits I can see apart from the social one > you mentioned: > > - anyone who has ever contributed to an open source project will > probably have their github stuff set up, because most of the projects > are hosted on github and will know how to create a pull request > > - people don't have to wonder how to contribute - they will know that > they should simply fork the repo and submit a pull request > > - with git being a distributed vcs you get the possibility to do local > commits and back them up on github in your own fork, which means you > can work on the patch on any machine (this gets even easier if we had > a gradle build with a wrapper because setting up a project is just a > matter of calling 'gradlew idea') > > - you have one central place when you can comment on people's > contributions and it's easier for other developers from Codenarc team > to get involved in the discussion > > - people can change their pull requests by adding your suggestions to > it by just pushing to the branch pull request is based on in their fork > > As I said, I volunteer to perform the migration - someone has to > simply create an organisation and a repo on github and give my access > to it for the time of the migration. I will use git-svn, so the whole > history, branches and tags will still be there. And I definitely don't > believe it's going to take 4 hours. :) > > I think that we should try to get the site plugin from gradle > integrated into to the build as well. It's there to be used and why > should you change the way you generate your documentation and do it > manually if you don't have to? Let's try to do a full migration and > worry later if there actually are any problems. > > Glad to read that you see my good intentions in my suggestions. And > I'm not here to just whine about stuff - I'm eager to help. It's just > you that have to decide if you want to accept my help. > > Marcin > > On Thu, Jul 26, 2012 at 12:13 PM, Hamlet DArcy <ham...@ca... > <mailto:ham...@ca...>> wrote: > > How does Subversion prevent Netflix employees from contributing rules > back? > Have you written custom rules that you haven't submitted back, and > just don't want to see the hassle of messing with Subversion? > > Full disclosure: I'm the guy that doesn't see the benefit of Git for > CodeNarc. I wrote up the process of pull, code, commit, pull > request/patch for both Subversion and GitHub. Both processes had > roughly the same number of bullet points and took roughly the same > time. From a contributors viewpoint, I don't see any improvement. > > GitHub: > * Fork > * Git Pull > * Write Code > * Commit and Push > * Pull request and type up a nice message > > Subversion > * svn co https://sourceforge.subversion.com/codenarc/trunk > * Write Code > * svn diff > my_patch.patch > * Attach patch to ticket or email me the patch > > And that assumes the contributor already has a GitHub account and has > already navigated the steps to create keys and get an account. > > I *do* see a benefit of GitHub. There is a "social coding" aspect to > it where developers can easily get recognition and kudos for the work > they do. Much more so than just getting your name in our release notes :) > > If anyone feels motivated to do the work and make the switch then I > guess we should go for it. It will have some benefit. Based on my > analysis, I am personally not motivated to do this work. I feel like > the migration would take about 4 hours of my time. Writing 2 new > analysis rules would also take about 4 hours. I'm just talking about > me personally, but I'm going to spend time on rules for the time being > because it offers a better return on investment. > > As for Gradle... I see good benefits, like being able to run the tests > against Groovy 1.8 and Groovy 2.0, automating our release more, and > rolling the create-rule script into a Gradle task. Plus, the Gradle > Wrapper is great. What holds us back is the Site stuff. What I would > do in a Gradle conversion is forget about the Site plugin. I'd just > take all of our HTML and check it into VCS. The only part that changes > is the rule descriptions that get updated with every rule. You could > just change the create-rule script to update an HTML page instead of a > wiki markup page and be done. > > And finally... thanks for caring about CodeNarc. It's a special > project for me and it means a lot to hear some voices from people who > care. > > -- > Hamlet D'Arcy > ham...@ca... <mailto:ham...@ca...> > > > ----- Original Message ----- > > +1 on prioritizing the Git/Github move. I know that keeps us from > > doing more with CodeNarc at Netflix. Github is probably the single > > best thing you can do with your project to get more developer use and > > contributions. I don't see a move to Gradle buying you as much, seems > > like a lateral change. > > > > On Wed, Jul 25, 2012 at 5:42 AM, Marcin Erdmann > > <mar...@pr... <mailto:mar...@pr...>> wrote: > > > Chris, > > > > > > I believe migrating to git is more essential when it comes to > > > getting people > > > to contribute more easily to the project but I also understand your > > > reservations towards it and understand that you see it as a big > > > step > > > especially as the project owner you need to be confident about the > > > vcs > > > you're using. > > > > > > Yes, I'm still up to helping out with the gradle migration of > > > course. I will > > > have a go at it during the weekend. I have some questions though. > > > What do we > > > exactly need to port? It's of course building and running the > > > tests, > > > deploying to Codehaus maven repo (we're doing it in geb, so I will > > > probably > > > have a look at how it's done there) and generating (also > > > uploading?) the > > > site. Is there anything else? I'm not a maven specialist so can you > > > please > > > list all of the commands you're using in your workflow to achieve > > > the > > > aforementioned tasks? What version of maven/other setup I need to > > > run all of > > > the tasks? > > > > > > I still haven't received any response from Rene about the site > > > plugin but I > > > will try to use it anyway and get it to a working state if > > > necessary. > > > > > > Thanks, > > > Marcin > > > > > > > > > On Wed, Jul 25, 2012 at 3:03 AM, Chris Mair > > > <chr...@ea... <mailto:chr...@ea...>> wrote: > > >> > > >> Marcin, > > >> > > >> I was expecting/hoping that we could treat these as two separate > > >> issues. > > >> I'm > > >> not sure that I am up for trying to tackle both at the same time. > > >> At some > > >> point, I need to do some analysis to figure out the impacts of a > > >> migration > > >> from Sourceforge+SVN to GitHub+Git. > > >> > > >> I am probably more eager to do the Gradle migration, assuming that > > >> it now > > >> supports the features that we need. I am also interested in > > >> getting more > > >> experience with Git, but I expect that will be more disruptive. > > >> > > >> Is doing one without the other (let's say doing Gradle), still > > >> feasible, > > >> and > > >> still something you'd want to help with? > > >> > > >> Thanks. > > >> Chris > > >> -----Original Message----- > > >> From: Marcin Erdmann [mailto:mar...@pr... > <mailto:mar...@pr...>] > > >> Sent: Saturday, July 21, 2012 11:30 AM > > >> To: Chris Mair > > >> Cc: cod...@li... > <mailto:cod...@li...> > > >> Subject: Re: [Codenarc-developer] My views on making it easier for > > >> people > > >> to > > >> contribute > > >> > > >> Chris, > > >> > > >> I'm glad to hear that you like my ideas. Here are the two feature > > >> requests > > >> on Sourceforge tracker: > > >> > > >> > https://sourceforge.net/tracker/?func=detail&aid=3546737&group_id=250145&ati > > >> d=1126575 > > >> > > >> > https://sourceforge.net/tracker/?func=detail&aid=3546740&group_id=250145&ati > > >> d=1126575 > > >> > > >> When it comes to the site plugin I'm currently waiting for a > > >> response from > > >> Rene Gröschke on the status of the plugin > > >> (https://github.com/breskeby/GradleSite). After having a quick > > >> peek at it > > >> I > > >> believe it is finished. It's not in central but I could put it > > >> there cause > > >> I > > >> have rights to 'org.gradle.api.plugins' group in Sonatype OSS > > >> repo. > > >> > > >> I can start working on the build migration as soon as we'll put > > >> the code > > >> into github - I will create a fork of it and submit a pull request > > >> when > > >> it's > > >> ready. I can also help in migrating the source to github, I've > > >> migrated > > >> some > > >> repos in the past from svn to github using git-svn and could pull > > >> the > > >> source > > >> into the new repo given that I will get commit access to > > >> CodeNarc's github > > >> repository - I won't mind if you revoke it after the migration is > > >> done. > > >> > > >> Cheers, > > >> Marcin > > >> > > >> On 07/21/2012 02:35 PM, Chris Mair wrote: > > >> > Marcin, > > >> > > > >> > Thank you for the feedback (and the CodeNarc contributions). > > >> > > > >> > I am open to both ideas. Can you please open a feature request > > >> > for > > >> > each suggestion (Git/Github and Gradle): > > >> > https://sourceforge.net/tracker/?group_id=250145&atid=1126575. > > >> > > > >> > Both have been informally suggested before, so it's probably > > >> > worth > > >> > getting them to a place where we can consolidate the discussion > > >> > of the > > >> > merits and trade-offs, and bring Hamlet into the discussion as > > >> > well. > > >> > One of the sticking points with Gradle previously was the lack > > >> > of a > > >> > site plugin, since we currently use Maven to generate the > > >> > CodeNarc web > > >> > site from APT files, and also generate the APT for the Rules > > >> > Index > > >> > page. I have not checked on the status of that lately. > > >> > > > >> > Thanks. > > >> > Chris > > >> > > > >> > -----Original Message----- > > >> > From: Marcin Erdmann [mailto:mar...@pr... > <mailto:mar...@pr...>] > > >> > Sent: Thursday, July 19, 2012 7:34 PM > > >> > To: cod...@li... > <mailto:cod...@li...> > > >> > Subject: [Codenarc-developer] My views on making it easier for > > >> > people > > >> > to contribute > > >> > > > >> > Hi all, > > >> > > > >> > In the past I've contributed several rules and fixes to > > >> > Codenarc. > > >> > Recently we've added Codenarc to our project and we found a > > >> > major bug > > >> > in UnnecessarySemicolonRule and wanted to fix it. After checking > > >> > the > > >> > project state I've found out that it's still quite tedious to > > >> > contribute for two reasons - svn and maven. > > >> > > > >> > If you want to contribute to Codenarc you need to send patches > > >> > in > > >> > email, like I did by sending mails to Hamlet in the past. This > > >> > would > > >> > be much easier if the project was on github enabling people to > > >> > submit > > >> > pull request... I don't know if there is a CI build set up for > > >> > the > > >> > project but by putting it on github and hooking it up with > > >> > buildhive > > >> > you get CI builds for free, also for pull requests. Can you > > >> > please > > >> > explain what are the reasons for such a valuable project to be > > >> > still > > >> > using > > >> svn? > > >> > > > >> > The other thing is getting the project into your IDE. It would > > >> > be so > > >> > much easier if there was a gradle build available for the > > >> > project - > > >> > simply typing gradle idea would generate the project for you > > >> > with all > > >> > the dependencies in place and no additional settings/tweaks > > >> > needed. If > > >> > you're interested I could try to contribute by migrating current > > >> > maven > > >> > build to gradle. I'm already in talks with Rene Gröschke about > > >> > his > > >> > efforts > > >> in the past in that area. > > >> > > > >> > Cheers, > > >> > Marcin Erdmann > > >> > > > >> > > ---------------------------------------------------------------------- > > >> > ------ > > >> > -- > > >> > Live Security Virtual Conference > > >> > Exclusive live event will cover all the ways today's security > > >> > and > > >> > threat landscape has changed and how IT managers can respond. > > >> > Discussions will include endpoint security, mobile security and > > >> > the > > >> > latest in malware threats. > > >> > http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > >> > _______________________________________________ > > >> > Codenarc-developer mailing list > > >> > Cod...@li... > <mailto:Cod...@li...> > > >> > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > > >> > > > >> > > > >> > > > > > > > > > > ------------------------------------------------------------------------------ > > > Live Security Virtual Conference > > > Exclusive live event will cover all the ways today's security and > > > threat landscape has changed and how IT managers can respond. > > > Discussions > > > will include endpoint security, mobile security and the latest in > > > malware > > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > > _______________________________________________ > > > Codenarc-developer mailing list > > > Cod...@li... > <mailto:Cod...@li...> > > > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > > > > > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. > > Discussions > > will include endpoint security, mobile security and the latest in > > malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > Codenarc-developer mailing list > > Cod...@li... > <mailto:Cod...@li...> > > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > > > |
From: Chris M. <chr...@ea...> - 2012-07-28 14:33:25
|
Marcin, Thank you very much for your offers to help, explanations and patience. Wed like to take you up on your generous offer to perform the CodeNarc GitHub migration. Much of this is new to me, so I ask your continued patience. (1) I plan to create a GitHub organization called codenarc and then a repo called codenarc. Is that appropriate? (2) Is the expectation that we will completely abandon the existing Sourceforge hosting? I assume so. That means we use GitHub for web site hosting, bug tracking, feature requests, etc.. So, what should happen to the existing tracker issues (a few hundred, including 125 open feature requests)? Thanks. Chris From: Marcin Erdmann [mailto:mar...@pr...] Sent: Thursday, July 26, 2012 8:14 AM To: cod...@li... Subject: Re: [Codenarc-developer] My views on making it easier for people to contribute Hamlet, I believe that there actually is a lot of benefit in migrating to github. >From a contributor point of view I can tell that the step where you have to send email with the patch is a PITA. Apart from it being an outdated technique you also have to know who to send the email to. I knew that I can send it to you but others might struggle to find appropriate addresses and I can't easily find any info on where and how to send contributions on the project site. There are several other benefits I can see apart from the social one you mentioned: - anyone who has ever contributed to an open source project will probably have their github stuff set up, because most of the projects are hosted on github and will know how to create a pull request - people don't have to wonder how to contribute - they will know that they should simply fork the repo and submit a pull request - with git being a distributed vcs you get the possibility to do local commits and back them up on github in your own fork, which means you can work on the patch on any machine (this gets even easier if we had a gradle build with a wrapper because setting up a project is just a matter of calling 'gradlew idea') - you have one central place when you can comment on people's contributions and it's easier for other developers from Codenarc team to get involved in the discussion - people can change their pull requests by adding your suggestions to it by just pushing to the branch pull request is based on in their fork As I said, I volunteer to perform the migration - someone has to simply create an organisation and a repo on github and give my access to it for the time of the migration. I will use git-svn, so the whole history, branches and tags will still be there. And I definitely don't believe it's going to take 4 hours. :) I think that we should try to get the site plugin from gradle integrated into to the build as well. It's there to be used and why should you change the way you generate your documentation and do it manually if you don't have to? Let's try to do a full migration and worry later if there actually are any problems. Glad to read that you see my good intentions in my suggestions. And I'm not here to just whine about stuff - I'm eager to help. It's just you that have to decide if you want to accept my help. Marcin On Thu, Jul 26, 2012 at 12:13 PM, Hamlet DArcy <ham...@ca...> wrote: How does Subversion prevent Netflix employees from contributing rules back? Have you written custom rules that you haven't submitted back, and just don't want to see the hassle of messing with Subversion? Full disclosure: I'm the guy that doesn't see the benefit of Git for CodeNarc. I wrote up the process of pull, code, commit, pull request/patch for both Subversion and GitHub. Both processes had roughly the same number of bullet points and took roughly the same time. From a contributors viewpoint, I don't see any improvement. GitHub: * Fork * Git Pull * Write Code * Commit and Push * Pull request and type up a nice message Subversion * svn co https://sourceforge.subversion.com/codenarc/trunk * Write Code * svn diff > my_patch.patch * Attach patch to ticket or email me the patch And that assumes the contributor already has a GitHub account and has already navigated the steps to create keys and get an account. I *do* see a benefit of GitHub. There is a "social coding" aspect to it where developers can easily get recognition and kudos for the work they do. Much more so than just getting your name in our release notes :) If anyone feels motivated to do the work and make the switch then I guess we should go for it. It will have some benefit. Based on my analysis, I am personally not motivated to do this work. I feel like the migration would take about 4 hours of my time. Writing 2 new analysis rules would also take about 4 hours. I'm just talking about me personally, but I'm going to spend time on rules for the time being because it offers a better return on investment. As for Gradle... I see good benefits, like being able to run the tests against Groovy 1.8 and Groovy 2.0, automating our release more, and rolling the create-rule script into a Gradle task. Plus, the Gradle Wrapper is great. What holds us back is the Site stuff. What I would do in a Gradle conversion is forget about the Site plugin. I'd just take all of our HTML and check it into VCS. The only part that changes is the rule descriptions that get updated with every rule. You could just change the create-rule script to update an HTML page instead of a wiki markup page and be done. And finally... thanks for caring about CodeNarc. It's a special project for me and it means a lot to hear some voices from people who care. -- Hamlet D'Arcy ham...@ca... ----- Original Message ----- > +1 on prioritizing the Git/Github move. I know that keeps us from > doing more with CodeNarc at Netflix. Github is probably the single > best thing you can do with your project to get more developer use and > contributions. I don't see a move to Gradle buying you as much, seems > like a lateral change. > > On Wed, Jul 25, 2012 at 5:42 AM, Marcin Erdmann > <mar...@pr...> wrote: > > Chris, > > > > I believe migrating to git is more essential when it comes to > > getting people > > to contribute more easily to the project but I also understand your > > reservations towards it and understand that you see it as a big > > step > > especially as the project owner you need to be confident about the > > vcs > > you're using. > > > > Yes, I'm still up to helping out with the gradle migration of > > course. I will > > have a go at it during the weekend. I have some questions though. > > What do we > > exactly need to port? It's of course building and running the > > tests, > > deploying to Codehaus maven repo (we're doing it in geb, so I will > > probably > > have a look at how it's done there) and generating (also > > uploading?) the > > site. Is there anything else? I'm not a maven specialist so can you > > please > > list all of the commands you're using in your workflow to achieve > > the > > aforementioned tasks? What version of maven/other setup I need to > > run all of > > the tasks? > > > > I still haven't received any response from Rene about the site > > plugin but I > > will try to use it anyway and get it to a working state if > > necessary. > > > > Thanks, > > Marcin > > > > > > On Wed, Jul 25, 2012 at 3:03 AM, Chris Mair > > <chr...@ea...> wrote: > >> > >> Marcin, > >> > >> I was expecting/hoping that we could treat these as two separate > >> issues. > >> I'm > >> not sure that I am up for trying to tackle both at the same time. > >> At some > >> point, I need to do some analysis to figure out the impacts of a > >> migration > >> from Sourceforge+SVN to GitHub+Git. > >> > >> I am probably more eager to do the Gradle migration, assuming that > >> it now > >> supports the features that we need. I am also interested in > >> getting more > >> experience with Git, but I expect that will be more disruptive. > >> > >> Is doing one without the other (let's say doing Gradle), still > >> feasible, > >> and > >> still something you'd want to help with? > >> > >> Thanks. > >> Chris > >> -----Original Message----- > >> From: Marcin Erdmann [mailto:mar...@pr...] > >> Sent: Saturday, July 21, 2012 11:30 AM > >> To: Chris Mair > >> Cc: cod...@li... > >> Subject: Re: [Codenarc-developer] My views on making it easier for > >> people > >> to > >> contribute > >> > >> Chris, > >> > >> I'm glad to hear that you like my ideas. Here are the two feature > >> requests > >> on Sourceforge tracker: > >> > >> https://sourceforge.net/tracker/?func=detail <https://sourceforge.net/tracker/?func=detail&aid=3546737&group_id=250145&at i> &aid=3546737&group_id=250145&ati > >> d=1126575 > >> > >> https://sourceforge.net/tracker/?func=detail <https://sourceforge.net/tracker/?func=detail&aid=3546740&group_id=250145&at i> &aid=3546740&group_id=250145&ati > >> d=1126575 > >> > >> When it comes to the site plugin I'm currently waiting for a > >> response from > >> Rene Gröschke on the status of the plugin > >> (https://github.com/breskeby/GradleSite). After having a quick > >> peek at it > >> I > >> believe it is finished. It's not in central but I could put it > >> there cause > >> I > >> have rights to 'org.gradle.api.plugins' group in Sonatype OSS > >> repo. > >> > >> I can start working on the build migration as soon as we'll put > >> the code > >> into github - I will create a fork of it and submit a pull request > >> when > >> it's > >> ready. I can also help in migrating the source to github, I've > >> migrated > >> some > >> repos in the past from svn to github using git-svn and could pull > >> the > >> source > >> into the new repo given that I will get commit access to > >> CodeNarc's github > >> repository - I won't mind if you revoke it after the migration is > >> done. > >> > >> Cheers, > >> Marcin > >> > >> On 07/21/2012 02:35 PM, Chris Mair wrote: > >> > Marcin, > >> > > >> > Thank you for the feedback (and the CodeNarc contributions). > >> > > >> > I am open to both ideas. Can you please open a feature request > >> > for > >> > each suggestion (Git/Github and Gradle): > >> > https://sourceforge.net/tracker/?group_id=250145 <https://sourceforge.net/tracker/?group_id=250145&atid=1126575> &atid=1126575. > >> > > >> > Both have been informally suggested before, so it's probably > >> > worth > >> > getting them to a place where we can consolidate the discussion > >> > of the > >> > merits and trade-offs, and bring Hamlet into the discussion as > >> > well. > >> > One of the sticking points with Gradle previously was the lack > >> > of a > >> > site plugin, since we currently use Maven to generate the > >> > CodeNarc web > >> > site from APT files, and also generate the APT for the Rules > >> > Index > >> > page. I have not checked on the status of that lately. > >> > > >> > Thanks. > >> > Chris > >> > > >> > -----Original Message----- > >> > From: Marcin Erdmann [mailto:mar...@pr...] > >> > Sent: Thursday, July 19, 2012 7:34 PM > >> > To: cod...@li... > >> > Subject: [Codenarc-developer] My views on making it easier for > >> > people > >> > to contribute > >> > > >> > Hi all, > >> > > >> > In the past I've contributed several rules and fixes to > >> > Codenarc. > >> > Recently we've added Codenarc to our project and we found a > >> > major bug > >> > in UnnecessarySemicolonRule and wanted to fix it. After checking > >> > the > >> > project state I've found out that it's still quite tedious to > >> > contribute for two reasons - svn and maven. > >> > > >> > If you want to contribute to Codenarc you need to send patches > >> > in > >> > email, like I did by sending mails to Hamlet in the past. This > >> > would > >> > be much easier if the project was on github enabling people to > >> > submit > >> > pull request... I don't know if there is a CI build set up for > >> > the > >> > project but by putting it on github and hooking it up with > >> > buildhive > >> > you get CI builds for free, also for pull requests. Can you > >> > please > >> > explain what are the reasons for such a valuable project to be > >> > still > >> > using > >> svn? > >> > > >> > The other thing is getting the project into your IDE. It would > >> > be so > >> > much easier if there was a gradle build available for the > >> > project - > >> > simply typing gradle idea would generate the project for you > >> > with all > >> > the dependencies in place and no additional settings/tweaks > >> > needed. If > >> > you're interested I could try to contribute by migrating current > >> > maven > >> > build to gradle. I'm already in talks with Rene Gröschke about > >> > his > >> > efforts > >> in the past in that area. > >> > > >> > Cheers, > >> > Marcin Erdmann > >> > > >> > ---------------------------------------------------------------------- > >> > ------ > >> > -- > >> > Live Security Virtual Conference > >> > Exclusive live event will cover all the ways today's security > >> > and > >> > threat landscape has changed and how IT managers can respond. > >> > Discussions will include endpoint security, mobile security and > >> > the > >> > latest in malware threats. > >> > http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > >> > _______________________________________________ > >> > Codenarc-developer mailing list > >> > Cod...@li... > >> > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > >> > > >> > > >> > > > > > > ---------------------------------------------------------------------------- -- > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. > > Discussions > > will include endpoint security, mobile security and the latest in > > malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > Codenarc-developer mailing list > > Cod...@li... > > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > > > > ---------------------------------------------------------------------------- -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. > Discussions > will include endpoint security, mobile security and the latest in > malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Codenarc-developer mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > |
From: Marcin E. <mar...@pr...> - 2012-07-26 12:14:16
|
Hamlet, I believe that there actually is a lot of benefit in migrating to github. >From a contributor point of view I can tell that the step where you have to send email with the patch is a PITA. Apart from it being an outdated technique you also have to know who to send the email to. I knew that I can send it to you but others might struggle to find appropriate addresses and I can't easily find any info on where and how to send contributions on the project site. There are several other benefits I can see apart from the social one you mentioned: - anyone who has ever contributed to an open source project will probably have their github stuff set up, because most of the projects are hosted on github and will know how to create a pull request - people don't have to wonder how to contribute - they will know that they should simply fork the repo and submit a pull request - with git being a distributed vcs you get the possibility to do local commits and back them up on github in your own fork, which means you can work on the patch on any machine (this gets even easier if we had a gradle build with a wrapper because setting up a project is just a matter of calling 'gradlew idea') - you have one central place when you can comment on people's contributions and it's easier for other developers from Codenarc team to get involved in the discussion - people can change their pull requests by adding your suggestions to it by just pushing to the branch pull request is based on in their fork As I said, I volunteer to perform the migration - someone has to simply create an organisation and a repo on github and give my access to it for the time of the migration. I will use git-svn, so the whole history, branches and tags will still be there. And I definitely don't believe it's going to take 4 hours. :) I think that we should try to get the site plugin from gradle integrated into to the build as well. It's there to be used and why should you change the way you generate your documentation and do it manually if you don't have to? Let's try to do a full migration and worry later if there actually are any problems. Glad to read that you see my good intentions in my suggestions. And I'm not here to just whine about stuff - I'm eager to help. It's just you that have to decide if you want to accept my help. Marcin On Thu, Jul 26, 2012 at 12:13 PM, Hamlet DArcy <ham...@ca...>wrote: > How does Subversion prevent Netflix employees from contributing rules back? > Have you written custom rules that you haven't submitted back, and just > don't want to see the hassle of messing with Subversion? > > Full disclosure: I'm the guy that doesn't see the benefit of Git for > CodeNarc. I wrote up the process of pull, code, commit, pull request/patch > for both Subversion and GitHub. Both processes had roughly the same number > of bullet points and took roughly the same time. From a contributors > viewpoint, I don't see any improvement. > > GitHub: > * Fork > * Git Pull > * Write Code > * Commit and Push > * Pull request and type up a nice message > > Subversion > * svn co https://sourceforge.subversion.com/codenarc/trunk > * Write Code > * svn diff > my_patch.patch > * Attach patch to ticket or email me the patch > > And that assumes the contributor already has a GitHub account and has > already navigated the steps to create keys and get an account. > > I *do* see a benefit of GitHub. There is a "social coding" aspect to it > where developers can easily get recognition and kudos for the work they do. > Much more so than just getting your name in our release notes :) > > If anyone feels motivated to do the work and make the switch then I guess > we should go for it. It will have some benefit. Based on my analysis, I am > personally not motivated to do this work. I feel like the migration would > take about 4 hours of my time. Writing 2 new analysis rules would also take > about 4 hours. I'm just talking about me personally, but I'm going to spend > time on rules for the time being because it offers a better return on > investment. > > As for Gradle... I see good benefits, like being able to run the tests > against Groovy 1.8 and Groovy 2.0, automating our release more, and rolling > the create-rule script into a Gradle task. Plus, the Gradle Wrapper is > great. What holds us back is the Site stuff. What I would do in a Gradle > conversion is forget about the Site plugin. I'd just take all of our HTML > and check it into VCS. The only part that changes is the rule descriptions > that get updated with every rule. You could just change the create-rule > script to update an HTML page instead of a wiki markup page and be done. > > And finally... thanks for caring about CodeNarc. It's a special project > for me and it means a lot to hear some voices from people who care. > > -- > Hamlet D'Arcy > ham...@ca... > > ----- Original Message ----- > > +1 on prioritizing the Git/Github move. I know that keeps us from > > doing more with CodeNarc at Netflix. Github is probably the single > > best thing you can do with your project to get more developer use and > > contributions. I don't see a move to Gradle buying you as much, seems > > like a lateral change. > > > > On Wed, Jul 25, 2012 at 5:42 AM, Marcin Erdmann > > <mar...@pr...> wrote: > > > Chris, > > > > > > I believe migrating to git is more essential when it comes to > > > getting people > > > to contribute more easily to the project but I also understand your > > > reservations towards it and understand that you see it as a big > > > step > > > especially as the project owner you need to be confident about the > > > vcs > > > you're using. > > > > > > Yes, I'm still up to helping out with the gradle migration of > > > course. I will > > > have a go at it during the weekend. I have some questions though. > > > What do we > > > exactly need to port? It's of course building and running the > > > tests, > > > deploying to Codehaus maven repo (we're doing it in geb, so I will > > > probably > > > have a look at how it's done there) and generating (also > > > uploading?) the > > > site. Is there anything else? I'm not a maven specialist so can you > > > please > > > list all of the commands you're using in your workflow to achieve > > > the > > > aforementioned tasks? What version of maven/other setup I need to > > > run all of > > > the tasks? > > > > > > I still haven't received any response from Rene about the site > > > plugin but I > > > will try to use it anyway and get it to a working state if > > > necessary. > > > > > > Thanks, > > > Marcin > > > > > > > > > On Wed, Jul 25, 2012 at 3:03 AM, Chris Mair > > > <chr...@ea...> wrote: > > >> > > >> Marcin, > > >> > > >> I was expecting/hoping that we could treat these as two separate > > >> issues. > > >> I'm > > >> not sure that I am up for trying to tackle both at the same time. > > >> At some > > >> point, I need to do some analysis to figure out the impacts of a > > >> migration > > >> from Sourceforge+SVN to GitHub+Git. > > >> > > >> I am probably more eager to do the Gradle migration, assuming that > > >> it now > > >> supports the features that we need. I am also interested in > > >> getting more > > >> experience with Git, but I expect that will be more disruptive. > > >> > > >> Is doing one without the other (let's say doing Gradle), still > > >> feasible, > > >> and > > >> still something you'd want to help with? > > >> > > >> Thanks. > > >> Chris > > >> -----Original Message----- > > >> From: Marcin Erdmann [mailto:mar...@pr...] > > >> Sent: Saturday, July 21, 2012 11:30 AM > > >> To: Chris Mair > > >> Cc: cod...@li... > > >> Subject: Re: [Codenarc-developer] My views on making it easier for > > >> people > > >> to > > >> contribute > > >> > > >> Chris, > > >> > > >> I'm glad to hear that you like my ideas. Here are the two feature > > >> requests > > >> on Sourceforge tracker: > > >> > > >> > https://sourceforge.net/tracker/?func=detail&aid=3546737&group_id=250145&ati > > >> d=1126575 > > >> > > >> > https://sourceforge.net/tracker/?func=detail&aid=3546740&group_id=250145&ati > > >> d=1126575 > > >> > > >> When it comes to the site plugin I'm currently waiting for a > > >> response from > > >> Rene Gröschke on the status of the plugin > > >> (https://github.com/breskeby/GradleSite). After having a quick > > >> peek at it > > >> I > > >> believe it is finished. It's not in central but I could put it > > >> there cause > > >> I > > >> have rights to 'org.gradle.api.plugins' group in Sonatype OSS > > >> repo. > > >> > > >> I can start working on the build migration as soon as we'll put > > >> the code > > >> into github - I will create a fork of it and submit a pull request > > >> when > > >> it's > > >> ready. I can also help in migrating the source to github, I've > > >> migrated > > >> some > > >> repos in the past from svn to github using git-svn and could pull > > >> the > > >> source > > >> into the new repo given that I will get commit access to > > >> CodeNarc's github > > >> repository - I won't mind if you revoke it after the migration is > > >> done. > > >> > > >> Cheers, > > >> Marcin > > >> > > >> On 07/21/2012 02:35 PM, Chris Mair wrote: > > >> > Marcin, > > >> > > > >> > Thank you for the feedback (and the CodeNarc contributions). > > >> > > > >> > I am open to both ideas. Can you please open a feature request > > >> > for > > >> > each suggestion (Git/Github and Gradle): > > >> > https://sourceforge.net/tracker/?group_id=250145&atid=1126575. > > >> > > > >> > Both have been informally suggested before, so it's probably > > >> > worth > > >> > getting them to a place where we can consolidate the discussion > > >> > of the > > >> > merits and trade-offs, and bring Hamlet into the discussion as > > >> > well. > > >> > One of the sticking points with Gradle previously was the lack > > >> > of a > > >> > site plugin, since we currently use Maven to generate the > > >> > CodeNarc web > > >> > site from APT files, and also generate the APT for the Rules > > >> > Index > > >> > page. I have not checked on the status of that lately. > > >> > > > >> > Thanks. > > >> > Chris > > >> > > > >> > -----Original Message----- > > >> > From: Marcin Erdmann [mailto:mar...@pr...] > > >> > Sent: Thursday, July 19, 2012 7:34 PM > > >> > To: cod...@li... > > >> > Subject: [Codenarc-developer] My views on making it easier for > > >> > people > > >> > to contribute > > >> > > > >> > Hi all, > > >> > > > >> > In the past I've contributed several rules and fixes to > > >> > Codenarc. > > >> > Recently we've added Codenarc to our project and we found a > > >> > major bug > > >> > in UnnecessarySemicolonRule and wanted to fix it. After checking > > >> > the > > >> > project state I've found out that it's still quite tedious to > > >> > contribute for two reasons - svn and maven. > > >> > > > >> > If you want to contribute to Codenarc you need to send patches > > >> > in > > >> > email, like I did by sending mails to Hamlet in the past. This > > >> > would > > >> > be much easier if the project was on github enabling people to > > >> > submit > > >> > pull request... I don't know if there is a CI build set up for > > >> > the > > >> > project but by putting it on github and hooking it up with > > >> > buildhive > > >> > you get CI builds for free, also for pull requests. Can you > > >> > please > > >> > explain what are the reasons for such a valuable project to be > > >> > still > > >> > using > > >> svn? > > >> > > > >> > The other thing is getting the project into your IDE. It would > > >> > be so > > >> > much easier if there was a gradle build available for the > > >> > project - > > >> > simply typing gradle idea would generate the project for you > > >> > with all > > >> > the dependencies in place and no additional settings/tweaks > > >> > needed. If > > >> > you're interested I could try to contribute by migrating current > > >> > maven > > >> > build to gradle. I'm already in talks with Rene Gröschke about > > >> > his > > >> > efforts > > >> in the past in that area. > > >> > > > >> > Cheers, > > >> > Marcin Erdmann > > >> > > > >> > > ---------------------------------------------------------------------- > > >> > ------ > > >> > -- > > >> > Live Security Virtual Conference > > >> > Exclusive live event will cover all the ways today's security > > >> > and > > >> > threat landscape has changed and how IT managers can respond. > > >> > Discussions will include endpoint security, mobile security and > > >> > the > > >> > latest in malware threats. > > >> > http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > >> > _______________________________________________ > > >> > Codenarc-developer mailing list > > >> > Cod...@li... > > >> > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > > >> > > > >> > > > >> > > > > > > > > > > ------------------------------------------------------------------------------ > > > Live Security Virtual Conference > > > Exclusive live event will cover all the ways today's security and > > > threat landscape has changed and how IT managers can respond. > > > Discussions > > > will include endpoint security, mobile security and the latest in > > > malware > > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > > _______________________________________________ > > > Codenarc-developer mailing list > > > Cod...@li... > > > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > > > > > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. > > Discussions > > will include endpoint security, mobile security and the latest in > > malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > Codenarc-developer mailing list > > Cod...@li... > > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > > > |