#948 Crash when moving up a menu item with wxSmith

[Miguel Gimenez]

A forum message reports a crash when editing a menu with wxSmith. The message is from 2014, but the issue is still there.

The steps to reproduce are:

• Create a wxWidgets project, frame based
• When project opens, double click on MenuBar editor
• Select the 'About' child menu item
• Click on the ^ button to move it up - C::B crashes

The crash is due to a bad rechaining of the moved item in the tree. The attached patch fixes this.

[bluehazzard]

Thank you for the patch.
@devs: are we using "NULL" or "nullptr"?

[Miguel Gimenez]

Looks like nullptr is preferred, see r12001 for example. I have changed the patch to use nullptr instead of 0 in the whole file.

[Teodor Petrov]

nullptr, we had this even in the pre-c++11 days, and I have to remove it (see nullptr.h/cpp) :)

[bluehazzard]

in [r12068]
Thank you for your work!