Menu

#946 Retina support for wxSmith

Next_Nightly
invalid
Patch
2022-09-23
2020-04-09
Daniel Kulp
No

The current wxSmith code does not use scaled bitmaps for the cache. Thus, everything looks blurry on the Retina displays. This patch updates to use the scaling factor to allow the Retina bitmaps.

1 Attachments

Discussion

  • Teodor Petrov

    Teodor Petrov - 2020-04-09

    I don't think this would build on anything other than macOS or GTK3. Can you do the same thing as is done in cbLoadBitmapScaled?

    Also can you explain what you're actually doing (sort of write a commit message I can use for the patch)?

     
  • Teodor Petrov

    Teodor Petrov - 2020-04-09
    • assigned_to: Teodor Petrov
    • Milestone: Undefined --> Next_Nightly
     
  • Teodor Petrov

    Teodor Petrov - 2021-04-30
    • labels: MacOSX --> MacOSX, wxSmith, hidpi
     
  • Teodor Petrov

    Teodor Petrov - 2021-04-30

    @Miguel Gimenez can you test if this patch works on windows?

     
  • Miguel Gimenez

    Miguel Gimenez - 2021-05-03

    I don't have retina display, so I can only play with scale. I see no difference in bitmaps, but the wxSmith editor in the patched version shows black background and horizontal zebra stripes when scrolling the window. MSW 10 H2

     
  • Teodor Petrov

    Teodor Petrov - 2021-05-06

    Scale on windows is the same as having a HiDPI monitor as far as I know.

     
  • Andrew Cottrell

    Andrew Cottrell - 2021-06-26

    Patch includes other mac changes than just the scaling, so a new patch will be needed. The non scaling changes are included in ticket 944 patch.

     
  • Andrew Cottrell

    Andrew Cottrell - 2022-09-22

    No updated patch will be supplied as the request has been open for 3 months.

    Also Miguel's changes for HIDPI may have resolved this.

    As such this ticket may be suitable to be closed and if testing later shows the issue is not fixed then the ticket can be reopened or another ticket could be created.

     
  • Miguel Gimenez

    Miguel Gimenez - 2022-09-22
    • assigned_to: Teodor Petrov --> Miguel Gimenez
     
  • Miguel Gimenez

    Miguel Gimenez - 2022-09-22

    wxSmith code is not HiDPI-friendly, it only has two bitmap sizes (16 and 32) and size selection is manual, via settings.

    The patch was for wxWidgets < 3.1.6, many things have changed in HiDPI support starting with 3.1.6.

    I will check the issue.

     
  • Miguel Gimenez

    Miguel Gimenez - 2022-09-23
    • status: open --> invalid
     
  • Miguel Gimenez

    Miguel Gimenez - 2022-09-23

    Patch creates artifacts and does not apply to current wxWidgets versions. I will adapt wxSmith to HiDPI when I get enough free time.

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.