#943 Use system hotlight color for start page links

[Michel Le Bihan]

wxBlue is illegible in system dark mode.
Only tested on GTK.

[Michel Le Bihan]

Sorry. I forgot the patch.

[Michel Le Bihan]

@bluehazzard Is this patch OK?

[Teodor Petrov]

Probably, I'll apply it soon.

[Teodor Petrov]

This doesn't work for wxGTK wx-master and gtk2. The link colour is black for me.
What is the version of wxGTK and GTK you're using?

[Teodor Petrov]

It is not surprising given the code in src/gtk/settings.cpp in wx-master looks like this:

        case wxSYS_COLOUR_HOTLIGHT:
            // TODO
            color = *wxBLACK;
            break;

[Michel Le Bihan]

@fuscated Sorry. I tested it only on GTK3 where the color is as expected. Will it be OK to set wxBLUE for GTK2 and wxSYS_COLOUR_HOTLIGHT for GTK3?

[Teodor Petrov]

Someone should check the situation on the other two platforms - MSW and Cocoa.

Or someone should patch wxWidgets, to fix GTK there...

[Miguel Gimenez]

In MSW 10 the change works OK, no difference

[Teodor Petrov]

Ok, it seems it is not too hard to fix https://github.com/wxWidgets/wxWidgets/pull/1805

[Michel Le Bihan]

Even if it's fixed in wxWidgets, to won't help Code::Blocks much because it will take ages for the change to make it to stable distributions. On top of that, distros refuse to package wx 3.1 because the API is not stable.

[Teodor Petrov]

This is true. On wxCocoa the color returned by this is white when using the dark theme. So it seems broken there, too. :(

    case wxSYS_COLOUR_HOTLIGHT:
        // OSX doesn't change color on mouse hover
        sysColor = [NSColor controlTextColor];
        break;