Menu

#916 Add hint about global variables to wxWidgets wizard

Next_Release
applied
nobody
Wizard (9)
Patch
2020-02-26
2020-02-05
No

When the wxWidgets wizard asks for the wxWidgets installation directory you can also use a global variable, but this is easily overlooked. This patch adds a hint about this and a format example,

1 Attachments

Discussion

  • Teodor Petrov

    Teodor Petrov - 2020-02-05

    Is this only affecting windows? Does it affect linux? On linux the global variable hint is not helpful, but it might cause confusion.

     
  • Miguel Gimenez

    Miguel Gimenez - 2020-02-06

    That page is shown only on MSW despite the string being always created:

            local wxpath_msg = _T("Please select the location of wxWidgets on your computer.\n" +
                                    "This is the top-level folder where wxWidgets was unpacked.\n" +
                                    "To help you, this folder must contain the subfolders\n" +
                                    "\"include\" and \"lib\".");
    
    8< ....... >8
    
    if (PLATFORM == PLATFORM_MSW)
                Wizard.AddGenericSelectPathPage(_T("WxPath"), wxpath_msg, _T("wxWidgets' location:"), _T("$(#wx)"));
    

    I have modified the patch so it now creates the variable wxpath_msg only if it will be really used. Targets also needed the patch.

    BTW the string is defined twice (one for projects and the other for targets); it can be unified.

     
  • Teodor Petrov

    Teodor Petrov - 2020-02-06

    Would you provide a patch which fixes the duplication? I don't insist, I just want to know if I have to apply this version.

     

    Last edit: Teodor Petrov 2020-02-06
  • Miguel Gimenez

    Miguel Gimenez - 2020-02-07

    This version removes the duplication

     
  • Miguel Gimenez

    Miguel Gimenez - 2020-02-26

    The patch was applied in r11959, so the ticket can be closed.

    Other wizards (p.e. SDL) can benefit from similar changes

     
  • Teodor Petrov

    Teodor Petrov - 2020-02-26
    • status: open --> applied
     
  • Teodor Petrov

    Teodor Petrov - 2020-02-26

    Thanks, patches welcome as always :)

     

Log in to post a comment.

MongoDB Logo MongoDB