Menu

#886 Fix assertion when changing styles of wxListView in wxSmith

Next_Nightly
applied
wxSmith (62)
Patch
2020-04-17
2019-10-29
No

Continuing ticket 884, this patch fixes assertion when changing the style of a wxListView in wxSmith, due to the one-an-only-one style rule.

The fix is exactly the same applied in r11378 to wxslistctrl

1 Attachments

Discussion

  • Teodor Petrov

    Teodor Petrov - 2020-02-23

    This patch seems too cryptic to me. Can you add some comments or at least explain what it does?

     
  • Miguel Gimenez

    Miguel Gimenez - 2020-02-24

    Here is the commented patch

     
  • Teodor Petrov

    Teodor Petrov - 2020-02-24

    So the actual problem is that the mode is not set using a radio button group or choicectrl instead of checkboxes?

     
  • Miguel Gimenez

    Miguel Gimenez - 2020-02-24

    Yes

     
  • Teodor Petrov

    Teodor Petrov - 2020-02-24

    So, can we solve the actual problem, then? :)

     
  • Miguel Gimenez

    Miguel Gimenez - 2020-02-25

    IMHO the problem is wxWidgets' choice of style bits for mode selection. Assuming they are flags, edition using checkboxes is (for me) the most intuitive form and is coherent with all the other wxSmith's items.

     
  • Teodor Petrov

    Teodor Petrov - 2020-02-26

    Checkboxes imply that you can set multiple flags at once. This is clearly not the case in this situation. I can apply this patch, but this will be a workaround and I'd rather fix the actual problem.

    If you don't intend to work on this you can say so.

     
  • Miguel Gimenez

    Miguel Gimenez - 2020-02-27

    I don't know wxSmith enough to do it reliably

     
  • Teodor Petrov

    Teodor Petrov - 2020-04-17
    • status: open --> applied
    • assigned_to: Teodor Petrov
     

Log in to post a comment.

MongoDB Logo MongoDB