Menu

#874 Plugin source_exporter compile fix for wx-master

Next_Nightly
fixed
Patch
2019-11-02
2019-09-20
sodev
No

Commit 72a225924dbd590a674f30ca93d4efd54447cdb6 in wx-master removes a function that the wxPdfDocument library uses. This patch replaces the use of the function like wxWidgets does itself.

Only tested against latest wx-master, but history shows that the used replacement exists for around 15 years, so chances are high that this even works with wxWidgets 2.8 :o)

1 Attachments

Discussion

  • Miguel Gimenez

    Miguel Gimenez - 2019-09-21

    This error only happens if you have WXWIN_COMPATIBILITY_3_0 set to 0, but of course fixing it is the better solution. This should be reported also to utelle, the wxPdfDocument developer.

    EDIT: utelle patched this 18 days ago

    https://github.com/utelle/wxpdfdoc/commit/6bc5794ba0c7461225ec976c7d9130871bd6ce5a

     

    Last edit: Miguel Gimenez 2019-09-22
  • sodev

    sodev - 2019-09-23

    My wxWidgets builds are always without any compatiblity enabled :o). Most wxWidgets libraries i saw are pretty dead and this library is contained as copy so i didn't check if upstream is still alive. So this is kind of good news for you, not your fault and upstream already fixed it itself, so my patch is kind of obsolete now.

     
  • Miguel Gimenez

    Miguel Gimenez - 2019-09-23

    Your patch is needed until source_exporter is updated to wxPdfDocument 0.9.8, currently it uses 0.9.4

     
  • Lieven de Cock

    Lieven de Cock - 2019-11-01

    are we going to update the wxPdfDocument ?

     
  • Lieven de Cock

    Lieven de Cock - 2019-11-01
    • assigned_to: Morten MacFly
    • Milestone: Undefined --> Next_Nightly
     
  • Lieven de Cock

    Lieven de Cock - 2019-11-01

    I could build CB with wx 3.1.3 with this change

     
  • Morten MacFly

    Morten MacFly - 2019-11-02
    • status: open --> fixed
     
  • Morten MacFly

    Morten MacFly - 2019-11-02

    Updated wxPDFDoc in SVN. This should include the fix.

     

Log in to post a comment.