Menu

#870 Add compiler id to Help -> About dialog

Next_Nightly
fixed
None
Patch
2019-11-05
2019-09-05
LETARTARE
No

Added the 'gcc' compiler used in the 'About' window.

1 Attachments

Discussion

  • Teodor Petrov

    Teodor Petrov - 2019-09-05
    • summary: About --> Add compiler id to Help -> About dialog
     
  • Teodor Petrov

    Teodor Petrov - 2019-09-05

    This patch is not 100%, because it doesn't detect if clang is used as compiler.

     
  • LETARTARE

    LETARTARE - 2019-09-05

    In 'StartHerePage::StartHerePage(...)' : no 'clang' detection, only 'GCC'
    Here is a simplistic version of 'clang' detection since compiler
    I can not check the 'clang' part.

     

    Last edit: LETARTARE 2019-09-05
  • Teodor Petrov

    Teodor Petrov - 2019-09-05

    This doesn't work. Clang presents itself as GCC. So it defines the GNUC define. :(

    For the start page, probably it is better to unify those so they are done in a single place.

     
  • LETARTARE

    LETARTARE - 2019-09-05

    It was my goal, but I do not know how to do better !

     
  • Miguel Gimenez

    Miguel Gimenez - 2019-09-10

    May be I missed something, but what about this?:

    #if defined (__clang__)
        + _T(" - clang ")  + (wxString()<< __clang_major__
        + _T(".") + (wxString()<< __clang_minor__)
        + _T(".") + (wxString()<< __clang_patchlevel__)
    #elif defined (__GNUC__)
        + _T(" - gcc ") + (wxString()<< __GNUC__)
        + _T(".") + (wxString()<< __GNUC_MINOR__)
        + _T(".") + (wxString()<< __GNUC_PATCHLEVEL__)
    #endif
    
     
  • Teodor Petrov

    Teodor Petrov - 2019-09-10

    Yes, this would probably work correctly.

     
  • LETARTARE

    LETARTARE - 2019-09-11
         Or again, which allows to add other GNUC compilers
                    #ifdef __GNUC__
                                      #ifdef __clang__
                                            + _T(" - clang ")  + (wxString()<< __clang_major__
                                            + _T(".") + (wxString()<< __clang_minor__)
                                            + _T(".") + (wxString()<< __clang_patchlevel__)
                                        #else
                                            + _T(" - gcc ") + (wxString()<< __GNUC__)
                                            + _T(".") + (wxString()<< __GNUC_MINOR__)
                                            + _T(".") + (wxString()<< __GNUC_PATCHLEVEL__)
                                        #endif
                         #endif
    
     
  • Morten MacFly

    Morten MacFly - 2019-11-02
    • status: open --> applied
    • assigned_to: Morten MacFly
     
  • Morten MacFly

    Morten MacFly - 2019-11-02

    Applied (modified) in SVN. Thank you!

     
  • Miguel Gimenez

    Miguel Gimenez - 2019-11-02

    The check order in the applied patch must be changed, because (as Teodor Petrov said) Clang defines __GNUC__

     

    Last edit: Miguel Gimenez 2019-11-02
  • Teodor Petrov

    Teodor Petrov - 2019-11-04
    • status: applied --> open
    • assigned_to: Morten MacFly --> Teodor Petrov
     
  • Teodor Petrov

    Teodor Petrov - 2019-11-05
    • status: open --> fixed
     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.