Menu

#805 Flashing icons in Windows' taskbar while starting C::B

Next_Nightly
applied
Windows (12)
Patch
2020-01-05
2019-03-04
No

Moved from the forum:
http://forums.codeblocks.org/index.php/topic,23042.msg157132.html#msg157132

While starting C::B in MSW there are flashing icons in the taskbar while loading the compiler plugin.

This patch fixes the issue using wxExecute() in async mode inside the relevant places of the compiler plugin.

1 Attachments

Discussion

  • bluehazzard

    bluehazzard - 2019-03-06

    Thank you for your debugging and work!

    I think we should move this execute functions to a global/sdk scope. They can be handy in other places too... No idea where at the moment...

     
  • Miguel Gimenez

    Miguel Gimenez - 2019-03-09

    As MortenMacFly noted in the forum the patch didn't compiie with wx2.8.12. This is the revised version.

     
  • Teodor Petrov

    Teodor Petrov - 2019-03-14

    I'm in serious considerations to try an implement wxexecute without the use of the wx's event loop. It is causing quite a lot of problems, but I'm not sure I want to do this work now. :(

    The situation on macOS currently is totally bad. C::B cannot start if you pass the -v option. :(

     
  • Miguel Gimenez

    Miguel Gimenez - 2019-03-15

    I have been playing with SafeYieldFor() but it doesn't work, even if I use wxEVT_CATEGORY_ALL.

     
  • Miguel Gimenez

    Miguel Gimenez - 2020-01-02

    Maybe a PCH issue, but in some systems compiler.cpp needs these two includes in order to compile correctly:

    #include <wx/process.h>
    #include <wx/txtstrm.h>
    

    See this thread for more information. Thanks to MortenMacFly and gd_on for testing the patch.

     

    Last edit: Miguel Gimenez 2020-01-02
  • Morten MacFly

    Morten MacFly - 2020-01-04
    • status: open --> applied
    • assigned_to: Morten MacFly
     
  • Morten MacFly

    Morten MacFly - 2020-01-04

    Applied in SVN. Thank you!

     
  • Teodor Petrov

    Teodor Petrov - 2020-01-04

    @Morten: Should I merge it in the release branch, or this is something that is too risky at this moment of time?

     
  • Morten MacFly

    Morten MacFly - 2020-01-04

    I think it can be safely merged. I am working with this since many months now (since the ticket was opened) - it works and makes sense.

     
  • Teodor Petrov

    Teodor Petrov - 2020-01-04

    But you're on windows and you're a single person with a single workflow. Shouldn't this be present in at least a single night build before including it in a release?

     
  • Morten MacFly

    Morten MacFly - 2020-01-05

    Its a Windows only patch and I am not alone with a single workflow. I let these patches always also use my teams and students... ;-) But its not at all important for the release. So if you want, skip it. I don't mind.

     

Log in to post a comment.