The compiler_lcc_lcc64.patch looks okay w.r.t. it adds a new compiler option, but needs to be updated for wxT, _T, _ and wxString.Format changes .
The common_functions.script_for_lcc64.patch has changes that are not right, one example is: ShowWarning(_T("This wizard doesn't know how to setup debug flags for this compiler.\n")+compilerID);
this should be changed to the following as it is way more understandable and readable output: ShowWarning(wxString::Format(_("This wizard doesn't know how to setup debug flags for the %s compiler.\n"), compilerID);
Yes LCC-Win32 is "end of life" product. This is a closed sources compiler and programmer (Jacob Navia) as retired a few years ago, it will not open source it.
This compiler (32 bit version at least) has some usage in specific cases, it now tends to be replaced by GCC
I can reformat the patch, testing against trunk will took a bit more time. Regarding information above, any chance to go to integration or it is waste of time ?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Based on my personal experience I think you are wasting your time working on this, unless you really need it as I am not the one who will be merging the change and as you have seen it has taken how many years for someone to look at it.
I have issues getting changes for Windows GCC detection merged using currently supported compilers that are used to build C::B!!!!!!
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
@bat, if you create an integrated patch for current trunk I will commit it.
Andrew's comments about wxString::Format and _T() are usually valid, but I do not think they will work in scripts. For example, calls to wxT() can not be removed.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This patch should also been added for scripted wizard correctly handle LCC64
The compiler_lcc_lcc64.patch looks okay w.r.t. it adds a new compiler option, but needs to be updated for wxT, _T, _ and wxString.Format changes .
The common_functions.script_for_lcc64.patch has changes that are not right, one example is:
ShowWarning(_T("This wizard doesn't know how to setup debug flags for this compiler.\n")+compilerID);this should be changed to the following as it is way more understandable and readable output:
ShowWarning(wxString::Format(_("This wizard doesn't know how to setup debug flags for the %s compiler.\n"), compilerID);Also be aware that the LLC has not allot of updates since 2016 as per the https://lcc-win32.services.net/README file.
So IMHO unless someone wants to update the patches and ensure they work with the trunk then this ticket will go no where.
Yes LCC-Win32 is "end of life" product. This is a closed sources compiler and programmer (Jacob Navia) as retired a few years ago, it will not open source it.
This compiler (32 bit version at least) has some usage in specific cases, it now tends to be replaced by GCC
I can reformat the patch, testing against trunk will took a bit more time. Regarding information above, any chance to go to integration or it is waste of time ?
Based on my personal experience I think you are wasting your time working on this, unless you really need it as I am not the one who will be merging the change and as you have seen it has taken how many years for someone to look at it.
I have issues getting changes for Windows GCC detection merged using currently supported compilers that are used to build C::B!!!!!!
Miguel, if you have time could you have a read of this ticket and [77] and if you think they should be closed can you please close them. Thanks Andrew
Agree with ticket #76 and #77 closing. It seems I can't do this myself (even I'm the creator of ticket), only adminstrator can.
@bat, if you create an integrated patch for current trunk I will commit it.
Andrew's comments about wxString::Format and
_T()are usually valid, but I do not think they will work in scripts. For example, calls to wxT() can not be removed.