Menu

#744 Can't compile SpellChecker plugin on MSW and WX31

Next_Nightly
fixed
Patch
2018-10-04
2018-10-01
No

When compiling the wxSpellChecker target of the SpellChecker plugin (n MSW with wx31) the compilation fails in

#include <wx/setup.h>

because the file can't be found. This is due to custom variables WX_CFG, WX_SUFFIX and WX_VERSION being defined only in the last target (plugin). I have moved them to the general project options and now it compiles OK.

1 Attachments

Discussion

  • Miguel Gimenez

    Miguel Gimenez - 2018-10-01

    This problem is present in all SpellChecker MSW projects, I have modified the patch to fix all of them.

    Following wxWidgets recommendations the file setup.h should be under the libraries folder, not in the include\wx folder.

     

    Last edit: Miguel Gimenez 2018-10-01
  • ollydbg

    ollydbg - 2018-10-03

    Strange, I just build the SpellChecker_wx31.cbp with wx 3.1.1 under 32bit GCC 7.2 under Win7, and I don't have build error, here is the build log.

     
  • ollydbg

    ollydbg - 2018-10-03

    I did see those "custom variables WX_CFG, WX_SUFFIX and WX_VERSION" are defined in the last build target(named plugin), but I'm not sure why when I select the "ALL" build target(in-fact, it is a virtual target), I don't have the build error.

     
    • Miguel Gimenez

      Miguel Gimenez - 2018-10-03

      Probably you have the file setup.h in wx/include, it is suposed to be only under the lib folder; This is why

      $(#WX31.lib)/gcc_dll$(WX_CFG)/msw$(WX_SUFFIX)
      

      is in the compiler's search path.

       
      • ollydbg

        ollydbg - 2018-10-03

        Oh, I just checked the file, and I don't have the setup.h under wx/include.

        I'm guessing that the calculation of those custom variables are mess up in my C::B. (I'm using a nightly build C::B rev11210, it is a little old, maybe, the custom variables calculation is fixed later after rev11210, and then the build error problem is exposed).

        Any way, Morten has this patch applied, thanks!

         
  • Morten MacFly

    Morten MacFly - 2018-10-03
    • status: open --> fixed
    • assigned_to: Morten MacFly
    • Milestone: Undefined --> Next_Nightly
     
  • Morten MacFly

    Morten MacFly - 2018-10-03

    Fixed in SVN already.

     
    • Miguel Gimenez

      Miguel Gimenez - 2018-10-03

      The wx30 projects should be also fixed.

       
  • Miguel Gimenez

    Miguel Gimenez - 2018-10-03

    The WX_VERSION variable value in wx31 projects is 28 and it should be 31, my second patch changed them correctly and also fixed wx30.

     
  • ollydbg

    ollydbg - 2018-10-04

    Even with the wrong commit, I can still build the wx3.1 cbp plugin successfully. Strange.
    Some one report the same issue.
    See here: [url=http://forums.codeblocks.org/index.php/topic,22848.0.html]SpellChecker_wx31 cbp bug ?[/url]

     

    Last edit: ollydbg 2018-10-04
  • ollydbg

    ollydbg - 2018-10-04
    • status: fixed --> open
     
  • ollydbg

    ollydbg - 2018-10-04

    This bug is not totally fixed. So I open it.

     
  • Morten MacFly

    Morten MacFly - 2018-10-04
    • status: open --> fixed
     
  • Morten MacFly

    Morten MacFly - 2018-10-04

    Done.

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.