It looks better, but there are strange things in it... GetItemsList is not the appropriate name for the method. It doesn't return anything, but it filters the items, so FilterItems or something similar will be better.
Also you've failed to add the new files to all the different project files and also to autotools (if you're on windows I can do this for you later)...
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Does the "mode" selection get saved when I close C::B? I just tested it, and I see C::B remember my mode settings when restarted, I don't know where does this saved?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Sorry, that I don't have much time to review all the code, I applied in my local code, and it works well. But my main free time are focus on other parts of CC. @Morten, can you have a look?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Please next time don't mix operator- and unsigned types! If something should not be negative add explicit checks instead of relying that unsigned types are always positive.
Yes ... bad usage that come from embedded dev for very small processor, where unsigned (at 8 or 16 bit range) has (had) sense, at less a few years ago ...
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
No problem on refactoring, just fell free for this. I would say "thanks", as for now, I missing time ...
At first glance, I don't see any issue, I've just generated a exe with last revision from trunk. In case something seems strange I will let you know
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Patch fully reworked.
A new Goto Window is added, with old and new mode (column version)
=>in CodeCompletion plugin directory
Add gotofunctiondlg.*
Add resources/goto_function_dlg.xrc
Patch codecompletion.cpp
Add gotofunctiondlg.cpp to C::B project, target Code-completion
Correction to wired space in column mode (gotofunctiondlg.cpp modified)
If you want the newly created files to be part of the patch just add them to source control using svn add <file1> <file2>...
Thanks !
Here is self contained version of patch
Reworked to separate common base on incrementalSelectList and GotoFunction
To be applied in codeblocks/src folder
It looks better, but there are strange things in it... GetItemsList is not the appropriate name for the method. It doesn't return anything, but it filters the items, so FilterItems or something similar will be better.
Also you've failed to add the new files to all the different project files and also to autotools (if you're on windows I can do this for you later)...
I've changed GetItemList to FilterItems and added .cbp adds
I'm on windows, for autotools, I do not know if it can be easily addes with text editor ?
Just test this patch, I think the column mode is much better than the old mode, nice work!
Does the "mode" selection get saved when I close C::B? I just tested it, and I see C::B remember my mode settings when restarted, I don't know where does this saved?
It's saved on C::B config:
(Manager::Get()->GetConfigManager(_T("code_completion"))->ReadBool(_T("goto_function_window/column_mode")))
Sorry, that I don't have much time to review all the code, I applied in my local code, and it works well. But my main free time are focus on other parts of CC. @Morten, can you have a look?
New patch:
1, fix the xrc warning issue
2, fix an issue when no match data if found, but still need to refresh the list
I have applied the modified patch to the trunk rev10899, thanks Bat!
Please next time don't mix operator- and unsigned types! If something should not be negative add explicit checks instead of relying that unsigned types are always positive.
https://www.youtube.com/watch?v=wvtFGa6XJDU
Yes ... bad usage that come from embedded dev for very small processor, where unsigned (at 8 or 16 bit range) has (had) sense, at less a few years ago ...
BTW, OBF's fix is SVN rev10916, it also has a lot of code refactoring(variable name changes)
Any problem with them?
No problem on refactoring, just fell free for this. I would say "thanks", as for now, I missing time ...
At first glance, I don't see any issue, I've just generated a exe with last revision from trunk. In case something seems strange I will let you know