#528 string search without results (w/o deleting previous results): no alert window and 'search results' tab not activated

[Jannick]

How to reproduce the issue:

1. open a tab (named [x]) other than 'Search results' in the 'Logs & others' pane
2. find a non-existing string in lines with 'Delete previous search results' unchecked
3. execute search
4. tab [x] remains activated.

Potential ENHANCEMENT:
Move to the 'Search results' tab to see that there are zero results in the log or
Open an alert window saying 'Not found' (with or without changing tabs)

NOTE: If 'Delete previous search results' is checked in the Find window, a search with zero results raises a pop-up window "Not found: <string>" (without activating the 'Search results' tab. ... which is OK, of course.

Thanks,
J. - Win10 | nightly build July 4, 2017 | svn 11112

[ollydbg]

On my test, (You are testing the Find in Files feature) I have a message box shown up, see the attachments. So, this satisfy your request:

Open an alert window saying 'Not found' (with or without changing tabs)

[Jannick]

Umm, could you please confirm that you did uncheck 'Delete previous search results' in your test search dialog? If checked then the result like yours is as desired and the same here.

[ollydbg]

Hi, Jannick, thanks for the reply. Yes, I forget to "uncheck" the 'Delete previous search results' option in my test, so I have the exact behaviour as your describe.

The solution is either switch the tab. Or show a simple messagebox saying nothing found(like the 'Delete previous search results' option is checed).

Thanks, I will mark this ticket as a bug.

[Jannick]

Hi - great! So we are on the same page. Many thanks again.

[bluehazzard]

Fixed in [r12821]
i have reworked the display logic a bit and removed the use of messages boxes if the log panel is visible. I find message boxes annoying...

[digifuzzy]

Platform x86_64 Gentoo using kernel 5.15.41
GCC 11.2.1 (patch 20220115 gentoo p4)

Building trunk at this revision produced the following error message in build log:

x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../../src/include  -I/usr/lib64/wx/include/gtk3-unicode-3.0-gtk3 -I/usr/include/wx-3.0-gtk3 -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXGTK__ -pthread -I../../src/include/scripting/include -I../../src/sdk/wxscintilla/include -I../../src/include -DENABLE_BINRELOC -DAPP_PREFIX="\"/usr\"" -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/uuid -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/at-spi-2.0 -pthread  -DUSE_GTK_NOTEBOOK -DCB_AUTOCONF  -DNDEBUG -DPIC -DTIXML_USE_STL=YES   -O2 -pipe -fPIC -fexceptions -c -o main.o main.cpp
In file included from find_replace.cpp:24:
../../src/include/searchresultslog.h: In member function ‘bool cbSearchResultsLog::IsVisible()’:
../../src/include/searchresultslog.h:30:53: error: invalid use of incomplete type ‘class wxListCtrl’
   30 |                 bool IsVisible()    { return control->IsShownOnScreen(); }
      |                                                     ^~

trunk revision 12821 was made about dozen hours ago and explains why this error is being encountered only recently.

[Andrew Cottrell]

Same failure here 2 minutes ago on a Windows build using the bootstrap/configure/make.

If I build via Windows workspace then it builds okay.

[Andrew Cottrell]

A quick hack to get me back building and updating was to modify src\include\loggers.h , line 16 from :
class wxListCtrl;

to:
#include <wx/listctrl.h>

I only tested this on Windows using the boostrap/configure.make process, so it may not work on Linux or MacOS or via a workspace etc etc.

[digifuzzy]

The fix changing a forward declaration to a header include works for me on a Linux. Build completes with error.

[bluehazzard]

Thank you for reporting.
i fixed it in the last commit.
Interestingly this does not happen for me nighter in windows nor on linux build

[digifuzzy]

One thing that occurred to after reporting was whether revision of wxWidgets would affect header usage. I have 3.0.5 installed.

[Miguel Gimenez]

@bluehazzard : If I have the log view visible and do a "Find in files", then I get a message box ("xxx found in n files. To show results open Log view"). When clicking OK, the Search results tab is shown.

I expected no message box in this case, Log view is already open.

I have "Auto show/hide message pane" disabled.

[bluehazzard]

Thank you for reporting.
Well the problem is, we do not have an api to know if the log pane is open or not. And when we are not allowed to open it, we can only assume what is going on.

Adding an api for this is also interesting...
Where should we add it? Probably in the MainFrame class and add an accessor in the wxApp class? The Log manager is the wrong place because it contains only non gui code...
suggestions?

[Miguel Gimenez]

At least within main.cpp you can use m_LayoutManager.GetPane(m_pInfoPane).IsShown()

[Miguel Gimenez]

The message box is misleading, it says "xxx found in n files", but n is not the number of files.

I think the text should be similar to "Found n instances of xxx".

[bluehazzard]

fixed in [r12831]