#338 Assert failure when clicking "properties" on a certain file

[Riot]

This is repeatable, and appears only to happen with this one file, in this one project.

Steps to reproduce:
Open the attached project
Right-click on the file resources/ARCADE_I.ttf (also attached below) and click properties
* The assert failure below pops up, before the properties dialogue opens

ASSERT INFO:
../src/common/txtstrm.cpp(94): assert "Assert failure" failed in NextChar(): unexpected decoding result

BACKTRACE:
[1] wxTextInputStream::NextChar()
[2] wxTextInputStream::ReadLine()
[3] EditorColourSet::GetLanguageForFilename(wxString const&)
[4] ProjectFileOptionsDlg::FillGeneralProperties()
[5] ProjectFileOptionsDlg::ProjectFileOptionsDlg(wxWindow*, ProjectFile*)
[6] ProjectFile::ShowOptions(wxWindow*)
[7] wxGDIObject::IsOk() const
[8] wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const
[9] wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&)
[10] wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*)
[11] wxEvtHandler::TryHereOnly(wxEvent&)
[12] wxEvtHandler::DoTryChain(wxEvent&)
[13] wxEvtHandler::ProcessEvent(wxEvent&)
[14] wxWindowBase::TryAfter(wxEvent&)
[15] wxWindowBase::TryAfter(wxEvent&)
[16] wxScrollHelperEvtHandler::ProcessEvent(wxEvent&)
[17] wxEvtHandler::SafelyProcessEvent(wxEvent&)
[18] wxMenuBase::SendEvent(int, int)
[19] g_closure_invoke
[20] g_signal_emit_valist
[21] g_signal_emit
[22] gtk_widget_activate
[23] gtk_menu_shell_activate_item
[24] g_closure_invoke
[25] g_signal_emit_valist
[26] g_signal_emit
[27] gtk_propagate_event
[28] gtk_main_do_event
[29] g_main_context_dispatch
[30] g_main_context_iteration
[31] gtk_main_iteration
[32] wxWindow::DoPopupMenu(wxMenu*, int, int)
[33] wxWindowBase::PopupMenu(wxMenu*, int, int)
[34] wxGDIObject::IsOk() const
[35] wxGDIObject::IsOk() const
[36] wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const
[37] wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&)
[38] wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*)
[39] wxEvtHandler::TryHereOnly(wxEvent&)
[40] wxEvtHandler::DoTryChain(wxEvent&)
[41] wxEvtHandler::ProcessEvent(wxEvent&)
[42] wxWindowBase::TryAfter(wxEvent&)
[43] wxWindowBase::TryAfter(wxEvent&)
[44] wxScrollHelperEvtHandler::ProcessEvent(wxEvent&)
[45] wxGenericTreeCtrl::OnMouse(wxMouseEvent&)
[46] wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const
[47] wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&)
[48] wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*)
[49] wxEvtHandler::TryHereOnly(wxEvent&)
[50] wxEvtHandler::ProcessEventLocally(wxEvent&)
[51] wxEvtHandler::ProcessEvent(wxEvent&)
[52] wxScrollHelperEvtHandler::ProcessEvent(wxEvent&)
[53] wxEvtHandler::SafelyProcessEvent(wxEvent&)
[54] g_closure_invoke
[55] g_signal_emit_valist
[56] g_signal_emit
[57] gtk_propagate_event
[58] gtk_main_do_event
[59] g_main_context_dispatch
[60] g_main_loop_run
[61] gtk_main
[62] wxGUIEventLoop::DoRun()
[63] wxEventLoopBase::Run()
[64] wxAppConsoleBase::MainLoop()
[65] main
[66] wxEntry(int&, wchar_t**)
[67] main
[68] __libc_start_main
[69] main

[Riot]

the file in question

[Teodor Petrov]

Reproduced

[Riot]

This still recurs as per SVN 11217.

[bluehazzard]

FYI: This crash happens also on windows 7 wx30

[Teodor Petrov]

This was a bug in wxwigets, which should have been fixed in their master...

[Miguel Gimenez]

It was a bug in wxWidgets, as such we can not fix it.

It is fixed in wx3.1.5, commit 45adce85618f05cdffc0
Fix wxTextInputStream for some inputs starting with nulls

The nightly uses wx3.1.5, so it is fixed there.