#1556 ScintillaWX - remove hash map for timers

[Tomasz Pawlak]

Using hash map to store just 4 pointers is an overkill - especially that they can be directly indexed using "TickReason" value.
Hash map replaced with simple array of 4 pointers.

[ollydbg]

Hi, thanks for the patch, the code changes looks OK. I agree that using a hash table for the timers is not necessary.

Our scintilla based wxWidgets code is a bit old, at least it is behind the official wxWidgets' version. But we have our own hacks.

I'm not sure the official wxWidgets' version use the same timer array?

[ollydbg]

OK, I just search the official wxWidgets' version, and they use hashmap too.

See this line:

https://github.com/wxWidgets/wxWidgets/blob/9e5b420c970fe922051955f1fa1ed35216fffc1a/src/stc/ScintillaWX.h#L209

From my point of view, do you think this patch can sumit to the wxWidgets's official github?

I think both of the 2 projects(codeblocks and wxWidigets) should use the same code base for maintaining reasons.

[Tomasz Pawlak]

Hi,
I can see that there are already many differences between the 2 projects - in CodeBlocks sources they are eclosed between / C::B begin / and / C::B end / - so the projects are no longer synchronized.

[ollydbg]

Yes, the 2 projects(C::B and wxWidgets) code are not synchronized for a long time.

And the code enclosed with // C::B begin and // C::B end are C::B's own modification to the scintilla wxWidgets ports, for example, C::B need to handle the wxSmith code as special code folding, and those code can't be contributed to wxWidgets' port.