Menu

#1496 check pointer

Undefined
applied
pecan
None
Bug_Report
2024-08-08
2024-08-07
No

File:
src\plugins\contrib\clangd_client\src\codecompletion\parsemanager.cpp line 743
Code:

    ProjectFile* pf = *flist_it;
    if ( (ParserCommon::FileType(pf->relativeFilename) == // <-- usage without pf check 
    ParserCommon::ftSource) //look for hdrs only
        or (FileTypeOf(pf->relativeFilename) == ftTemplateSource) )
        continue;
    if ( pf and (pf->file.GetName() == fnFilename.GetName()) )
    {
        if (ParserCommon::FileType(pf->relativeFilename) == ParserCommon::ftHeader)
        {
            return pf->file.GetFullPath();
        }
    }
}
return wxString();

}

Discussion

  • pecan

    pecan - 2024-08-07
    • status: open --> applied
    • assigned_to: pecan
     
  • pecan

    pecan - 2024-08-07

    Thanks

     
  • Martin Strunz

    Martin Strunz - 2024-08-08

    same stuff line 768:
    ProjectFile pf = flist_it;
    if ( ParserCommon::FileType(pf->relativeFilename) != ParserCommon::ftSource)
    continue;
    if ( pf and (pf->file.GetName() == fnFilename.GetName()) )
    return pf->file.GetFullPath();

     

Log in to post a comment.

MongoDB Logo MongoDB