Menu

#1463 Patch: fix Scintilla buffer over-read with absolute reference

Undefined
applied
nobody
sdk (14)
Patch
2024-03-13
2024-03-10
No

During build Codeblocks, e.g. at recent revision 13490 or early codeblocks-20.03, the following warning appears:

wxscintilla/src/scintilla/lexers/LexMMIXAL.cxx: In function 'ColouriseMMIXALDoc':
wxscintilla/src/scintilla/lexers/LexMMIXAL.cxx:107:56: warning: '__builtin_memmove' reading 100 bytes from a region of size 99 [-Wstringop-overread]
  107 |                                                 *(s+i) = *(s+i+1);
      |                                                        ^
wxscintilla/src/scintilla/lexers/LexMMIXAL.cxx:103:38: note: at offset 1 into source object 's' of size 100
  103 |                                 char s[100];
      |                                      ^

This is Scintilla issue [1] that was fixed in [2] on 2020-04-30.

The attached patch file "Scintilla_fix_buffer_over-read_with_absolute_reference.patch" use upstream fix to fix Codeblocks build warning.

This issue early discussed on codeblocks forum [3]

[1] https://sourceforge.net/p/scintilla/bugs/2019/
[2] https://sourceforge.net/u/vic5/scintilla/ci/6d0ce3c92a1371372bd601cd572a078d5e4041a4
[3] https://forums.codeblocks.org/index.php/topic,24505.0.html

1 Attachments

Discussion

  • ollydbg

    ollydbg - 2024-03-10
    • labels: --> sdk
     
  • Miguel Gimenez

    Miguel Gimenez - 2024-03-13
    • status: open --> applied
     
  • Miguel Gimenez

    Miguel Gimenez - 2024-03-13

    Applied in [r13491], thank you.

     

    Related

    Commit: [r13491]


Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.