#1392 MSVC import reports error after apparent success

[Miguel Gimenez]

When importing a MSVC++ workspace you get a Failed to import *any* projects from workspace file. error, while the project seems imported OK.

This is due to Open() failing at projectsimporter.cpp:280

   if (pWsp->Open(filename, Title))

Currently I have no time to investigate further.

See this forum post for more information and a test workspace.

[Miguel Gimenez]

This call at msvcworkspaceloader.cpp:197 always returns nullptr

project = Manager::Get()->GetProjectManager()->LoadProject(fname.GetFullPath(), false);

because the code at projectmanager.cpp:267 always returns nullptr for non-CB projects:

cbMimePlugin* plugin = Manager::Get()->GetPluginManager()->GetMIMEHandlerForFile(filename);
if (plugin)
    plugin->OpenFile(filename);

so import will always report failure, even if the projects are there.

[Miguel Gimenez]

Fixed in [r13270] using working code from the MSVC++ 7 importer. Looks like the original code never worked properly.