#1338 Manifest.xml thanksTo Translation problem

[Gerard DURAND]

I have problems with translations of the "thanksTo" field on some manifest.xml files. Strings are extracted in the .pot file, translated in the .po but are still shown in english in the dialogs. This concern only "thanksTo" field on several lines.
The strange thing, is that the "description" field has not this problem, though my extracting tool line is equivalent. The other strange thing, is that I'm sure that I tested this some time ago, and it was OK. But a few things have been updated in wxrc, or unix tools like sed, ... Is it the reason ? I don't know.

The problem is that those manifests have Windows lines ending (CR/LF).
If I modify those files with Linux lines ending, it works as expected on both fields.
Has "description" a specific code in C::B to eliminate the CR ?
Nevertheless, with Linux lines ending, it's OK for me, on Windows. Is it still correct on Linux, probably, but on Mac, I don't know.
I don't think that it's a conversion happening via svn download because some other files have Linux lines ending. But ...

Plugins concerned :
astyle, autoversioning, help_plugin, keybinder, profiler, source_exporter, threadsearch, wxSmith, wxSmithContribItems

Dragscroll has also a problem, but it's because the field "thanksTo" contain a & character but xml does not like it or it has a special meaning, I think. If, as in mousesap, it is replaced by & , it works.

[Miguel Gimenez]

I have fixed all, but SVN does not want to commit the new line endings. Only the fix for & has been commited.

[Gerard DURAND]

I have the feeling that it is probably a TortoiseSVN (or SVN) problem (or default config).
If I understand well, after a few internet searches, by default, EOL endings depends of the computer where the file is because set to native. So, on linux it's LF, on Windows CR/LF... If I rignt click on my Windows PC on a manifest.xml, then TortoiseSVN / Properties, I can see svn-eol-style set to native. It's possible to set it to LF (or nothing, which probably mean no changes during download or upload).
More, if I download directly a manifest file froem the svn site, but not using svn, it seems that the original file on sourceforge has only a LF.

Nevertheless, I still don't understand why it's OK for the "description" field and a problem with "thanksTo"!

[Gerard DURAND]

I have also remarked that in codesnippets, there are 2 manifest.xml. I think that it is the one in the root which is used. The other one, in resources, looks older and is slightly different

[Miguel Gimenez]

Removed resources/manifest.xml in [r13088].

[Miguel Gimenez]

Nevertheless, I still don't understand why it's OK for the "description" field and a problem with "thanksTo"!

Here you have the explanation. I will extend this to other fields.

                    if (value->Attribute("description"))
                    {
                        wxString tmp = cbC2U(value->Attribute("description"));
                        // Most manifest*.xml files contain a description item formatted for Windows (with \r\n)
                        // Remove all \r so that poedit works without complaining
                        tmp.Replace("\r", "");
                        // Use the _() macro to be able to translate the tmp string
                        infoOut->description = _(tmp);
                    }

[Miguel Gimenez]

Fixed in [r13097].