#1323 SVN changes between r12985 and r12990 degraded toolbar icons quality and issues logged

[Andrew Cottrell]

The SVN r12990 toolbar icons are no longer SVG or PNG that look good. They look bad.

The SVN r12990 codeblocks log shows the following:

(browse_tracker_toolbar): Image "images/svg/prev.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(browse_tracker_toolbar): Image "images/svg/next.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(browse_tracker_toolbar): Image "images/svg/mark.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(browse_tracker_toolbar): Image "images/svg/mark_prev.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(browse_tracker_toolbar): Image "images/svg/mark_next.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(browse_tracker_toolbar): Image "images/svg/mark_clear.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(fortran_project_toolbar_22x22): Image "images/svg/fprojectjumpback.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(fortran_project_toolbar_22x22): Image "images/svg/fprojectjumphome.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(fortran_project_toolbar_22x22): Image "images/svg/fprojectjumpforward.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(incremental_search_toolbar): Image "images/svg/incsearchclear.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(incremental_search_toolbar): Image "images/svg/incsearchprev.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(incremental_search_toolbar): Image "images/svg/incsearchnext.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(incremental_search_toolbar): Image "images/svg/incsearchhighlight.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(incremental_search_toolbar): Image "images/svg/incsearchselectedonly.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(incremental_search_toolbar): Image "images/svg/incsearchcase.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(incremental_search_toolbar): Image "images/svg/incsearchregex.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(nassi_shneiderman_toolbar): Image "images/svg/selecttool.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(nassi_shneiderman_toolbar): Image "images/svg/instrtool.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(nassi_shneiderman_toolbar): Image "images/svg/iftool.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(nassi_shneiderman_toolbar): Image "images/svg/switchtool.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(nassi_shneiderman_toolbar): Image "images/svg/whiletool.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(nassi_shneiderman_toolbar): Image "images/svg/dowhiletool.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(nassi_shneiderman_toolbar): Image "images/svg/fortool.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(nassi_shneiderman_toolbar): Image "images/svg/blocktool.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(nassi_shneiderman_toolbar): Image "images/svg/breaktool.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(nassi_shneiderman_toolbar): Image "images/svg/continuetool.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(nassi_shneiderman_toolbar): Image "images/svg/returntool.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(nassi_shneiderman_toolbar): Image "images/svg/glassptool.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(nassi_shneiderman_toolbar): Image "images/svg/glassntool.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(nassi_shneiderman_toolbar): Image "images/svg/sourceToggletool.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!
(nassi_shneiderman_toolbar): Image "images/svg/commentToggletool.svg" with size [16x16] doesn't match requested size [24x24] resizing (scale factor 1.000)!

Both of these were NOT in r12985!![]

Attached is a screen catpture (staggered apps on the one screen at the same time). It shows:
1. the nightly 12969 is okay
2. The r12858 is okay
3. The sourceforge r12990 build with bad icons. (my local r12990 build also has bad icons).

[Miguel Gimenez]

Restored previous behaviour in [r12991]. The change from AddTool(wxBitmap) to AddTool(wxBitmapBundle) is creating problems.