#1319 Search results pane from Rename Symbols shows spurious replaced text

[Basil Hussain]

I encountered a bug with the Rename Symbols refactoring command. I renamed a symbol across all project files, which completed successfully, but the Search Results pane showed incorrect text for one renaming result.

I renamed the symbol "eeprom_data" to "hat_id_data". This completed successfully. However, in one file, on the same line as one of the replacements, there also happens to be another symbol named "eeprom_data_size". This of course rightly did not actually get changed, but the row in the Search Results pane showed falsely that it had been changed, which is misleading. See the attached screenshot.

So, it seems there is a bug in the presentation of results, where C:B blindly does a substitution on the symbol name without considering there may be other symbols in the same line that are a superset (i.e. same but with an additional suffix) of that string.

This is with C:B version 20.03-r11983 on Windows 10 x64.

[ollydbg]

Hi, thanks for the report.

It looks like your are using the native codecompletion plugin. Can you try the clangd_client plugin? The former plugin has a hand-written parser which is made by ourselves, while the later one use the clangd as the parser. So, the latter one should be more accurate.

You can download the clangd_client plugin in the nightly build sub-forum.