#1294 Replace hardcoded separators with wxPATH_SEP/wxFILE_SEP_PATH

[Carlo Bramini]

While looking to the source code, I noticed into several sources these lines:

wxString sep = platform::windows ? _T(";") : _T(":");
wxChar pathSep = platform::windows ? _T('\') : _T('/');

or expressions like:

&& ((masterPath.Last() == '\') || (masterPath.Last() == '/')) )

Would it be correct to simplify a bit that code by using macros wxPATH_SEP and wxFILE_SEP_PATH?

Sincerely,

Carlo Bramini.

[Carlo Bramini]

Excuse me, I accidentally pressed the Post button before finishing the ticket and formatting the code lines. The right title in my mind was "Replace hardcoded separators with wxPATH_SEP/wxFILE_SEP_PATH".

[Morten MacFly]

Please be super-careful here, simple replacing this:
&& ((masterPath.Last() == '\') || (masterPath.Last() == '/')) )
...is dangerous because for example we "Unix-encode" paths in project files for good reasons also on Windows. So such a change must be done with special extra-care!

This one could be replaced though:

wxString sep = platform::windows ? _T(";") : _T(":");
wxChar pathSep = platform::windows ? _T('\') : _T('/');