Menu
▾
▴
1 Attachments
#1287 Update SpellChecker due to use of depricated functions used & remove hunspell source
The existing spellchecker plugin includes the hunspell source code, whcih is not needed if you use the hunspell dev library.
The spellchcker also uses depreciated hunspell functions that are easy to resolve. Attached is a GNU diff patch showing the changes to fix just the depreciated functions.
Same story here: There is no replacement on Windows for quite a few MinGW distros. I am not sure how this should work.
The patch is probably worth looking into... will do!
This patch does not apply on the current SVN version.
Please use svn diff > my_patch.diff at C:: source code root and provide the patch again. Thank you!
As usual you did not read the post.
Which post? As usual you don't explain well. :-)
The point is: The patch does not apply. So either you provide a solution instead of un-helpful comments or this gets closed.
Last edit: Morten MacFly 2022-07-27
As usual dumb response that shows you do not look.
There is only one post from me above the previous post and it's the initial description,.
Andrew, this will be my last warning:
I am trying to help here by bringing something forward! So either you just explain what is needed and don't annoy people or I am going to block you. I don't know what you problem is, really.
I don't see a post that explains why the patch does not apply!
Please answer and don't waste everyones time.
THANK YOU!
One more try: Please help with the patch! The reason is:
1.) SVN tools on Windows only support SVN patch styles and reject this format (that's why I've asked to provide the patch in SVN diff style)
2.) there are tons of GNU Diff tools for Windows. I don't know which one is compatible to this format.
3.) Alternatively, please provide instructions on how to apply this patch on Windows.
For a simple workflow:
- Checkout the sources from SVN
- Work (if you like) on GIT
- Sync changes to the SVN folder
- Create a SVN diff patch.
Please see also here:
http://wiki.codeblocks.org/index.php/Creating_a_patch_to_submit_(Patch_Tracker)
...in the end: We ask for patches in SVN diff style for good reasons basically to avoid the need to write this over and over again. :-)
SVN patch.
After this patch the Spellchecker plugin no longer compiles, see this forum post
The patch was not a standalone patch as it was "patch showing the changes to fix just the depreciated functions."
Attached is a patch to fix the build.
After applying the patch compilation was still broken, now on the "plugin" target.
I have changed the search paths of target "plugin", it did not search in hunspell/src/hunspell while the others did.
Strange as I did not have to change the search paths in any project file or makefile to get the build to work after making the #include change. I used the 3.2 64 bit windows workspace.
As I said below: I did not even need to make the #include change (wx31 build) . In don't now whats going on here...?!
I don't understand: For me it builds just fine on Windows, otherwise I wouldn't have committed it. What exactly fails for you?! Is this on Linux?
My guess on what is going on is that the three of us have the hunspell.h file in different directories and as such when we compile the source we get different results.
Where on your systems do you have the hunspell.h file? Search and include the results for both the C::B source tree and the compiler source tree.
I have it in the following C::B source tree directory only:
\src\plugins\contrib\SpellChecker\hunspell\src\hunspell\hunspell.h
I have it in the following MSYS2 directory only (results for all of the C:\msys64..... tree) :
C:\msys64\mingw64\include\hunspell\hunspell.h
Patch to fix crash. This has only had an hour of testing.
Applied in SVN, but slightly modified. The prefix "wx" should not be used for local variables not to be confused with wx types.