#1266 Revision 12805 failed to compile with --disable-pch option

[band-a-prend]

Revision 12805 failed to compile with --disable-pch option resulting in error:

libtool: compile:  x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../../../../src/include -I/usr/lib64/wx/include/gtk3-unicode-3.0-gtk3 -I/usr/include/wx-3.0-gtk3 -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXGTK__ -pthread -I../../../../src/include/scripting/include -I../../../../src/include -I../../../../src/sdk/wxscintilla/include -DCB_AUTOCONF -DNDEBUG -DPIC -DTIXML_USE_STL=YES -march=native -O2 -pipe -fPIC -fexceptions -c sc_plugin.cpp  -fPIC -DPIC -o .libs/sc_plugin.o
In file included from sc_plugin.cpp:13:
../../../../src/include/scripting/bindings/sc_typeinfo_all.h:271:17: error: ‘TiXmlPrinter’ was not declared in this scope; did you mean ‘ScriptBindings::TypeTag::TiXmlPrinter’?
  271 | struct TypeInfo<TiXmlPrinter>
      |                 ^~~~~~~~~~~~
      |                 ScriptBindings::TypeTag::TiXmlPrinter
../../../../src/include/scripting/bindings/sc_typeinfo_all.h:81:5: note: ‘ScriptBindings::TypeTag::TiXmlPrinter’ declared here
   81 |     TiXmlPrinter,
      |     ^~~~~~~~~~~~
../../../../src/include/scripting/bindings/sc_typeinfo_all.h:271:29: error: template argument 1 is invalid
  271 | struct TypeInfo<TiXmlPrinter>
      |                             ^
make[4]: *** [Makefile:541: sc_plugin.lo] Error 1

The full configuration option list is:

./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --datarootdir=/usr/share --disable-dependency-tracking --disable-silent-rules --disable-static --docdir=/usr/share/doc/codeblocks-9999 --htmldir=/usr/share/doc/codeblocks-9999/html --with-sysroot=/ --libdir=/usr/lib64 --disable-static --with-boost-libdir=/usr/lib64 --disable-debug --disable-pch --with-contrib-plugins=all

Actually this is Gentoo Linux dev-util/codeblocks-9999.ebuild (e.g. trunk version).
The using of PCH option for Gentoo package now is undesirable due to several Gentoo issues (info from Gentoo package config file /usr/portage/profiles/base/use.mask):

# PCH has proven itself to be unreliable and lead to spurious build
# failures. Masking so users aren't exposed to such failures without opting-in.
# Failures aren't always reproducible and implementations are often fragile.
# See e.g. bug https://bugs.gentoo.org/753323, bug https://bugs.gentoo.org/822690

[Miguel Gimenez]

Does this compile if you insert

class TiXmlDocument;
class TiXmlPrinter;

in line 29 of that file?

[band-a-prend]

Yes, this patch fixes issue.
Thanks!

[Miguel Gimenez]

Fixed in [r12806].