Menu

#1202 Remove CB_AUTOCONF define usage in configmanager.cpp/h

Undefined
open
nobody
None
Feature_Request
2022-02-17
2022-02-10
No

The CB_AUTOCONF define should be able to be removed from the configmanager.cpp/h files and instead change the ConfigManager::GetFolder(...) function for the sdPluginsGlobal switch as follows so it auto detects the directory to use and therefor the CB_AUTOCONF define can be removed from the code and the m4\acinclude.m4 file.

case sdPluginsGlobal:
{
if (wxDirExists(ConfigManager::data_path_global + wxFILE_SEP_PATH + _T("plugins")))
return (ConfigManager::data_path_global + wxFILE_SEP_PATH + _T("plugins"));
else
return ConfigManager::plugin_path_global;
}

This was found if C::B is built on Windows using the boostrap/configure/make process as CB_AUTOCONF is defined by default, but then the wrong plugin directory is returned via ConfigManager::GetFolder(...).

Discussion

  • ollydbg

    ollydbg - 2022-02-11

    From my point of view, the CB_AUTOCONF can be removed from the source code. Since now, we can use autotools to build C::B under both Windows and Linux.

     

    Last edit: ollydbg 2022-02-11
  • Andrew Cottrell

    Andrew Cottrell - 2022-02-11

    Please find attached a patch to remove CB_AUTOCONF and mods to autodetect the plugin path in configmanager.cpp.

     
  • Andrew Cottrell

    Andrew Cottrell - 2022-02-17

    This needs to be applied in order for ticket 1199 to work.

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.