Menu

#1196 Remove code to stop app and debug log when runnin in batch mode

Undefined
applied
nobody
None
Undefined
2022-02-09
2022-02-06
No

The code for this bug is more than 14 years old as this was when the lines in the code were reformatted that this patch is removing.

If you run C::B with the following parameters (plus others to make C::B batch mode work)
--log-to-file --debug-log-to-file --build

Then you expect to have a app and debug log, but due to the lines in the following code snippet you do NOT get any log files.

    if (!Manager::IsBatchBuild())
    {
*CODE REMOVED*
    }
    else
    {
*CODE REMOVED*
        // setting &g_null_log causes the app to crash on exit for some reason...
**      mgr->SetLog(new NullLogger, LogManager::app_log);
      mgr->SetLog(new NullLogger, LogManager::debug_log);
**    }

Patch attaches to remove the two lines.

1 Attachments

Related

Tickets: #1197

Discussion

  • Miguel Gimenez

    Miguel Gimenez - 2022-02-06

    Does the app crash on exit if you remove them?

     
    • Andrew Cottrell

      Andrew Cottrell - 2022-02-06

      I have not had any crashed after removing the lines. I have done a minimum of about 20 batch builds after making the changes.

       
  • Miguel Gimenez

    Miguel Gimenez - 2022-02-09
    • status: open --> applied
     
  • Miguel Gimenez

    Miguel Gimenez - 2022-02-09

    Applied in [r12712], thank you.

     

    Related

    Commit: [r12712]


Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.