Menu

#1154 Disable "Copy To" button in global compiler options

Next_Nightly
applied
Patch
2021-12-15
2021-11-13
No

The "Copy To" button in compiler options is used to copy libraries or paths between targets. Because of this, if you click on it when there is no project (i.e., you are editing the global compiler options) it just returns silently, as you can see in this code fragment:

void CompilerOptionsDlg::OnCopyDirsClick(cb_unused wxCommandEvent& event)
{
    if (!m_pProject)
        return;

This confuses the user, as seen in the forum.

The attached patch disables the "Copy To" button if there is no project.

1 Attachments

Discussion

  • bluehazzard

    bluehazzard - 2021-11-14
    • assigned_to: bluehazzard
     
  • Miguel Gimenez

    Miguel Gimenez - 2021-12-14

    How is this going, is there any concern?

     
  • bluehazzard

    bluehazzard - 2021-12-14
    • assigned_to: bluehazzard --> Miguel Gimenez
     
  • bluehazzard

    bluehazzard - 2021-12-14

    You are dev now, you can take the credit in the commit log :)

     
  • Miguel Gimenez

    Miguel Gimenez - 2021-12-14

    I am not concerned by the credit, you took care of the ticket when I was not a dev and I respect ownership. My main concern was if you had a better solution (p.e. hiding the button instead of disabling). If there is no objections I will commit the current patch tomorrow.

     
  • Miguel Gimenez

    Miguel Gimenez - 2021-12-14
    • status: open --> pending
     
  • bluehazzard

    bluehazzard - 2021-12-14

    na, i am fine with this!

     
  • Miguel Gimenez

    Miguel Gimenez - 2021-12-15
    • status: pending --> applied
     
  • Miguel Gimenez

    Miguel Gimenez - 2021-12-15

    Applied in [r12581]

     

    Related

    Commit: [r12581]


Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.