Menu

#1145 Fix some EnvVars problems, one of them is a show stopper

Next_Nightly
applied
envvar (4)
Patch
2021-10-24
2021-10-20
No

The EnvVars plugin has some problems:
* When you configure a project to use an envvar set, you get a "Set not found" error (show stopper)
* Once the previous issue is fixed, If you change the set you must close and reopen the project for the change to be effective
* When you edit a set in Preferences, only the changes to the visible set are saved; the rest are lost
* There was a Unicode-related hack in EnvVarsDebugLog() and an unneeded overload with lots of duplicated code
* Set list is not sorted when shown

The attached patch fixes these, and also:
* corrects coding style
* adds const where applicable
* take constant expressions out of the loops
* some code refactoring for clarity
* removed the _T() macro where not needed

The coding style changes (specially tab size) make the patch difficult to review. I have attached a second patch without most the whitespace changes, this is intended for review only.

2 Attachments

Discussion

  • bluehazzard

    bluehazzard - 2021-10-24
    • status: open --> pending
    • assigned_to: bluehazzard
     
  • bluehazzard

    bluehazzard - 2021-10-24
    • status: pending --> applied
     
  • bluehazzard

    bluehazzard - 2021-10-24

    Ok,
    tested on windows and linux,
    works fine for me,

    Patch applied in r12537

    Thank you a lot

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.