#1125 Compiler selection dialog should not include invalid compilers

[Andrew Cottrell]

The compiler selection dialog that is shown if you load a project that has an invalid compiler and open the build options shows all of the compilers which is not very good as it should only show valid compilers so the end user can select it instead of potentially another invalid compiler.

[Andrew Cottrell]

The code to resolve tickets 1125 & 1126 are available from the following github branch:
https://github.com/acotty/codeblocks_sf/commits/AC-ProjectLoadInvalidCompilerDetection

[Miguel Gimenez]

Fixed in [r12601]

[Andrew Cottrell]

This is not fixed in Nightly SVN 12719 as it shows the compiler drop down as "blank" and no errors or messages are shown, so the end user will think everything is okay. Attached is a screen snippet of the dialog showing the issue.

This was tested as follows:
1) Open my Cygwin based project file with cygwin in C:\cygwin64
2) Make sure the compiler in the project->build options dialog is set to "Cygwin GCC"
3) Save the project.
4) Close Code::Blocks
5) Make sure the project file has the compiler set to "cygwin" (attached is the project file)
6) Rename C:\cygwin64 to C:\test.cygwin64
7) Open Code::Blocks
8) Load the project file
9) Select the project->build options dialog and it will show the "blank" compiler.

Let me know if you want the solution I did last year.

[Morten MacFly]

Similar to:
https://sourceforge.net/p/codeblocks/tickets/1126/

From my point of view we don't have an issue here. There are cases where you explicitly want to select invalid compilers. So please: DON'T CHANGE!

If patches have been applied that make this selection impossible, they will be reverted.

[Andrew Cottrell]

If the failure in the current nightly is okay then so be it.