I've modified and committed part of the patch.
I've improved the formatting of the patch, removed wxT or_T, remove the part of the patch which handles unsigned long.
I've removed the condition for " if (m_doLocals)", because it executed the same command. Is this what is intended to happen? I've tried to read the docs, but I don't understand them and I don't have CDB, so I cannot experiment. Please tests and let me know if something else needs to be done.
About the unsigned long parsing - can you write tests in debuggergdb/debuggergdb_test_parser_cdb.cpp ? It will fine if you could just write the test cases without compiling them. I'll make sure that they pass. I know we don't have many test cases, but practice and history has taught me that having tests for these things makes changing the code a lot easier and it catches mistakes really early.
I'll leave this ticket open for now.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
maras420,. Can you try the win 32 nightly from 11-May-2021 referenced in the following post and let us know if the changes as per the prvious psot work for you: https://forums.codeblocks.org/index.php/topic,24487.msg167041.html#msg167041
Andrew Cottrell what do you try to achieve here? If I wanted to close this ticket I would have done so already. I do passes on these from time to time and I'm closing the ones I think should be closed due to inactivity, but messages like yours doesn't help actually.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This patch fixes finding all threads in the command response. The GetArrayFromString function removed spaces and only a row beginning with '.' was displayed."
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Does it work for both 32 bit and 64bit executables/CDBs?
I only use it for 32-bit CDBs. I didn't test it with a 64-bit CDB.
I've modified and committed part of the patch.
I've improved the formatting of the patch, removed wxT or_T, remove the part of the patch which handles unsigned long.
I've removed the condition for " if (m_doLocals)", because it executed the same command. Is this what is intended to happen? I've tried to read the docs, but I don't understand them and I don't have CDB, so I cannot experiment. Please tests and let me know if something else needs to be done.
About the unsigned long parsing - can you write tests in debuggergdb/debuggergdb_test_parser_cdb.cpp ? It will fine if you could just write the test cases without compiling them. I'll make sure that they pass. I know we don't have many test cases, but practice and history has taught me that having tests for these things makes changing the code a lot easier and it catches mistakes really early.
I'll leave this ticket open for now.
maras420,. Can you try the win 32 nightly from 11-May-2021 referenced in the following post and let us know if the changes as per the prvious psot work for you:
https://forums.codeblocks.org/index.php/topic,24487.msg167041.html#msg167041
( https://drive.google.com/drive/folders/1ZFrngxAfDFw5W-kKPvC_azjBmC_XMgPQ )
Andrew Cottrell what do you try to achieve here? If I wanted to close this ticket I would have done so already. I do passes on these from time to time and I'm closing the ones I think should be closed due to inactivity, but messages like yours doesn't help actually.
As such due to the tone of the response I will stop trying to help for ANY CB tickets or forum posts, unless explicitly asked.
I'm very busy right now. My new projects use gcc and gdb.
I checked this fix on svn 12475, but it needs minor fixes.
I tested the fix on x32 and x64.
Last edit: maras420 2021-07-03
@maras420: Can you provide an explanation what this patch does?
This patch fixes finding all threads in the command response. The GetArrayFromString function removed spaces and only a row beginning with '.' was displayed."
In svn. Thanks for the contribution. Is there anything left to do about this ticket?
Probably nothing