#1045 plugin / contrib / help / unreachable code

[Martin Strunz]

/src/plugins/contrib/help_plugin/man2html.cpp line 3407
Code:
case REQ_ec: // groff(7) "reset Escape Character"
{
c=c+j;
if (c!='\n')
escapesym=c;
else
escapesym='\';
break;
c=skip_till_newline(c); // <-- unreachable
}

[ollydbg]

Hi, thanks for the report.

                case REQ_ec: // groff(7) "reset Escape Character"
                {
                    c=c+j;
                    if (*c!='\n')
                        escapesym=*c;
                    else
                        escapesym='\\';
                    break;
                    c=skip_till_newline(c);
                }

Do you mean the break should be put after the line c=skip_till_newline(c);?
I am not quite understand the logic of the manual to html conversion. Thanks.

[ollydbg]

Hi, by looking at the KDE runtime source code, I see the code is the same as ours

https://github.com/KDE/kde-runtime/blob/d765545023776ec49ae9bd183176014143fe15d3/kioslave/man/man2html.cpp#L3807-L3816

So, this is by design? Or this is also a bug in kde?