Menu

#400 Prefix public Sphinxbase symbols with sb_

next release
open
nobody
sphinxbase (2)
5
2014-10-04
2014-10-03
David Brown
No

I propose prefixing all public Sphinxbase symbols with sb_ (or SB_ for macros), just as PocketSphinx uses the ps_ prefix. This will make it easier for newcomers to determine where symbols are defined when reading the PocketSphinx source code and will reduce the likelihood of symbol collisions when Sphinxbase is used as part of a larger library or application.

Discussion

  • Nickolay V. Shmyrev

    Thanks for the proposal, David, however, I doubt we going to make it in a near time. That's too major change.

     
  • David Brown

    David Brown - 2014-10-04

    Would you accept patches that added prefixed versions of symbols as macros and gradually replaced references throughout the the project over time? That would avoid breaking the entire codebase, at least. Then one could eventually remove the macros and rename the actual symbols when the old ones are no longer in use.

     
    • Nickolay V. Shmyrev

      Would you mind to contribute with something more reasonable ;) ? For example we need to support language models with vocabulary more than 60k words.

       

Log in to post a comment.

MongoDB Logo MongoDB