Menu

#374 RaisedCosineWindower missing check

next release
closed
nobody
None
1
2014-03-04
2014-03-03
No

In the while loop 'while (length < cosineWindow.length)' of the RaisedCosineWindower method 'process()' the following if statement is missing a check for SpeechEndSignal:

if( next instanceof DataEndSignal )
{
utteranceEnd = next;
break;
}

Suggested alternative:

if( next instanceof DataEndSignal || next instanceof SpeechEndSignal )
{
utteranceEnd = next;
break;
}

This seems to lead to problems in case the window shift does not match the framesize.

Related

Issues: #374

Discussion

  • Nickolay V. Shmyrev

    • status: open --> closed
     
  • Nickolay V. Shmyrev

    Applied, thanks a lot for your submission!

     
    • Brian Bloemendal

      Thank you for your response.

      I've also submitted an issue about the microphone module:
      354 http://sourceforge.net/p/cmusphinx/bugs/354/Sphinx Live
      microphone bughttp://sourceforge.net/p/cmusphinx/bugs/354/
      If you set the number of channels to 2 the live application hangs somtimes
      after a first word and recognizes two words immediately after each other if
      you then say another word.
      This happens because the amount of data you have to read is depending on
      the number of channels.

      Kind Regards,
      Brian Bloemendal

      2014-03-03 23:45 GMT+01:00 Nickolay V. Shmyrev nshmyrev@users.sf.net:

      Applied, thanks a lot for your submission!

      Status: closed

      Group: next release
      Created: Mon Mar 03, 2014 09:51 AM UTC by Brian Bloemendal
      Last Updated: Mon Mar 03, 2014 09:51 AM UTC
      Owner: nobody

      In the while loop 'while (length < cosineWindow.length)' of the
      RaisedCosineWindower method 'process()' the following if statement is
      missing a check for SpeechEndSignal:

      if( next instanceof DataEndSignal )
      {
      utteranceEnd = next;
      break;
      }

      Suggested alternative:

      if( next instanceof DataEndSignal || next instanceof SpeechEndSignal )
      {
      utteranceEnd = next;
      break;
      }

      This seems to lead to problems in case the window shift does not match the
      framesize.


      Sent from sourceforge.net because you indicated interest in
      https://sourceforge.net/p/cmusphinx/bugs/374/

      To unsubscribe from further messages, please visit
      https://sourceforge.net/auth/subscriptions/

       

      Related

      Issues: #374

  • Nickolay V. Shmyrev

    I applied that one too. Thank you and sorry for the delay.

     
    • Brian Bloemendal

      No problem. Thanks for your response.

      Kind Regards,
      Brian

      2014-03-04 15:04 GMT+01:00 Nickolay V. Shmyrev nshmyrev@users.sf.net:

      I applied that one too. Thank you and sorry for the delay.

      Status: closed

      Group: next release
      Created: Mon Mar 03, 2014 09:51 AM UTC by Brian Bloemendal
      Last Updated: Mon Mar 03, 2014 10:45 PM UTC
      Owner: nobody

      In the while loop 'while (length < cosineWindow.length)' of the
      RaisedCosineWindower method 'process()' the following if statement is
      missing a check for SpeechEndSignal:

      if( next instanceof DataEndSignal )
      {
      utteranceEnd = next;
      break;
      }

      Suggested alternative:

      if( next instanceof DataEndSignal || next instanceof SpeechEndSignal )
      {
      utteranceEnd = next;
      break;
      }

      This seems to lead to problems in case the window shift does not match the
      framesize.


      Sent from sourceforge.net because you indicated interest in
      https://sourceforge.net/p/cmusphinx/bugs/374/

      To unsubscribe from further messages, please visit
      https://sourceforge.net/auth/subscriptions/

       

      Related

      Issues: #374


Log in to post a comment.