From: Vladimir T. <vtz...@gm...> - 2008-10-29 14:39:11
|
On Oct 29, 2008, at 4:33 PM, Sam Steingold wrote: > Vlado, > you write: > > +#if defined(MULTITHREAD) > +/* O(open_files) should be guarded by global lock */ > +global xmutex_t open_files_lock; > +#endif > + > /* UP: add a stream to the list of open streams O(open_files) > add_to_open_streams() > <> stream > can trigger GC */ > +/* TODO: needs global lock */ > local maygc object add_to_open_streams (object stream) { > > 1. isn't open_files_lock the global lock already guarding O > (open_files)? Yes > 2. why TODO? it was TODO. not anymore - forgot to remove it - sorry. > PS, please indent #if/#endif like it is done throughout the code. > ok. Vladimir |