Re: makensis patch

[Elliott S. <ell...@gm...>]

On Nov 18, 2007 11:31 AM, Sam Steingold <sd...@gn...> wrote:
> > Revised patches below (sorry the length of the whole patch set).
>
> linebreaks are garbled, so I cannot apply the patch.
> could you please post a URL instead? thanks.

That would explain why I am having trouble patching these files.

> why are you using %NAME% instead of the more standard in the autotool
> world @NAME@?

That was my mistake. I misread your original email suggesting
conversion to "@NAME@" and "@VER@" tags.

> does nsis support variables?
> if it does, it is better to do something like
>
> NAME=@NAME@
> ...
> ${NAME}
>
> instead of @NAME@ everywhere.
> this would make it easier for the creator of the installer to modify
> this string as he sees fit.

That is exactly what install.nsi does. For example:
  WriteRegStr HKCU "Software\${NAME} ${VERSION}" "Desktop Shortcut" "true"
or with the new patch:
  WriteRegStr HKCU "Software\${NAME}" "Desktop Shortcut" "true"

Speaking of which, would it be possible to have only the name in
${NAME}? You wouldn't have to do a massive patch to change everything,
and it would give the builder more flexibility with regard to any
particular value. It isn't impossible that the builder might want to
customize one of the strings a little more, or that the builder might
want only "GNU CLISP" and not the full "GNU CLISP 2.43".

-- 
Elliott Slaughter

"Any road followed precisely to its end leads precisely nowhere." -
Frank Herbert