Re: englishification before 2.43?

[Bruno H. <br...@cl...>]

Reini Urban wrote:
> > and the remaining untranslated german C- function names in the .d
> > files, some remaining structure members, and labels.

It is good that you do this, but please be do it carefully (i.e. either
manually, and then grepping for occurrences that you missed; or mechanically
using 'sed', reviewing the changes afterwards).

Sam wrote:
> mass renaming identifiers is quite dangerous.
> Bruno, what do you think?

Mass renaming is out of question. I would never accept a patch in which more
than 5 identifiers are renamed at once. One renaming in each patch is the best.
Reini needs to provide "small" renaming patches one by one, so that you can
check in one patch a day. Then, when a problem occurs, it's manageable to
look where the problem comes from. (I often worked like this, having a pile
of upto 30 patches pending, and committing one per day, so that the normal
testing would uncover problems not too late.)

> > numeric functions:
> >   *_mal_*   => *_mult_*
> 
> why not "mul" - to keep it the same 3 characters as "div"?

"mult" is more mnemonic to me. I too prefer it over "mul".

> >   *_durch_* => *_div_*

ok.

> > char and string functions and symbols:
> > in src/charstrg.d, src/constsym.d, src/eval.d, src/subr.d, src/subrkw.d:
> >   gleich => arith_equal

"arith" is an old-style German term as well. Make it "numequal".

> >     *klgleich  => *lessequal
> >     *grgleich  => *grequal

Make that ltequal and gtequal, respectively. The English abbreviations for
"less than" and "greater than" - at least in HTML - are "lt" and "gt".

> >     N_N_gleich  => N_N_equal

Possibly N_N_numequal?

> >     string_gleich_inverted  => string_equal_inverted

yes

> I suggest borrowing from Fortran.
> lt, le, gt, ge are all clear and concise.

A bit too concise in my taste, Sam...

> > LISPARIT functions and symbols:
> > einplus  => incone
> > einminus => decone
> 
> incf and decf are more readable to a lisper.

But incf and decf are destructive operations. These are 1+ and 1-. Call them
plus_one, minus_one, or add_1, add_minus1.

> > mal      => mult
> > mal2     => mult3
> > mal3     => mult3

Take care, please! If you make mistakes like this, it will be the hell to
debug.

> > Reason: Those string checks and arithmetic funcs are the only
> > remaining internal german function and symbol names.
> >
> > Changed structure members and local variables:
> >
> >   *_anz => num_* in globals members and vars

No, "count" is a better term than "number" for this. (Because "number" is
also a type, whereas "count" is not.) Make it *_count.

> > subr_anz  => num_subr
> > fsubr_anz => num_fsubr

subr_count, fsubr_count etc. are all right.

Bruno