[ clisp-Feature Requests-1373705 ] socket-server :backlog :interface

[SourceForge.net <no...@so...>]

Feature Requests item #1373705, was opened at 2005-12-05 12:52
Message generated for change (Comment added) made by sds
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=351355&aid=1373705&group_id=1355

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Sam Steingold (sds)
Assigned to: Nobody/Anonymous (nobody)
Summary: socket-server :backlog :interface

Initial Comment:
socket-server should accept
 :backlog and pass it on to listen() and
 :interface and use it instead of the socket argument.

(socket-server socket-stream)
should be deprecated (show a warning) in favor of
(socket-server nil :interface socket-stream)

:interface argument should be one of
- socket-stream
- raw socket
- string (IP address)
and default to "0.0.0.0" as it is now
(or maybe "localhost" for security?)

:backlog argument should be a fixnum and default to 1

files to be changed:
src/stream.d: make socket-server accept keyword arguments
src/socket.d: make create_server_socket accept backlog
src/subr.d, src/subrkw.d: change the signature of
socket-server
doc/impext.xml: update the documentation for socket-server

----------------------------------------------------------------------

>Comment By: Sam Steingold (sds)
Date: 2005-12-12 09:35

Message:
Logged In: YES 
user_id=5735

1 use stream_handles()
4 ok, I will enable check_uint_defaulted() in lispbibl.d

----------------------------------------------------------------------

Comment By: Tomas Zellerin (zellerin)
Date: 2005-12-12 08:24

Message:
Logged In: YES 
user_id=120720

1. I tried to find proper extractor but failed (and it was 
this way in the source). Ill look once more.
2., 3., 5., 6. -  OK.
4. - uint/sint - my overlook.
   - check_uint_defaulted is not in my lispbibl.d, only in 
clisp.h, and it does not appear to be included.


----------------------------------------------------------------------

Comment By: Sam Steingold (sds)
Date: 2005-12-08 14:30

Message:
Logged In: YES 
user_id=5735

thanks, this is a great start - just a few notes:

1. stream_to_socket should not be needed - there are plenty
of FD extractors already
2. warnings are issued by funcall(S(warn),...), not fprintf
3. please avoid "# " comments in new code, use /**/ instead
4. backlog is int, why are you using I_to_sint16?
I suggest int backlog = check_uint_defaulted(popSTACK(),1);
5. in documentation, use <function
role="unix">listen</function>.
6. also, the use of socket as the first argument should be
no longer documented.


----------------------------------------------------------------------

Comment By: Tomas Zellerin (zellerin)
Date: 2005-12-07 09:41

Message:
Logged In: YES 
user_id=120720

The problem is that I do not have the box _neither_ file 
selection form present :) I can only Add a comment.

----------------------------------------------------------------------

Comment By: Sam Steingold (sds)
Date: 2005-12-07 09:34

Message:
Logged In: YES 
user_id=5735

to upload you need to check a box _and_ enther the path.
clisp.h is a generated file, do not touch it.
constsym.d is indeed to be changed, yes.
please do not forget a src/ChangeLog entry.
please also take a look at src/CodingStyle.
thanks.

----------------------------------------------------------------------

Comment By: Tomas Zellerin (zellerin)
Date: 2005-12-07 02:48

Message:
Logged In: YES 
user_id=120720

I have a working patch (thought not polished with respect 
to all possible parameters combinations yet) to make this 
work, so I know I can do it; however, I can not upload any 
files to this request in tracker. Can you do something 
with it (maybe assigning would help), or shall I put final 
patch to patches?

Also, I had to change few more files, src/constsym.d and 
src/clisp.h to allow for new keywords - as I am doing such 
modifications for the first time, I am not sure if this is 
necessary.

----------------------------------------------------------------------

Comment By: Sam Steingold (sds)
Date: 2005-12-05 12:52

Message:
Logged In: YES 
user_id=5735

http://article.gmane.org/gmane.lisp.clisp.general:10553

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=351355&aid=1373705&group_id=1355