Re: another bad patch

[Sam S. <sd...@gn...>]

> * Bruno Haible <oe...@py...t> [2005-02-18 19:37:07 +0100]:
>
>   modules/i18n/gettext.c
>     for the nl_item, CODESET is being used as a default without any reason
>     that a user could infer from the POSIX specs,

the others are obviously much less important.

>   modules/syscalls/calls.c
>     - for confstr, _CSPATH is being used as a default without any reason
>       that one could infer from the POSIX specs,

same.

>     - for getrlimit, RLIMIT_CPU is being used as a default without any reason,

CPU is the most important limit.

in these examples, the original behavior is precisely what I wanted.

> I.e. the "implicit default" approach leads to unwanted, undesirable
> behaviour.

why do you presume that this is unintended?!
it is not.
if you bothered to read my changes which I made when the first constant
became the default, you would have noticed that I re-ordered many
constant lists to make sure that the first constant is a reasonable
default.


>> just don't break code of other which relies on the documented behavior.
>
> I changed your code (berkeley-db/bdb.c, rawsock/rawsock.c) to use the
> default that you meant. Please check them one by one. Were all of
> these defaults really intended as such?

yes, absolutely.

-- 
Sam Steingold (http://www.podval.org/~sds) running w2k
<http://www.camera.org> <http://www.iris.org.il> <http://www.memri.org/>
<http://www.mideasttruth.com/> <http://www.honestreporting.com>
Bus error -- driver executed.