Re: clisp/modules/syscalls Makefile.in,1.4,1.5 calls.c,1.42,1.43

[Sam S. <sd...@gn...>]

> * Bruno Haible <un...@hf...g> [2004-10-04 10:37:49 +0000]:
>
> More robust treatment of Solaris specific flags.

how is this better?
you are adding these defs on all platforms, even when this is not
necessary.
doesn't this hurt portability?

>
> Index: Makefile.in
> ===================================================================
> RCS file: /cvsroot/clisp/clisp/modules/syscalls/Makefile.in,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -u -d -r1.4 -r1.5
> --- Makefile.in	25 Feb 2004 16:23:00 -0000	1.4
> +++ Makefile.in	4 Oct 2004 10:37:47 -0000	1.5
> @@ -1,7 +1,9 @@
> -# Makefile for CLISP module set wildcard
> +# Makefile for CLISP module syscalls
>  
>  CC = @CC@
> -CPPFLAGS = @CPPFLAGS@
> +# __EXTENSIONS__ is necessary so that the Solaris headers declare confstr().
> +# _REENTRANT is necessary so that the Solaris headers declare lgamma_r().
> +CPPFLAGS = @CPPFLAGS@ -D__EXTENSIONS__ -D_REENTRANT
>  CFLAGS = @CFLAGS@
>  INCLUDES= ../
>  MODPREP = ../modprep.fas
>
> Index: calls.c
> ===================================================================
> RCS file: /cvsroot/clisp/clisp/modules/syscalls/calls.c,v
> retrieving revision 1.42
> retrieving revision 1.43
> diff -u -d -r1.42 -r1.43
> --- calls.c	4 Oct 2004 10:33:14 -0000	1.42
> +++ calls.c	4 Oct 2004 10:37:47 -0000	1.43
> @@ -29,13 +29,7 @@
>  # endif
>  #endif
>  #if defined(HAVE_UNISTD_H)
> -# ifdef __sun__
> -#  define __EXTENSIONS__         /* needed for confstr() */
> -# endif
>  # include <unistd.h>
> -# ifdef __sun__
> -#  undef __EXTENSIONS__
> -# endif
>  #endif
>  #if defined(HAVE_SYS_UNISTD_H)
>  # include <sys/unistd.h>
> @@ -157,17 +151,11 @@
>  
>  /* posix math functions in <math.h> */
>  /* Must include <math.h> */
> -#ifdef __sun__
> -# define _REENTRANT             /* needed for lgamma_r() */
> -#endif
>  #define decimal_string  solaris_decimal_string  /* needed on Solaris */
>  #undef floor  /* needed on Linux */
>  #include <math.h>
>  #define floor(a,b)  ((a) / (b))
>  #undef decimal_string
> -#ifdef __sun__
> -# undef _REENTRANT
> -#endif
>  
>  #define D_S           to_double(popSTACK())
>  #define I_S           to_int(popSTACK())
>
>
>

-- 
Sam Steingold (http://www.podval.org/~sds) running w2k
<http://www.camera.org> <http://www.iris.org.il> <http://www.memri.org/>
<http://www.mideasttruth.com/> <http://www.honestreporting.com>
Those who can laugh at themselves will never cease to be amused.