Re: [Chromium-dev] Texture crashes being caused by pack_texture.crev 1.35

[<bri...@tu...>]

I agree=2E  Whoever calls crPackAlloc() should call crPackFree()=2E  I was=

hesitant about that though because of the buffered vs=2E non-buffered case=
s=2E=20
They're different code paths=2E  See the IS_BUFFERED() test in
crHugePacket()=2E  But it looks like crPackFree() does the same test so it=

should be safe to call it all the time=2E

I'd say go ahead and check in your patch=2E

-Brian


Original Message:
-----------------
From: Michael Houston mhouston@graphics=2Estanford=2Eedu
Date: Tue, 28 Jun 2005 12:53:30 -0700
To: brian=2Epaul@tungstengraphics=2Ecom, chromium-dev@lists=2Esourceforge=2E=
net
Subject: Re: [Chromium-dev] Texture crashes being caused by
pack_texture=2Ecrev 1=2E35


Actually, I think the other way around makes more sense, i=2Ee=2E the call=
er=20
allocates the packet, so I think they should have to free it as well=2E  I=
=20
have a patched tree that already does this=2E  Most of the functions that=20=

use HugePacket currently issue the free=2E=2E=2E

-Mike

brian=2Epaul@tungstengraphics=2Ecom wrote:

>Mike wrote:
>
> =20
>
>>I tracked things down to pack_texture=2Ec in the 1=2E35 change list whic=
h is=20
>>causing the texture crashes for me=2E  It looks like some of the additio=
ns=20
>>of crPackFree()'s are incorrect and freeing NULL pointers=2E=2E=2E  We n=
eed to=20
>>take a longer look at that change list and probably back it out for now=2E=

>>   =20
>>
>
>I think the proper fix is to simply remove the crPackFree() calls from
>those functions=2E  When crHugePacket() is called, we wind up in a SPU
>function like packspuHuge() or tilesortHuge() which call crPackFree()
>themselves=2E
>
>We should probably add a comment to crHugePacket() in pack_buffer=2Ec to
>indicate that the caller should _not_ call crPackFree() and that it's up =
to
>the SPU routine called via pc->SendHuge() to do so=2E
>
>-Brian
>
>
>--------------------------------------------------------------------
>mail2web - Check your email from the web at
>http://mail2web=2Ecom/ =2E
>
>
>
>
>-------------------------------------------------------
>SF=2ENet email is sponsored by: Discover Easy Linux Migration Strategies
>from IBM=2E Find simple to follow Roadmaps, straightforward articles,
>informative Webcasts and more! Get everything you need to get up to
>speed, fast=2E http://ads=2Eosdn=2Ecom/?ad_idt77&alloc_id=16492&op=3Dclic=
k
>_______________________________________________
>Chromium-dev mailing list
>Chromium-dev@lists=2Esourceforge=2Enet
>https://lists=2Esourceforge=2Enet/lists/listinfo/chromium-dev
> =20
>

--------------------------------------------------------------------
mail2web - Check your email from the web at
http://mail2web=2Ecom/ =2E