[Chromium-users] Re: [Chromium-dev] Cr 1.5 release candidate

[Brian P. <br...@tu...>]

Alan Matsuoka wrote:
> I ran configtool.py and got this after selecting a tilesort
> template.
> 
> This may be because I'm running python 2.4 instead of 2.2.1.
> 
> 
> ./configtool.py
> Found SPU classes: ['array', 'binaryswap', 'comm', 'dist_texture', 'expando', 'f
> eedback', 'fps', 'hiddenline', 'injector', 'motionblur', 'pack', 'perf', 'print'
> , 'readback', 'render', 'saveframe', 'simplequery', 'tilesort', 'wet', 'zpix']
> Traceback (most recent call last):
>   File "/home/alanm/cr-1.5/mothership/tools/graph.py", line 697, in onNewTemplat
> e
>     if t.Create(self, self.mothership):
>   File "/home/alanm/cr-1.5/mothership/tools/tilesort_template.py", line 766, in 
> Create
>     tilesortSPU = crutils.NewSPU("tilesort")
>   File "/home/alanm/cr-1.5/mothership/tools/crutils.py", line 145, in NewSPU
>     spu = crtypes.SpuObject(spuName, SPUIsTerminal(spuName),
>   File "/home/alanm/cr-1.5/mothership/tools/crutils.py", line 136, in SPUIsTermi
> nal
>     (params, optionlist) = GetSPUOptions(spuName)
>   File "/home/alanm/cr-1.5/mothership/tools/crutils.py", line 112, in GetSPUOpti
> ons
>     result = eval(s)
>   File "<string>", line 0, in ?
>   File "/home/alanm/cr-1.5/mothership/tools/crtypes.py", line 29, in __init__
>     assert len(default) == count
> AssertionError


I found the problem.  I forgot to update spu/options/spuoptions.c to 
reflect a previous change.

Basically, in the SPU code which encodes options, if the option is 
multi-valued (like 'window_geometry' which has 4 values), the default, 
min and max values must be enclosed in brackets:

    { "window_geometry", CR_INT, 4, "[0, 0, 256, 256]", "[0, 0, 1, 
1]", NULL,
      "Default Window Geometry (x,y,w,h)", 
(SPUOptionCB)set_window_geometry },

This just formalizes something that's been true for the past few 
releases anyway.

I'll check in the fix after some testing.

-Brian