Menu ▾ ▴

#75 Fix release asset naming (use releaseAssetNamePattern)

closed
nobody
None
2026-07-06
2026-07-06
Anonymous
No

Originally created by: kristofferR

Root cause

tauri-action v1.0.0 (adopted in [#66]) renamed its naming input from assetNamePattern to releaseAssetNamePattern. release.yml still passed the old key, which the action only warns about and otherwise ignores. So every tauri-action-uploaded bundle (AppImage, NSIS .exe, .deb, .rpm) reverted to tauri's default names, while only the .dmg and portable .zip — renamed by explicit steps — kept the friendly Carrier_<ver>_<platform>_<arch> scheme.

Impact (since v1.2.0, the first release after the bump)

  • "Update Homebrew tap" fails with no assets match the file pattern: it downloads Carrier_<ver>_lin_arm.AppImage / lin_x64.AppImage, but the assets are uploaded as aarch64.AppImage / amd64.AppImage, so the cask never updates.
  • README Windows + Linux download buttons 404: they link to _win_x64_setup.exe / _lin_x64.AppImage, but the assets are x64-setup.exe / amd64.AppImage. (The macOS .dmg link works because the DMG has an explicit rename step.)

Verified against the live v1.2.1 assets — DMG/portable-zip friendly, everything else on tauri defaults.

Fix

Rename the input key assetNamePattern → releaseAssetNamePattern. All bundles then get the friendly names the README links and Homebrew cask already expect.

Interaction with [#74]

The macOS post-processing from [#74] keys off the old default names (Carrier_<ver>_x64.dmg, …_x64.app.tar.gz) to delete the unstapled DMG and the stock updater archives. Every one of those deletions is guarded by if [ -n "$id" ], so once friendly naming returns and those default-named assets no longer exist, the lookups simply become no-ops — the stapled mac_intel/mac_arm DMG and the latest.json → DMG rewrite are unaffected. Worth eyeballing the next release's macOS assets to confirm, but no code change is needed there.

Can only be fully verified by cutting a release. actionlint is clean.

Summary by CodeRabbit

  • Bug Fixes
  • Release artifacts now use consistent versioned filenames again, which helps keep download links working and package updates reliable.

Related

Tickets: #66
Tickets: #74

Discussion

  • Anonymous

    Anonymous - 2026-07-06

    Originally posted by: kristofferR

    @coderabbitai review

     
  • Anonymous

    Anonymous - 2026-07-06

    Originally posted by: coderabbitai[bot]

    ✅ Action performed Review finished. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
     
  • Anonymous

    Anonymous - 2026-07-06

    Ticket changed by: kristofferR

    • status: open --> closed
     
  • Anonymous

    Anonymous - 2026-07-06

    Originally posted by: coderabbitai[bot]

    Review Change Stack

    No actionable comments were generated in the recent review. 🎉

    ℹ️ Recent review info
    ⚙️ Run configuration **Configuration used**: Path: .coderabbit.yaml **Review profile**: ASSERTIVE **Plan**: Pro **Run ID**: `b4eb844f-a50a-4289-8c98-460836174953`
    📥 Commits Reviewing files that changed from the base of the PR and between [598dad] and b455371bed41a449fc8aa39d6a6b89c8a258d708.
    📒 Files selected for processing (1) * `.github/workflows/release.yml`

    📝 Walkthrough ## Walkthrough Updated the release workflow's tauri-action configuration to replace the deprecated `assetNamePattern` input with `releaseAssetNamePattern`, retaining the same versioned artifact naming pattern for build outputs. ### Changes **Release Workflow Asset Naming** |Layer / File(s)|Summary| |---|---| |**Update tauri-action input key**
    `.github/workflows/release.yml`|Replaced `assetNamePattern` with `releaseAssetNamePattern` for the tauri-action step, keeping the same `Carrier_[version]_${{ env.ASSET_PLATFORM }}_${{ env.ASSET_ARCH }}[_setup][ext]` pattern to ensure correct artifact naming.| **Estimated code review effort:** 1 (Trivial) | ~3 minutes **Possibly related PRs** - [[kristofferR/Carrier#2](https://github.com/kristofferR/Carrier/issues/2)](https://github.com/kristofferR/Carrier/pull/2): Both PRs modify the same workflow's tauri-action asset naming configuration for release artifacts.
    🚥 Pre-merge checks | ✅ 5
    ✅ Passed checks (5 passed) | Check name | Status | Explanation | | :------------------------: | :------- | :----------------------------------------------------------------------------------------------------------------- | | Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. | | Title check | ✅ Passed | The title clearly summarizes the main change: fixing release asset naming by switching to releaseAssetNamePattern. | | Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. | | Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. | | Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
    ✨ Finishing Touches
    🧪 Generate unit tests (beta) - [ ] Create PR with unit tests - [ ] Commit unit tests in branch `fix/release-asset-naming`

    Comment @coderabbitai help to get the list of available commands.

     

Log in to post a comment.