Originally created by: kristofferR
Carrier ships only the user-facing DMG for macOS, but Tauri's stock updater expects an .app.tar.gz payload. This wires the macOS updater to the DMG end to end.
release.yml)mac_intel (matching the Homebrew cask + release-notes asset names) instead of mac_x64.latest.json so the mac updater keys (darwin-aarch64 / darwin-x86_64 and their -app variants) point at the DMG URL + signature. Finally delete the stock unstapled .dmg and the .app.tar.gz updater archives so the public release stays clean.commands.rs)run_update_check by platform (#[cfg(target_os = "macos")] vs not).hdiutil (auto-detached via a Drop guard), locate Carrier.app, and swap the running bundle with ditto — with a backup/rollback if the copy fails, and an admin-privileges fallback (osascript) when the destination isn't user-writable.Local gate green: cargo fmt --check, cargo clippy --all-targets -D warnings (compiles the macOS-only code on a mac runner), cargo test (60 passed), actionlint. The end-to-end update flow can only be exercised against a real signed/notarized release, so that's worth a manual check on the next tag.
Note: authored in a prior session and finalized here — I verified it builds/lints/tests clean and is correctly wired into
check_for_updatesand the auto-check inlib.rs. Independent of [#73] (different files); merge after.
Ref [#48]
Originally posted by: kristofferR
@coderabbitai review
Originally posted by: coderabbitai[bot]
✅ Action performed
Review finished. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.Originally posted by: coderabbitai[bot]
✨ Finishing Touches
🧪 Generate unit tests (beta)
- [ ] Create PR with unit tests - [ ] Commit unit tests in branch `feat/macos-dmg-updater`Comment
@coderabbitai helpto get the list of available commands.Related
Commit: [2c3d95]
Originally posted by: kristofferR
@coderabbitai review
Originally posted by: coderabbitai[bot]
✅ Action performed
Review finished. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.Originally posted by: kristofferR
@coderabbitai review
Originally posted by: coderabbitai[bot]
✅ Action performed
Review finished. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.Originally posted by: kristofferR
@coderabbitai review
Originally posted by: coderabbitai[bot]
✅ Action performed
Review finished. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.Ticket changed by: kristofferR