Re: [Celestia-developers] Units in catalogue files

[Andrew T. <ajt...@go...>]

Ok I've commited the units support.

No problems with the idea of removing the XML parser: it isn't used
and Celestia doesn't appear to be moving in that direction.

Regards,
Andrew

2009/12/14 Chris Laurel <cl...@gm...>:
> Andrew,
>
> Your change looks very good. I appreciate that you took the time to add
> Doxygen formatting to some of the existing comments in the parser.
> I did some quick experiments with the units code just to verify that the
> patch applied correctly. All my tests worked as expected. After actually
> using writing an ssc definition with units, I find myself liking the prefix
> units convention very much.
> On a somewhat related note... I'd like to remove the source files
> solarsysxml.cpp and solarsysxml.h. These were part of an experiment from way
> back in 2002. The ssc file format has changed significantly since then, so
> the code is obsolete. I also doubt that switching to XML would be of any
> help to add-on creators
>
> --Chris
>
> On Sun, Dec 6, 2009 at 3:50 AM, Andrew Tribick <ajt...@go...>
> wrote:
>>
>> Hi,
>>
>> A new patch with more complete units integration is available here -->
>> http://www.shatters.net/forum/viewtopic.php?p=120420#p120420
>>
>> Regards,
>> Andrew
>>
>> 2009/12/1 Andrew Tribick <ajt...@go...>:
>> > This restructuring seems like a sensible idea to me, as does
>> > templatising the conversion functions.
>> >
>> > Would probably be a good idea at some point to go through the source
>> > replacing some of the magic numbers with named constants - numbers
>> > like 86400 and 365.25 make numerous appearances throughout the source
>> > code for example. At present though my focus is on getting the units
>> > support into the various hash parsers, currently got .stc and .dsc
>> > files done, working through solar system objects.
>> >
>> > Regards,
>> > Andrew
>> >
>> > 2009/11/30 Chris Laurel <cl...@gm...>:
>> >> Andrew,
>> >>
>> >> Your new units code has me wondering if it might not be a good idea to
>> >> create a new module 'celastro' which would contain the functions in the
>> >> current astro.cpp module. The astro module would contain the following
>> >> features:
>> >>
>> >> units.h / units.cpp:
>> >> Existing unit conversion functions plus your new ones.
>> >>
>> >> date.h / date.cpp:
>> >> Functions for converting from calendar dates to Julian dates, and for
>> >> converting between different time sytems (TDB, TAI, UTC, etc.)
>> >>
>> >> nutate.cpp and precession.cpp:
>> >> Move from celephem module, as these are used for conversion between
>> >> various
>> >> coordinate systems (J2000 inertial, mean equator of date, true equator
>> >> of
>> >> date, etc.)
>> >>
>> >> This reorganization would eliminate a dependency of celephem on
>> >> celengine.
>> >> Celephem should be the lower-level module, but it currently relies on
>> >> celengine for a few unit conversions. With the reorganization, we could
>> >> have
>> >> a clean 'layering' of modules:
>> >>
>> >> celutil
>> >> celmath
>> >> celastro
>> >> celephem cel3ds celtxf
>> >> celengine
>> >> celestia (which should probably be renamed something like celapp)
>> >>
>> >> Lastly, I've templatized some conversion functions in astro.cpp,
>> >> eliminating
>> >> the need for separate float and double versions. (I didn't bother with
>> >> the
>> >> microLightYear functions--these should be eliminated, as micro light
>> >> years
>> >> are no longer a necessary unit in Celestia except for backward
>> >> compatibility
>> >> with scripts and cel URLs.)
>> >>
>> >> --Chris
>> >>
>> >> On Sat, Nov 28, 2009 at 10:03 AM, Andrew Tribick
>> >> <ajt...@go...>
>> >> wrote:
>> >>>
>> >>> Hi everyone,
>> >>>
>> >>> I'm making a stab at adding units functionality to Celestia's
>> >>> catalogue files. My approach is to extend the syntax to allow a list
>> >>> of units, surrounded by angle brackets, to be placed after a property
>> >>> name.
>> >>>
>> >>> More details and diff file on the shatters forums here:
>> >>> http://www.shatters.net/forum/viewtopic.php?f=10&t=15561
>> >>>
>> >>> Regards,
>> >>> Andrew
>> >>>
>> >>>
>> >>>
>> >>> ------------------------------------------------------------------------------
>> >>> Let Crystal Reports handle the reporting - Free Crystal Reports 2008
>> >>> 30-Day
>> >>> trial. Simplify your report design, integration and deployment - and
>> >>> focus
>> >>> on
>> >>> what you do best, core application coding. Discover what's new with
>> >>> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
>> >>> _______________________________________________
>> >>> Celestia-developers mailing list
>> >>> Cel...@li...
>> >>> https://lists.sourceforge.net/lists/listinfo/celestia-developers
>> >>
>> >>
>> >
>
>