Re: [Celestia-developers] Code organisation

[Chris L. <cl...@gm...>]

Vincent,

You're right that the Qt project file should definitely not refer to an icon
in the win32 directory. We could move it to src/celestia, but I'd prefer to
just copy the icon into src/celestia/qt instead, as the win32 version is
almost at the end of its life. Can you take care of copying the icon and
fixing the celestia.pro?

--Chris

On Sat, Nov 7, 2009 at 8:39 AM, vincent <vin...@fr...> wrote:

> Chris,
>
> The Windows version still compiles fine, though it seems to take
> quite longer than previously. As to the Qt4 version, I got the
> following fatal error messsage:
>  celestia\qt\celestia.rc(1) : error RC2135 : file not found:
>  celestia\res\Celestia.ico
>
> The following change fixes the problem:
>
>  Index: celestia.rc
>  ===================================================================
>  --- celestia.rc       (revision 4906)
>  +++ celestia.rc       (working copy)
>  @@ -1 +1 @@
>  -IDI_ICON1 ICON DISCARDABLE "celestia\\res\\Celestia.ico"
>  +IDI_ICON1 ICON DISCARDABLE "celestia\\win32\\res\\Celestia.ico"
>
> I'm not sure that refering to the "win32/" dir in the Qt code is a
> good thing, though. The Celestia.ico file should rather be moved in
> a common dir or, at least, copied/pasted somewhere in the "qt/' dir.
>
> @+
> Vincent
>
>
>
> Selon Chris Laurel <cl...@gm...>:
>
> > I just took care of moving all the Win32 front end source files into a
> > separate subdirectory. Now, the Windows UI code is organized just like
> the
> > code for all the other front ends. Finally.
> >
> > --Chris
> >
> > On Thu, Nov 5, 2009 at 11:49 AM, Chris Laurel <cl...@gm...> wrote:
> >
> > > Thank you for testing, Vincent. Attached is a patch for
> > > src/celengine/Makefile.am that should take care of the non-Qt Linux
> build.
> > >
> > > The separation of files into celephem wasn't totally clean. There
> remain
> > > two dependencies on the celengine module:
> > > - Various functions in astro.h/astro.cpp are used, entirely for trivial
> > > things like converting from seconds to days.
> > > - The 'Value' class from the parser is used by the ScriptedOrbit and
> > > ScriptedRotation classes.
> > >
> > > The Value class is really a variant record. It should be renamed to
> this,
> > > cleaned up, and moved from the parser into the celutil module. The
> astro
> > > functions also need a new home. They could either go into celmath, or
> we
> > > could create a new module.
> > >
> > > --Chris
> > >
> > >
> > > On Tue, Nov 3, 2009 at 3:43 AM, vincent <vin...@fr...> wrote:
> > >
> > >> Chris,
> > >>
> > >> After making a SVN update, both the Windows and the Qt4 versions
> > >> compiled and run fine on my system.
> > >>
> > >> Vincent
> > >>
> > >>
> > >> From: Chris Laurel <claurel@gm...> - 2009-11-02 19:16
> > >>
> > >> > I am checking in the reorganization of the ephemeris files. The only
> > >> project
> > >> > files affected are those for Qt4 and Windows. I'll update the Mac
> XCode
> > >> > project and Linux makefiles very soon, but there will be a couple
> during
> > >> > which it will not be possible to build the SVN code on these
> platforms.
> > >> >
> > >> > --Chris
> > >>
> > >>
> > >
> >
>
>
>