#210 Front panel (inculding clock) colors is incorrect.

[Henry H]

This bevel/outline colors is incorrect.

[Henry H]

Should be (like this)

[Henry H]

Alternatively, CDE from 1993 - 2012

[Techokami]

Hrmmmmmmmm... I see what's going wrong here. The bevel color is using the 6th color in the palette, when it should be using the 5th. I'm going to try and look at Dtwm's code to try and figure out where this error is.

[Henry H]

Any Updates?

Also, I made a post recently (see: https://sourceforge.net/p/cdesktopenv/tickets/210/#a236) because I forgot to use the reply function.

[Henry H]

What looked like originally front panel used blue/teal color in 2012.
Later, front panel was changed to tan/beige color but didn’t change bevel/clock color in 2013. (see: https://sourceforge.net/p/cdesktopenv/code/ci/cc076d775603048270ea43b3965788dad93c5201/)

[Reaper]

I've investigated the front-panel shadow mismatch and prepared a proposed fix for testing.

The issue originates in WriteOutXrmColors() in cde/programs/dtwm/WmResource.c, where broadly applied secondary shadow-color resources override Motif's normal background-dependent shadow calculation.

The proposed fix removes those two overrides, allowing Motif to derive the correct shadow colors for each widget.

SourceForge commit:

https://sourceforge.net/u/johngrimmreaper/cdesktopenv/ci/2a062f96ace91208c38608f3e6d87670f2905724/

Clone the testing branch directly from my SourceForge fork:

git clone \
  --branch fix/ticket-210-motif-shadow-resources \
  --single-branch \
  https://git.code.sf.net/u/johngrimmreaper/cdesktopenv \
  cdesktopenv-ticket-210

cd cdesktopenv-ticket-210

build however way you usually build CDE

The proposed change has been compiled and tested with the CDE color server under 24-bit and 8-bit X11 displays. The front-panel shadows now match the primary palette, while popup menus retain their secondary palette colors.

Visual regression testing is still needed, particularly for the clock, main front-panel bevels, subpanels, dialogs, and monochrome configurations.

Feedback on the visual behavior and compatibility with CDE's established Motif widget conventions would be greatly appreciated.

[Henry H]

I tried experimenting CDE.
But, the button was never changed in front-panel.

[Reaper]

which patches ?
did you try building my branch ?

git clone \
  --branch fix/ticket-210-motif-shadow-resources \
  --single-branch \
  https://git.code.sf.net/u/johngrimmreaper/cdesktopenv \
  cdesktopenv-ticket-210

cd cdesktopenv-ticket-210

[Henry H]

Yes, I did.
I said button menu (not bevel/clock) was not changed.
Why you not open my screenshot?

[Reaper]

I did open your screenshot, I just asked because you said patches in plural, and my branch has only 1 commit above the master's HEAD. So it wasn't clear to me what exactly you had tested.

Okay, thank you for your testing.

[Henry H]

I'm sorry for confusion.