Re: [cdesktopenv-devel] OpenBSD port

[Jon T. <jo...@ra...>]

On Thu, 9 Aug 2012, Pascal Stumpf wrote:

> On Wed, 8 Aug 2012 19:53:23 -0600 (MDT), Jon Trulson wrote:
>> On Wed, 8 Aug 2012, Pascal Stumpf wrote:
>>
>>> On Tue, 07 Aug 2012 21:51:14 +0200, Pascal Stumpf wrote:
>>>> Ohai.
>>>>
[...]

>> For example, The very first diff deletes a line
>> InstallLinkKitSubdirs($(DOCSUBDIRS))
>
> This is an old and obsolete macro fron XFree86 times, and a noop in the
> current situation anyway.  It's no longer defined for modern imake and
> must be removed if building/configuring with external imake is supposed
> to be supported in the future.
>

Ok.

>> from the top level Imakefile without explanation.  Why is this being
>> deleted?
>>
>> Further down, I see:
>>
>>> +       CXXLIB = CplusplusLibC
>>
>> For Library.tmpl.  This should not be needed, it's already set
>> properly in Imake.tmpl.
>
> Looking into this again, yes, there's a better solution.  Problem was
> that HasCplusplus didn't get defined to YES.  I think Imake.tmpl should
> default that to YES (or get rid of it altogether: how are you even
> supposed to compile CDE without a c++ compiler??).  Currently, most
> $OS.cf files are simply setting HasGcc2ForCplusplus, which is obviously
> a lie nowadays.
>

Ok.

>> Same for some of the other items.  I simply cannot commit this.
>>
>> Lots of the other patches look good, but I simply do not have the time or
>> patience to try to seperate, evaluate and commit each one :)
>>
>> What I need are seperate patches, small and self contained (or even a
>> collection of related patches for a given subsystem) that I can have
>> some hope of reviewing, commenting on, commiting, or rejecting.
>
> Ok, sorry.  I'll try to separate the patch into smaller bits today.
>

Thank you!

>> Perhaps you and others working on the BSD ports could contribute to a
>> shared repo (maybe yours, I don't know) and arrange this.
>
> I'm not fond of that, since that means there will be even more
> fragmentation and probably merge problems and duplicate work (on 64bit
> issues for instance).
>

Ok, no problem - I (and I'm sure many others) really appreciate the
work.  Just wanted to find a solution that works for everyone.


[...]

-- 
Jon Trulson

"If the Martian rope-a-dope don't get him, he'll get himself, he'll
  come in too fast and punch himself out."
              - one of my brothers, referring to the Curiosity landing.