Re: [cdesktopenv-devel] OpenBSD port

[Pascal S. <Pas...@cu...>]

On Wed, 8 Aug 2012 19:53:23 -0600 (MDT), Jon Trulson wrote:
> On Wed, 8 Aug 2012, Pascal Stumpf wrote:
> 
> > On Tue, 07 Aug 2012 21:51:14 +0200, Pascal Stumpf wrote:
> >> Ohai.
> >>
> >> Just informing you guys that I'm currently working on an OpenBSD port.
> >> Already got most stuff building and a shitload of patches (though mostly
> >> just #ifdef's).  I'll probably start making a branch in a few days,
> >> though this will need to be merged with the other porting efforts
> >> (FreeBSD ...).
> >>
> >> Cheers,
> >> Pascal
> >
> > So here's a patch with all the changes to make it compile on OpenBSD.
> > It does not work yet, but I'd like to get this in as soon as possible to
> > facilitate further work.
> >
> > These are mostly #ifdef's, adapting to new standards (scope of var decls
> > in for loops), at least one 64bit bug and a fix for istr_string if it is
> > fed a NULL pointer.  The database file patches contain some stuff that
> > is specific to my port (on github, openbsd-wip/x11/cde), but I think the
> > whole install framework should be revisited anyway to something that
> > respects $PREFIX (for fake installation) and doesn't hardcode shared
> > library versions.
> >
> >
> 
> Hi,
> 
> I am not sure what to do with this... It is far too large for me to be
> able to review, and either it all goes in, or nothing does.  While
> a lot of what I see seems ok, there are other things that aren't...
> 
> For example, The very first diff deletes a line
> InstallLinkKitSubdirs($(DOCSUBDIRS))

This is an old and obsolete macro fron XFree86 times, and a noop in the
current situation anyway.  It's no longer defined for modern imake and
must be removed if building/configuring with external imake is supposed
to be supported in the future.

> from the top level Imakefile without explanation.  Why is this being
> deleted?
> 
> Further down, I see:
> 
> > +       CXXLIB = CplusplusLibC
> 
> For Library.tmpl.  This should not be needed, it's already set
> properly in Imake.tmpl.

Looking into this again, yes, there's a better solution.  Problem was
that HasCplusplus didn't get defined to YES.  I think Imake.tmpl should
default that to YES (or get rid of it altogether: how are you even
supposed to compile CDE without a c++ compiler??).  Currently, most
$OS.cf files are simply setting HasGcc2ForCplusplus, which is obviously
a lie nowadays.

> Same for some of the other items.  I simply cannot commit this.
> 
> Lots of the other patches look good, but I simply do not have the time or
> patience to try to seperate, evaluate and commit each one :)
> 
> What I need are seperate patches, small and self contained (or even a
> collection of related patches for a given subsystem) that I can have
> some hope of reviewing, commenting on, commiting, or rejecting.

Ok, sorry.  I'll try to separate the patch into smaller bits today.

> Perhaps you and others working on the BSD ports could contribute to a
> shared repo (maybe yours, I don't know) and arrange this.

I'm not fond of that, since that means there will be even more
fragmentation and probably merge problems and duplicate work (on 64bit
issues for instance).

> We might even be willing to create a seperate 'BSD' branch where the
> BSD patches could go until they are ready for master.  We are willing
> to work with you on this, but I simply cannot deal with a 300K blob
> of patches :)
> 
> [...]
> 
> -- 
> Jon Trulson
> 
> "If the Martian rope-a-dope don't get him, he'll get himself, he'll
>   come in too fast and punch himself out."
>               - one of my brothers, referring to the Curiosity landing.
> 
>