[ bzflag-Patches-2893897 ] Fixes to screenshot thread handling

[SourceForge.net <no...@so...>]

Patches item #2893897, was opened at 2009-11-07 18:44
Message generated for change (Comment added) made by atupone
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=303248&aid=2893897&group_id=3248

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: BZFlag
Group: Evaluate
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Russell Bryant (russellbryant)
>Assigned to: Tupone Alfredo (atupone)
Summary: Fixes to screenshot thread handling

Initial Comment:
This patch addresses two things with the pthread version of screenshot thread creation:

1) The use of pthread_mutex_init() here is unnecessary since the mutex is already statically initialized.

2) The thread is created but never joined.  Since threads are joinable by default, this results in a memory leak.  There will be some system resources that persist while waiting for the application to run pthread_join() on that thread ID.  The fix is to create the thread as detached so that joining is not required.

----- Testing Done -----

Platform: Mac OSX - 10.6

I generated a bunch of screenshots and verified that the output was correct.

----------------------------------------------------------------------

Comment By: Tupone Alfredo (atupone)
Date: 2011-10-14 12:25

Message:
Applied to SVN, Thanx!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=303248&aid=2893897&group_id=3248