From: SourceForge.net <no...@so...> - 2009-07-26 07:50:48
|
Patches item #2823741, was opened at 2009-07-18 16:37 Message generated for change (Comment added) made by sosedada You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=303248&aid=2823741&group_id=3248 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: BZFlag Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: qqqqqqqq (qqqqqqqq-x) Assigned to: Daniel Remenak (dtremenak) Summary: Fixes crashes Initial Comment: BZFlag used to crash when you either used 'c' to clear the server list, or used 'h' to remove the last server. I'll be honest, I don't fully understand what is going on here, so you should really review that this fix is right. lol. ---------------------------------------------------------------------- Comment By: Thomas Matelich (sosedada) Date: 2009-07-26 00:50 Message: In my opinion, a good start would be removing the public inheritance of HUDNavigationQueue from std::deque. The fact that people can change the contents of the queue w/o it "knowing" about it is dangerous. In my independent investigation of this bug, I fixed it by adding //sanitize focus if(focus >= size()) focus = size() - 1; to the end of internal_set. This prevent the crash, which occurs because focus is 1 while the queue only has one element in it. >From my limited understanding, I don't think this is an issue at the HUDuiTabbedControl level, but I could be wrong. ---------------------------------------------------------------------- Comment By: Daniel Remenak (dtremenak) Date: 2009-07-19 01:11 Message: This is almost certainly not a correct fix. The server list has more fundamental NavQueue problems that need to be addressed (probably at the HUDuiTabbedControl level). I'll try to take a look at it sometime soon. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=303248&aid=2823741&group_id=3248 |